Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-11245

Move prepare_create_field and sp_prepare_create_field() as methods to Column_definition

Details

    • 10.2.4-2

    Description

      Currently prepare_create_field() and sp_prepare_create_field() are global functions defined in sql_table.cc.
      MDEV-10577 and MDEV-10914 will use more prepare_create_field() and sp_prepare_create_field().
      It's better to move these functions as method to Column_definition.

      Attachments

        Issue Links

          blocks

          Epic - Created by Jira Software - do not edit or delete. Issue type for a big user story that needs to be broken down. MDEV-4912 Data type plugin API version 1

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Technical task - A technical task. MDEV-10577 sql_mode=ORACLE: %TYPE in variable declarations

          • Major - Major loss of function.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            bar Alexander Barkov created issue -
            bar Alexander Barkov made changes -
            Field Original Value New Value
            bar Alexander Barkov made changes -
            Description Currently prepare_create_field() and sp_prepare_create_field() are global functions defined in sql_table.cc.
            MDEV-10577 will use more prepare_create_field() and sp_prepare_create_field().
            It's better to move these functions as method to Column_definition.
            bar Alexander Barkov made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            bar Alexander Barkov made changes -
            Assignee Alexander Barkov [ bar ] Michael Widenius [ monty ]
            Status In Progress [ 3 ] In Review [ 10002 ]
            ratzpo Rasmus Johansson (Inactive) made changes -
            Sprint 10.2.4-2 [ 113 ]
            bar Alexander Barkov made changes -
            Assignee Michael Widenius [ monty ] Oleksandr Byelkin [ sanja ]
            bar Alexander Barkov made changes -
            Description Currently prepare_create_field() and sp_prepare_create_field() are global functions defined in sql_table.cc.
            MDEV-10577 will use more prepare_create_field() and sp_prepare_create_field().
            It's better to move these functions as method to Column_definition.
            		Currently prepare_create_field() and sp_prepare_create_field() are global functions defined in sql_table.cc.
            MDEV-10577 and MDEV-10914 will use more prepare_create_field() and sp_prepare_create_field().
            It's better to move these functions as method to Column_definition.
            sanja Oleksandr Byelkin made changes -
            Status In Review [ 10002 ] Stalled [ 10000 ]
            sanja Oleksandr Byelkin added a comment -

            OK to push.

            sanja Oleksandr Byelkin added a comment - OK to push.
            bar Alexander Barkov made changes -
            Assignee Oleksandr Byelkin [ sanja ] Alexander Barkov [ bar ]
            bar Alexander Barkov made changes -
            Status Stalled [ 10000 ] In Progress [ 3 ]
            bar Alexander Barkov made changes -
            issue.field.resolutiondate 2016-11-20 04:05:45.0 2016-11-20 04:05:45.08
            bar Alexander Barkov made changes -
            Fix Version/s 10.3.0 [ 22127 ]
            Fix Version/s 10.3 [ 22126 ]
            Resolution Fixed [ 1 ]
            Status In Progress [ 3 ] Closed [ 6 ]
            bar Alexander Barkov made changes -
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 78223 ] MariaDB v4 [ 132993 ]

            People

              bar Alexander Barkov
              bar Alexander Barkov
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.