Type:
Task
Priority:
Major
Resolution:
Fixed
Currently prepare_create_field() and sp_prepare_create_field() are global functions defined in sql_table.cc.
MDEV-10577 and MDEV-10914 will use more prepare_create_field() and sp_prepare_create_field().
It's better to move these functions as method to Column_definition.
{"report":{"fcp":783.2999997138977,"ttfb":174.59999990463257,"pageVisibility":"visible","entityId":58823,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":1,"journeyId":"7c8972b7-35dd-4f9a-8070-9b427d1b332d","navigationType":0,"readyForUser":862.6999998092651,"redirectCount":0,"resourceLoadedEnd":1168.1999998092651,"resourceLoadedStart":180.39999961853027,"resourceTiming":[{"duration":32.90000009536743,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":180.39999961853027,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":180.39999961853027,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":213.2999997138977,"responseStart":0,"secureConnectionStart":0},{"duration":33.19999980926514,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":180.59999990463257,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":180.59999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":213.7999997138977,"responseStart":0,"secureConnectionStart":0},{"duration":111.30000019073486,"initiatorType":"script","name":"https://jira.mariadb.org/s/0917945aaa57108d00c5076fea35e069-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":180.7999997138977,"connectEnd":180.7999997138977,"connectStart":180.7999997138977,"domainLookupEnd":180.7999997138977,"domainLookupStart":180.7999997138977,"fetchStart":180.7999997138977,"redirectEnd":0,"redirectStart":0,"requestStart":180.7999997138977,"responseEnd":292.09999990463257,"responseStart":292.09999990463257,"secureConnectionStart":180.7999997138977},{"duration":208.39999961853027,"initiatorType":"script","name":"https://jira.mariadb.org/s/2d8175ec2fa4c816e8023260bd8c1786-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":181,"connectEnd":181,"connectStart":181,"domainLookupEnd":181,"domainLookupStart":181,"fetchStart":181,"redirectEnd":0,"redirectStart":0,"requestStart":181,"responseEnd":389.3999996185303,"responseStart":389.3999996185303,"secureConnectionStart":181},{"duration":211.90000009536743,"initiatorType":"script","name":"https://jira.mariadb.org/s/a9324d6758d385eb45c462685ad88f1d-CDN/lu2cib/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":181.09999990463257,"connectEnd":181.09999990463257,"connectStart":181.09999990463257,"domainLookupEnd":181.09999990463257,"domainLookupStart":181.09999990463257,"fetchStart":181.09999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":181.09999990463257,"responseEnd":393,"responseStart":393,"secureConnectionStart":181.09999990463257},{"duration":212.2000002861023,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":181.2999997138977,"connectEnd":181.2999997138977,"connectStart":181.2999997138977,"domainLookupEnd":181.2999997138977,"domainLookupStart":181.2999997138977,"fetchStart":181.2999997138977,"redirectEnd":0,"redirectStart":0,"requestStart":181.2999997138977,"responseEnd":393.5,"responseStart":393.5,"secureConnectionStart":181.2999997138977},{"duration":212.2999997138977,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":181.5,"connectEnd":181.5,"connectStart":181.5,"domainLookupEnd":181.5,"domainLookupStart":181.5,"fetchStart":181.5,"redirectEnd":0,"redirectStart":0,"requestStart":181.5,"responseEnd":393.7999997138977,"responseStart":393.7999997138977,"secureConnectionStart":181.5},{"duration":267.40000009536743,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2cib/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":181.69999980926514,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":181.69999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":449.09999990463257,"responseStart":0,"secureConnectionStart":0},{"duration":212.40000009536743,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":181.7999997138977,"connectEnd":181.7999997138977,"connectStart":181.7999997138977,"domainLookupEnd":181.7999997138977,"domainLookupStart":181.7999997138977,"fetchStart":181.7999997138977,"redirectEnd":0,"redirectStart":0,"requestStart":181.7999997138977,"responseEnd":394.19999980926514,"responseStart":394.19999980926514,"secureConnectionStart":181.7999997138977},{"duration":267.3999996185303,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":182,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":182,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":449.3999996185303,"responseStart":0,"secureConnectionStart":0},{"duration":212.7999997138977,"initiatorType":"script","name":"https://jira.mariadb.org/s/5d5e8fe91fbc506585e83ea3b62ccc4b-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":182.09999990463257,"connectEnd":182.09999990463257,"connectStart":182.09999990463257,"domainLookupEnd":182.09999990463257,"domainLookupStart":182.09999990463257,"fetchStart":182.09999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":182.09999990463257,"responseEnd":394.8999996185303,"responseStart":394.8999996185303,"secureConnectionStart":182.09999990463257},{"duration":870.1999998092651,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":183.69999980926514,"connectEnd":183.69999980926514,"connectStart":183.69999980926514,"domainLookupEnd":183.69999980926514,"domainLookupStart":183.69999980926514,"fetchStart":183.69999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":183.69999980926514,"responseEnd":1053.8999996185303,"responseStart":1053.8999996185303,"secureConnectionStart":183.69999980926514},{"duration":914.9000000953674,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":183.7999997138977,"connectEnd":183.7999997138977,"connectStart":183.7999997138977,"domainLookupEnd":183.7999997138977,"domainLookupStart":183.7999997138977,"fetchStart":183.7999997138977,"redirectEnd":0,"redirectStart":0,"requestStart":183.7999997138977,"responseEnd":1098.6999998092651,"responseStart":1098.6999998092651,"secureConnectionStart":183.7999997138977},{"duration":628.4000000953674,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":462.2999997138977,"connectEnd":462.2999997138977,"connectStart":462.2999997138977,"domainLookupEnd":462.2999997138977,"domainLookupStart":462.2999997138977,"fetchStart":462.2999997138977,"redirectEnd":0,"redirectStart":0,"requestStart":462.2999997138977,"responseEnd":1090.6999998092651,"responseStart":1090.6999998092651,"secureConnectionStart":462.2999997138977},{"duration":460.7000002861023,"initiatorType":"script","name":"https://www.google-analytics.com/analytics.js","startTime":775.7999997138977,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":775.7999997138977,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1236.5,"responseStart":0,"secureConnectionStart":0},{"duration":71.69999980926514,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/e65b778d185daf5aee24936755b43da6/_/download/contextbatch/js/browser-metrics-plugin.contrib,-_super,-project.issue.navigator,-jira.view.issue,-atl.general/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":1096.5,"connectEnd":1096.5,"connectStart":1096.5,"domainLookupEnd":1096.5,"domainLookupStart":1096.5,"fetchStart":1096.5,"redirectEnd":0,"redirectStart":0,"requestStart":1096.5,"responseEnd":1168.1999998092651,"responseStart":1168.1999998092651,"secureConnectionStart":1096.5}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":25,"responseStart":175,"responseEnd":176,"domLoading":179,"domInteractive":1254,"domContentLoadedEventStart":1254,"domContentLoadedEventEnd":1297,"domComplete":1525,"loadEventStart":1525,"loadEventEnd":1525,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":1237.5},{"name":"bigPipe.sidebar-id.end","time":1238.3999996185303},{"name":"bigPipe.activity-panel-pipe-id.start","time":1238.5999999046326},{"name":"bigPipe.activity-panel-pipe-id.end","time":1239.3999996185303},{"name":"activityTabFullyLoaded","time":1310.1999998092651}],"measures":[],"correlationId":"6c60cbb8cde34e","effectiveType":"4g","downlink":9.6,"rtt":0,"serverDuration":95,"dbReadsTimeInMs":13,"dbConnsTimeInMs":22,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}
OK to push.