Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-11211

TokuDB does not pass cmake flags on to snappy cmake

Details

    Description

      CMake does not pass on the CMAKE_AR, CMAKE_NM and CMAKE_RANLIB flags when building Snappy. This results in warnings when building MariaDB with LTO enabled, I imagine this might also cause problems with cross-compiling.

      Linking CXX static library libsnappy.a
      BFD: CMakeFiles/snappy.dir/snappy.o: plugin needed to handle lto object
      BFD: CMakeFiles/snappy.dir/snappy-c.o: plugin needed to handle lto object
      BFD: CMakeFiles/snappy.dir/snappy-sinksource.o: plugin needed to handle lto object
      BFD: CMakeFiles/snappy.dir/snappy-stubs-internal.o: plugin needed to handle lto object
      BFD: snappy.o: plugin needed to handle lto object
      BFD: snappy-c.o: plugin needed to handle lto object
      BFD: snappy-sinksource.o: plugin needed to handle lto object
      BFD: snappy-stubs-internal.o: plugin needed to handle lto object
      [100%] Built target snappy

      Suggested patch attached.

      Attachments

        Activity

          Transition Time In Source Status Execution Times
          Vicențiu Ciorbaru made transition -
          Open Closed
          		1708d 11h 5m 1

          People

            cvicentiu Vicențiu Ciorbaru
            Dead2 Hans Kristian Rosbach
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.