[MDEV-11211] TokuDB does not pass cmake flags on to snappy cmake Created: 2016-11-02  Updated: 2021-07-07  Resolved: 2021-07-07

Status: Closed
Project: MariaDB Server
Component/s: Compiling, Storage Engine - TokuDB
Affects Version/s: 10.1.18
Fix Version/s: 10.1.26, 10.0.32, 10.2.8, 10.3.1

Type: Bug Priority: Minor
Reporter: Hans Kristian Rosbach Assignee: Vicențiu Ciorbaru
Resolution: Fixed Votes: 0
Labels: contribution, upstream

Attachments: File fix-snappy-lto-build.patch    

 Description   

CMake does not pass on the CMAKE_AR, CMAKE_NM and CMAKE_RANLIB flags when building Snappy. This results in warnings when building MariaDB with LTO enabled, I imagine this might also cause problems with cross-compiling.

Linking CXX static library libsnappy.a
BFD: CMakeFiles/snappy.dir/snappy.o: plugin needed to handle lto object
BFD: CMakeFiles/snappy.dir/snappy-c.o: plugin needed to handle lto object
BFD: CMakeFiles/snappy.dir/snappy-sinksource.o: plugin needed to handle lto object
BFD: CMakeFiles/snappy.dir/snappy-stubs-internal.o: plugin needed to handle lto object
BFD: snappy.o: plugin needed to handle lto object
BFD: snappy-c.o: plugin needed to handle lto object
BFD: snappy-sinksource.o: plugin needed to handle lto object
BFD: snappy-stubs-internal.o: plugin needed to handle lto object
[100%] Built target snappy

Suggested patch attached.



 Comments   
Comment by Sergei Golubchik [ 2017-02-21 ]

Reported upstream

Comment by Vicențiu Ciorbaru [ 2021-07-07 ]

This was automatically fixed by importing upstream.

Generated at Thu Feb 08 07:48:10 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.