Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-11202

InnoDB 10.1 -> 10.2 migration does not work

Details

    • 10.2.4-4, 10.2.4-1, 10.2.4-5, 10.1.21

    Description

      See dictionary and tablespace flags from source code.

      Attachments

        Issue Links

          Activity

            jplindst Jan Lindström (Inactive) added a comment - http://lists.askmonty.org/pipermail/commits/2016-December/010299.html

            The commit seems to include some changes for MDEV-11600, which I think should be done separately.

            I think that we need some more code removal and also more testing. I got the impression that already the upgrade from MariaDB 10.0 to MariaDB 10.1 might not work when a non-default innodb_page_size is being used.

            marko Marko Mäkelä added a comment - The commit seems to include some changes for MDEV-11600 , which I think should be done separately. I think that we need some more code removal and also more testing. I got the impression that already the upgrade from MariaDB 10.0 to MariaDB 10.1 might not work when a non-default innodb_page_size is being used.

            I believe that this issue will be fixed when I merge MDEV-11623 from 10.1.
            For that, some preparation is needed to reduce our dependency on FSP_SPACE_FLAGS stored in page 0. The patch to reduce that dependency is waiting for review.

            marko Marko Mäkelä added a comment - I believe that this issue will be fixed when I merge MDEV-11623 from 10.1. For that, some preparation is needed to reduce our dependency on FSP_SPACE_FLAGS stored in page 0. The patch to reduce that dependency is waiting for review.

            There is unrelated changes (space_id -> fil_space_t*) but in my opinion they are good. Ok to push.

            jplindst Jan Lindström (Inactive) added a comment - There is unrelated changes (space_id -> fil_space_t*) but in my opinion they are good. Ok to push.

            Thank you. Replacing space_id with fil_space_t* is not an unrelated change. It is necessary in order to avoid performing more tablespace ID lookups, worsening the contention on fil_system->mutex. Because we cannot trust the FSP_SPACE_FLAGS from page 0, we must access fil_space_t::flags.

            marko Marko Mäkelä added a comment - Thank you. Replacing space_id with fil_space_t* is not an unrelated change. It is necessary in order to avoid performing more tablespace ID lookups, worsening the contention on fil_system->mutex. Because we cannot trust the FSP_SPACE_FLAGS from page 0, we must access fil_space_t::flags.

            People

              marko Marko Mäkelä
              jplindst Jan Lindström (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.