Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-10983

TokuDB does not compile on OS X 10.12

Details

    Description

      New 10.12 OS X has deprecated syscall(). Tokudb fails with:

      /Users/vicentiu/Workspace/MariaDB/storage/tokudb/PerconaFT/portability/portability.cc:115:12: error: 'syscall' is deprecated: first deprecated in macOS 10.12 - syscall(2) is unsupported; please switch to a supported interface. For
      		 
            SYS_kdebug_trace use kdebug_signpost(). [-Werror,-Wdeprecated-declarations]
      		 
          return syscall(SYS_gettid);

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-12304 TokuDB doesn't compile on Debian GNU/kFreeBSD

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            cvicentiu Vicențiu Ciorbaru added a comment -

            Hi Sergei!

            Can you please review a patch that fixes this issue?

            I have a separate approach that changes the return type of toku_os_gettid() from int to uint64_t. The second one requires a few more changes within the code though and I was not sure if it we're ok with changing the definition as it seems to be exported externally.

            http://lists.askmonty.org/pipermail/commits/2016-October/009976.html

            cvicentiu Vicențiu Ciorbaru added a comment - Hi Sergei! Can you please review a patch that fixes this issue? I have a separate approach that changes the return type of toku_os_gettid() from int to uint64_t. The second one requires a few more changes within the code though and I was not sure if it we're ok with changing the definition as it seems to be exported externally. http://lists.askmonty.org/pipermail/commits/2016-October/009976.html
            serg Sergei Golubchik added a comment -

            Apparently this one is already pushed

            serg Sergei Golubchik added a comment - Apparently this one is already pushed
            cvicentiu Vicențiu Ciorbaru added a comment -

            Fixed with:
            39dceaae607e2c9f53146d5b23f8dee330643cb2

            cvicentiu Vicențiu Ciorbaru added a comment - Fixed with: 39dceaae607e2c9f53146d5b23f8dee330643cb2

            People

              cvicentiu Vicențiu Ciorbaru
              cvicentiu Vicențiu Ciorbaru
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.