[MDEV-10983] TokuDB does not compile on OS X 10.12 Created: 2016-10-08  Updated: 2018-06-10  Resolved: 2016-10-26

Status: Closed
Project: MariaDB Server
Component/s: Compiling, Storage Engine - TokuDB
Affects Version/s: 10.0, 10.1
Fix Version/s: 10.0.28

Type: Bug Priority: Major
Reporter: Vicențiu Ciorbaru Assignee: Vicențiu Ciorbaru
Resolution: Fixed Votes: 0
Labels: clang, foundation, mac, tokudb

Issue Links:
Relates
relates to MDEV-12304 TokuDB doesn't compile on Debian GNU/... Open

 Description   

New 10.12 OS X has deprecated syscall(). Tokudb fails with:

/Users/vicentiu/Workspace/MariaDB/storage/tokudb/PerconaFT/portability/portability.cc:115:12: error: 'syscall' is deprecated: first deprecated in macOS 10.12 - syscall(2) is unsupported; please switch to a supported interface. For
 
      SYS_kdebug_trace use kdebug_signpost(). [-Werror,-Wdeprecated-declarations]
 
    return syscall(SYS_gettid);



 Comments   
Comment by Vicențiu Ciorbaru [ 2016-10-09 ]

Hi Sergei!

Can you please review a patch that fixes this issue?

I have a separate approach that changes the return type of toku_os_gettid() from int to uint64_t. The second one requires a few more changes within the code though and I was not sure if it we're ok with changing the definition as it seems to be exported externally.

http://lists.askmonty.org/pipermail/commits/2016-October/009976.html

Comment by Sergei Golubchik [ 2016-10-26 ]

Apparently this one is already pushed

Comment by Vicențiu Ciorbaru [ 2016-10-26 ]

Fixed with:
39dceaae607e2c9f53146d5b23f8dee330643cb2

Generated at Thu Feb 08 07:46:24 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.