Details
-
Bug
-
Status: Closed (View Workflow)
-
Major
-
Resolution: Fixed
-
10.0.25
-
10.2.2-3
Description
In frames of fix for MDEV-9106 new variable was added for Audit Plugin, server_audit_loc_info. It is initialized with zeros and is supposed to be empty string in MTR tests, as far as I can see.
I wonder what values are expected there while working with MySQL 5.7 and with older MySQL/MariaDB versions. Please, document this clearly in the code and/or in a separate KB article. I see nothing about it at https://mariadb.com/kb/en/mariadb/server_audit-system-variables/, while it seems to have non-empty values at times.
Attachments
Issue Links
- relates to
-
-
- Closed
-
-
-
- Closed
-
Activity
| Field | Original Value | New Value |
|---|---|---|
| Status | Open [ 1 ] | Confirmed [ 10101 ] |
| Fix Version/s | 5.5 [ 15800 ] | |
| Fix Version/s | 10.0 [ 16000 ] | |
| Fix Version/s | 10.1 [ 16100 ] | |
| Fix Version/s | 10.2 [ 14601 ] |
| Sprint | 10.2.2-3 [ 83 ] |
| Rank | Ranked higher |
| Status | Confirmed [ 10101 ] | In Progress [ 3 ] |
| issue.field.resolutiondate | 2016-08-02 11:07:22.0 | 2016-08-02 11:07:22.026 |
| Fix Version/s | 5.5.51 [ 22015 ] | |
| Fix Version/s | 10.2 [ 14601 ] | |
| Fix Version/s | 5.5 [ 15800 ] | |
| Fix Version/s | 10.0 [ 16000 ] | |
| Fix Version/s | 10.1 [ 16100 ] | |
| Resolution | Fixed [ 1 ] | |
| Status | In Progress [ 3 ] | Closed [ 6 ] |
I see "Fix Version/s: 5.5.51", but I wonder how exactly this was fixed and do we have this fix in any released 10.0.x and/or 10.1.x version?
I still see the related variable defined as:
static MYSQL_THDVAR_STR(loc_info,
|
PLUGIN_VAR_READONLY | PLUGIN_VAR_MEMALLOC,
|
"Auxiliary info.", NULL, NULL,
|
locinfo_ini_value);
|
in recent 10.1:
[openxs@fc23 server]$ git log -1
|
commit 7d115e73b8a0a9f5bc8160a0bcf966ea2283a829
|
Author: Elena Stepanova <elenst@montyprogram.com>
|
Date: Sat Aug 27 19:50:42 2016 +0300
|
|
|
MDEV-10604 Create a list of unstable MTR tests to be disabled in distribution builds
|
|
|
List of unstable tests for 10.1
|
|
and in current 10.0:
[openxs@fc23 server]$ git checkout 10.0
|
Switched to branch '10.0'
|
Your branch is up-to-date with 'origin/10.0'.
|
[openxs@fc23 server]$ git pull
|
remote: Counting objects: 4, done.
|
remote: Compressing objects: 100% (4/4), done.
|
remote: Total 4 (delta 0), reused 0 (delta 0), pack-reused 0
|
Unpacking objects: 100% (4/4), done.
|
From https://github.com/MariaDB/server
|
39ec5ac..f81f985 10.0 -> origin/10.0
|
Updating 39ec5ac..f81f985
|
Fast-forward
|
sql/signal_handler.cc | 4 +++-
|
1 file changed, 3 insertions(+), 1 deletion(-)
|
[openxs@fc23 server]$ git log -1
|
commit f81f985f37ccdcf04aa9707fe994a0c87f67b1a8
|
Author: Sergei Golubchik <serg@mariadb.org>
|
Date: Mon Aug 29 11:53:33 2016 +0200
|
|
|
fix conpilation on OpenBSD
|
So, may I ask where is the fix in 10.0 and 10.1?
| Link |
This issue relates to |
It was (supposedly) documented. I'll remove it in the course of MDEV-10905
I see nothing about server_audit_loc_info at https://mariadb.com/kb/en/mariadb/server_audit-system-variables/ right now.
Even if it's going to be removed later, it would be great to have some words explaining in what version it had appeared, why, and what values had to be expected. Even "ignore it" is better than nothing.
| Link |
This issue relates to |
| Workflow | MariaDB v3 [ 76499 ] | MariaDB v4 [ 150669 ] |
if this is just an internal thread-local storage for connection_info, it should be declared with PLUGIN_VAR_MEMALLOC | PLUGIN_VAR_NOSYSVAR | PLUGIN_VAR_NOCMDOPT flags.