Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-10271

Stopped SQL slave thread doesn't print a message to error log like IO thread does

Details

    Description

      When stopped, either by STOP SLAVE, shutdown, or by error, the slave IO thread prints a message like 

      160615 10:27:51 [Note] Slave I/O thread exiting, read up to log 'binlog.026989', position 23827636; GTID position 0-197135068-997873951

      The SQL thread also has code for this, but it is not in the error handling part of the thread, so it is only reached when the main thread loop terminates without error ... which doesn't even seem to happen on

      {STOP SLAVE SQL_THREAD}

      The log message code should be moved down to the error handling part of the main SQL thread function, similar to how it is handled in the IO thread

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          hholzgra Hartmut Holzgraefe added a comment - - edited

          10.1 patch

          https://github.com/MariaDB/server/pull/188

          hholzgra Hartmut Holzgraefe added a comment - - edited 10.1 patch https://github.com/MariaDB/server/pull/188
          hholzgra Hartmut Holzgraefe added a comment -

          10.0 patch

          https://github.com/MariaDB/server/pull/191

          hholzgra Hartmut Holzgraefe added a comment - 10.0 patch https://github.com/MariaDB/server/pull/191
          elenst Elena Stepanova added a comment -

          For a note, I'm getting a message on STOP SLAVE [SQL_THREAD]

          Slave SQL thread exiting, replication stopped in log 'mysql-bin.000004' at position 511

          On server shutdown it's only as indirect as

          [Note] Error reading relay log event: slave SQL thread was killed

          elenst Elena Stepanova added a comment - For a note, I'm getting a message on STOP SLAVE [SQL_THREAD] Slave SQL thread exiting, replication stopped in log 'mysql-bin.000004' at position 511 On server shutdown it's only as indirect as [Note] Error reading relay log event: slave SQL thread was killed
          knielsen Kristian Nielsen added a comment -

          Pushed a somewhat reworked patch to 10.2.

          Mailing list thread: https://lists.launchpad.net/maria-developers/msg09754.html

          knielsen Kristian Nielsen added a comment - Pushed a somewhat reworked patch to 10.2. Mailing list thread: https://lists.launchpad.net/maria-developers/msg09754.html

          People

            knielsen Kristian Nielsen
            hholzgra Hartmut Holzgraefe
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.