[MDEV-10271] Stopped SQL slave thread doesn't print a message to error log like IO thread does Created: 2016-06-22  Updated: 2021-01-21  Resolved: 2016-07-25

Status: Closed
Project: MariaDB Server
Component/s: Replication
Affects Version/s: 10.0.25, 10.1.14
Fix Version/s: 10.0.29, 10.1.21, 10.2.2

Type: Bug Priority: Minor
Reporter: Hartmut Holzgraefe Assignee: Kristian Nielsen
Resolution: Fixed Votes: 0
Labels: patch


 Description   

When stopped, either by STOP SLAVE, shutdown, or by error, the slave IO thread prints a message like 

160615 10:27:51 [Note] Slave I/O thread exiting, read up to log 'binlog.026989', position 23827636; GTID position 0-197135068-997873951

The SQL thread also has code for this, but it is not in the error handling part of the thread, so it is only reached when the main thread loop terminates without error ... which doesn't even seem to happen on

{STOP SLAVE SQL_THREAD}

The log message code should be moved down to the error handling part of the main SQL thread function, similar to how it is handled in the IO thread

 Comments   
Comment by Hartmut Holzgraefe [ 2016-06-22 ]

10.1 patch

https://github.com/MariaDB/server/pull/188

Comment by Hartmut Holzgraefe [ 2016-06-22 ]

10.0 patch

https://github.com/MariaDB/server/pull/191

Comment by Elena Stepanova [ 2016-06-22 ]

For a note, I'm getting a message on STOP SLAVE [SQL_THREAD]

Slave SQL thread exiting, replication stopped in log 'mysql-bin.000004' at position 511

On server shutdown it's only as indirect as

[Note] Error reading relay log event: slave SQL thread was killed

Comment by Kristian Nielsen [ 2016-07-25 ]

Pushed a somewhat reworked patch to 10.2.

Mailing list thread: https://lists.launchpad.net/maria-developers/msg09754.html

Generated at Thu Feb 08 07:40:57 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.