/home/buildbot/amd64-debian-10-deb-autobake/build/storage/columnstore/columnstore/utils/funcexp/func_lcase.cpp: In member function ‘virtual std::__cxx11::string funcexp::Func_lcase::getStrVal(rowgroup::Row&, funcexp::FunctionParm&, bool&, execplan::CalpontSystemCatalog::ColType&)’:
/home/buildbot/amd64-debian-10-deb-autobake/build/storage/columnstore/columnstore/utils/funcexp/func_lcase.cpp:56:33: error: invalid use of member function ‘uint charset_info_st::casedn_multiply() const’ (did you forget the ‘()’ ?)
and include it from func_lcase.cpp and func_ucase.cpp.
Alexander Barkov
added a comment - - edited Another option (to avoid this cumbersome #if duplication) would be to move this code into a shared header file:
/* The API change happened in 10.10.4, 10.11.3, 11.0.2 */
#if ((MYSQL_VERSION_ID >= 101004 && MYSQL_VERSION_ID < 101099) || \
(MYSQL_VERSION_ID >= 101103 && MYSQL_VERSION_ID < 101199) || \
MYSQL_VERSION_ID >= 110002)
#define CS_CASEDN_MULTIPLY(cs) ((cs)->casedn_multiply())
#define CS_CASEUP_MULTIPLY(cs) ((cs)->caseup_multiply())
#else
#define CS_CASEDN_MULTIPLY(cs) ((cs)->casedn_multiply)
#define CS_CASEUP_MULTIPLY(cs) ((cs)->caseup_multiply)
#endif
and include it from func_lcase.cpp and func_ucase.cpp .
There's no point over complicating it. The git submodule ties the columnstore to the server version. So if you when back to 11.0.1, the git submodule would go to a previous columnstore version that didn't have this change.
Daniel Black
added a comment - There's no point over complicating it. The git submodule ties the columnstore to the server version. So if you when back to 11.0.1, the git submodule would go to a previous columnstore version that didn't have this change.
Daniel Black
added a comment - - edited Yes. and serg committed the submodule update in the server with commit 5f33351f48557fa09d5ebcf9864c33bfa296cd8e .
Thanks for the fix.
People
Roman
Daniel Black
Votes:
0Vote for this issue
Watchers:
5Start watching this issue
Dates
Created:
Updated:
Resolved:
Git Integration
Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.
{"report":{"fcp":917,"ttfb":257,"pageVisibility":"visible","entityId":119645,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":0.5,"journeyId":"9215a571-e3c7-4669-a2bf-3d20e2b51bf8","navigationType":0,"readyForUser":1026.7000000476837,"redirectCount":0,"resourceLoadedEnd":967.2999999523163,"resourceLoadedStart":265.59999990463257,"resourceTiming":[{"duration":75.40000009536743,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":265.59999990463257,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":265.59999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":341,"responseStart":0,"secureConnectionStart":0},{"duration":75.5,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":265.90000009536743,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":265.90000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":341.40000009536743,"responseStart":0,"secureConnectionStart":0},{"duration":166.70000004768372,"initiatorType":"script","name":"https://jira.mariadb.org/s/0917945aaa57108d00c5076fea35e069-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":266.2000000476837,"connectEnd":266.2000000476837,"connectStart":266.2000000476837,"domainLookupEnd":266.2000000476837,"domainLookupStart":266.2000000476837,"fetchStart":266.2000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":266.2000000476837,"responseEnd":432.90000009536743,"responseStart":432.90000009536743,"secureConnectionStart":266.2000000476837},{"duration":295.2999999523163,"initiatorType":"script","name":"https://jira.mariadb.org/s/2d8175ec2fa4c816e8023260bd8c1786-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":266.7000000476837,"connectEnd":266.7000000476837,"connectStart":266.7000000476837,"domainLookupEnd":266.7000000476837,"domainLookupStart":266.7000000476837,"fetchStart":266.7000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":266.7000000476837,"responseEnd":562,"responseStart":562,"secureConnectionStart":266.7000000476837},{"duration":167.90000009536743,"initiatorType":"script","name":"https://jira.mariadb.org/s/a9324d6758d385eb45c462685ad88f1d-CDN/lu2cib/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":267,"connectEnd":267,"connectStart":267,"domainLookupEnd":267,"domainLookupStart":267,"fetchStart":267,"redirectEnd":0,"redirectStart":0,"requestStart":267,"responseEnd":434.90000009536743,"responseStart":434.90000009536743,"secureConnectionStart":267},{"duration":298.60000014305115,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":267.09999990463257,"connectEnd":267.09999990463257,"connectStart":267.09999990463257,"domainLookupEnd":267.09999990463257,"domainLookupStart":267.09999990463257,"fetchStart":267.09999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":267.09999990463257,"responseEnd":565.7000000476837,"responseStart":565.7000000476837,"secureConnectionStart":267.09999990463257},{"duration":298.90000009536743,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":267.2999999523163,"connectEnd":267.2999999523163,"connectStart":267.2999999523163,"domainLookupEnd":267.2999999523163,"domainLookupStart":267.2999999523163,"fetchStart":267.2999999523163,"redirectEnd":0,"redirectStart":0,"requestStart":267.2999999523163,"responseEnd":566.2000000476837,"responseStart":566.2000000476837,"secureConnectionStart":267.2999999523163},{"duration":309.89999985694885,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2cib/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":267.40000009536743,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":267.40000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":577.2999999523163,"responseStart":0,"secureConnectionStart":0},{"duration":299.10000014305115,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":267.59999990463257,"connectEnd":267.59999990463257,"connectStart":267.59999990463257,"domainLookupEnd":267.59999990463257,"domainLookupStart":267.59999990463257,"fetchStart":267.59999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":267.59999990463257,"responseEnd":566.7000000476837,"responseStart":566.7000000476837,"secureConnectionStart":267.59999990463257},{"duration":309.7000000476837,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":267.7999999523163,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":267.7999999523163,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":577.5,"responseStart":0,"secureConnectionStart":0},{"duration":299.39999985694885,"initiatorType":"script","name":"https://jira.mariadb.org/s/5d5e8fe91fbc506585e83ea3b62ccc4b-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":267.90000009536743,"connectEnd":267.90000009536743,"connectStart":267.90000009536743,"domainLookupEnd":267.90000009536743,"domainLookupStart":267.90000009536743,"fetchStart":267.90000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":267.90000009536743,"responseEnd":567.2999999523163,"responseStart":567.2999999523163,"secureConnectionStart":267.90000009536743},{"duration":610.7999999523163,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":274.2000000476837,"connectEnd":274.2000000476837,"connectStart":274.2000000476837,"domainLookupEnd":274.2000000476837,"domainLookupStart":274.2000000476837,"fetchStart":274.2000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":274.2000000476837,"responseEnd":885,"responseStart":885,"secureConnectionStart":274.2000000476837},{"duration":609.6000001430511,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":277.7999999523163,"connectEnd":277.7999999523163,"connectStart":277.7999999523163,"domainLookupEnd":277.7999999523163,"domainLookupStart":277.7999999523163,"fetchStart":277.7999999523163,"redirectEnd":0,"redirectStart":0,"requestStart":277.7999999523163,"responseEnd":887.4000000953674,"responseStart":887.4000000953674,"secureConnectionStart":277.7999999523163},{"duration":130.20000004768372,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":589.2000000476837,"connectEnd":589.2000000476837,"connectStart":589.2000000476837,"domainLookupEnd":589.2000000476837,"domainLookupStart":589.2000000476837,"fetchStart":589.2000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":589.2000000476837,"responseEnd":719.4000000953674,"responseStart":719.4000000953674,"secureConnectionStart":589.2000000476837},{"duration":109.70000004768372,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/e65b778d185daf5aee24936755b43da6/_/download/contextbatch/js/browser-metrics-plugin.contrib,-_super,-project.issue.navigator,-jira.view.issue,-atl.general/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":857.5999999046326,"connectEnd":857.5999999046326,"connectStart":857.5999999046326,"domainLookupEnd":857.5999999046326,"domainLookupStart":857.5999999046326,"fetchStart":857.5999999046326,"redirectEnd":0,"redirectStart":0,"requestStart":857.5999999046326,"responseEnd":967.2999999523163,"responseStart":967.2999999523163,"secureConnectionStart":857.5999999046326},{"duration":150.5,"initiatorType":"script","name":"https://www.google-analytics.com/analytics.js","startTime":910.9000000953674,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":910.9000000953674,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1061.4000000953674,"responseStart":0,"secureConnectionStart":0}],"fetchStart":0,"domainLookupStart":32,"domainLookupEnd":73,"connectStart":73,"connectEnd":93,"secureConnectionStart":82,"requestStart":93,"responseStart":257,"responseEnd":277,"domLoading":260,"domInteractive":1097,"domContentLoadedEventStart":1097,"domContentLoadedEventEnd":1142,"domComplete":1284,"loadEventStart":1284,"loadEventEnd":1285,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":1066.7999999523163},{"name":"bigPipe.sidebar-id.end","time":1067.5999999046326},{"name":"bigPipe.activity-panel-pipe-id.start","time":1067.7000000476837},{"name":"bigPipe.activity-panel-pipe-id.end","time":1070},{"name":"activityTabFullyLoaded","time":1159.5}],"measures":[],"correlationId":"3a5568204979cb","effectiveType":"4g","downlink":10,"rtt":0,"serverDuration":98,"dbReadsTimeInMs":11,"dbConnsTimeInMs":20,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}
TheLinuxJedi, danblack, something like this should probably work:
/* The API change happened in 10.10.4, 10.11.3, 11.0.2 */
#if ((MYSQL_VERSION_ID >= 101004 && MYSQL_VERSION_ID < 101099) || \
(MYSQL_VERSION_ID >= 101103 && MYSQL_VERSION_ID < 101199) || \
MYSQL_VERSION_ID >= 110002)
uint64_t bufLen = inLen * cs->casedn_multiply();
#else
uint64_t bufLen = inLen * cs->casedn_multiply;