Uploaded image for project: 'MariaDB ColumnStore'
  1. MariaDB ColumnStore
  2. MCOL-5428

The conversion from strings to values and vice versa should use NullString

    XMLWordPrintable

Details

    • Task
    • Status: Open (View Workflow)
    • Major
    • Resolution: Unresolved
    • None
    • Icebox
    • None
    • None

    Description

      There is an example from mcs_datatypes.h:

       // hasTSInt128 explicitly tells to print int128 out in cases
        // where precision can't detect decimal type properly, e.g.
        // DECIMAL(10)/DECIMAL(38)
        std::string toString(bool hasTSInt128 = false) const;
        utils::NullString toNullString(bool hasTSInt128 = false) const;
      

      Note that there are toString and toNullString but their essence is the same.

      Ideally, we should convert the NULL values too and having NullString as a result (or input) is the right way to do that.

      Attachments

        Activity

          People

            Unassigned Unassigned
            sergey.zefirov Sergey Zefirov
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.