Uploaded image for project: 'MariaDB ColumnStore'
  1. MariaDB ColumnStore
  2. MCOL-537

Some compiler warnings need fixing

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.2.4
    • Component/s: ?
    • Labels:
      None

      Description

      Some of the following are definitely bugs, we should look at fixing them all:

      /home/linuxjedi/Programming/Git/mariadb-columnstore-server/mariadb-columnstore-engine/utils/funcexp/func_div.cpp: In member function ‘virtual int64_t funcexp::Func_div::getIntVal(rowgroup::Row&, funcexp::FunctionParm&, bool&, execplan::CalpontSystemCatalog::ColType&)’:
      /home/linuxjedi/Programming/Git/mariadb-columnstore-server/mariadb-columnstore-engine/utils/funcexp/func_div.cpp:58:16: warning: converting to non-pointer type ‘long int’ from NULL [-Wconversion-null]
               return NULL;
                      ^~~~
       
      /home/linuxjedi/Programming/Git/mariadb-columnstore-server/mariadb-columnstore-engine/utils/funcexp/func_div.cpp: In member function ‘virtual uint64_t funcexp::Func_div::getUintVal(rowgroup::Row&, funcexp::FunctionParm&, bool&, execplan::CalpontSystemCatalog::ColType&)’:
      /home/linuxjedi/Programming/Git/mariadb-columnstore-server/mariadb-columnstore-engine/utils/funcexp/func_div.cpp:81:16: warning: converting to non-pointer type ‘uint64_t {aka long unsigned int}’ from NULL [-Wconversion-null]
               return NULL;
                      ^~~~
       
      /home/linuxjedi/Programming/Git/mariadb-columnstore-server/mariadb-columnstore-engine/utils/funcexp/func_lpad.cpp: In member function ‘virtual std::__cxx11::string funcexp::Func_lpad::getStrVal(rowgroup::Row&, funcexp::FunctionParm&, bool&, execplan::CalpontSystemCatalog::ColType&)’:
      /home/linuxjedi/Programming/Git/mariadb-columnstore-server/mariadb-columnstore-engine/utils/funcexp/func_lpad.cpp:133:14: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
        if(strwclen > len)
           ~~~~~~~~~^~~~~
      /home/linuxjedi/Programming/Git/mariadb-columnstore-server/mariadb-columnstore-engine/utils/funcexp/func_lpad.cpp:150:17: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
           if (strSize == len)
               ~~~~~~~~^~~~~~
      /home/linuxjedi/Programming/Git/mariadb-columnstore-server/mariadb-columnstore-engine/utils/funcexp/func_lpad.cpp:157:17: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
           if (strSize > len)
               ~~~~~~~~^~~~~
       
       In member function ‘virtual std::__cxx11::string funcexp::Func_rpad::getStrVal(rowgroup::Row&, funcexp::FunctionParm&, bool&, execplan::CalpontSystemCatalog::ColType&)’:
      /home/linuxjedi/Programming/Git/mariadb-columnstore-server/mariadb-columnstore-engine/utils/funcexp/func_rpad.cpp:133:14: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
        if(strwclen > len)
           ~~~~~~~~~^~~~~
      /home/linuxjedi/Programming/Git/mariadb-columnstore-server/mariadb-columnstore-engine/utils/funcexp/func_rpad.cpp:150:17: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
           if (strSize == len)
               ~~~~~~~~^~~~~~
      /home/linuxjedi/Programming/Git/mariadb-columnstore-server/mariadb-columnstore-engine/utils/funcexp/func_rpad.cpp:157:17: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
           if (strSize > len)
               ~~~~~~~~^~~~~
       
      /home/linuxjedi/Programming/Git/mariadb-columnstore-server/mariadb-columnstore-engine/oam/oamcpp/liboamcpp.cpp: In member function ‘void oam::Oam::sendStatusUpdate(messageqcpp::ByteStream, messageqcpp::ByteStream::byte)’:
      /home/linuxjedi/Programming/Git/mariadb-columnstore-server/mariadb-columnstore-engine/oam/oamcpp/liboamcpp.cpp:9321:28: warning: self-comparison always evaluates to true [-Wtautological-compare]
           if ( returnRequestType == returnRequestType ) {
                ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~
       
      /home/linuxjedi/Programming/Git/mariadb-columnstore-server/mariadb-columnstore-engine/primitives/blockcache/filebuffer.cpp: In copy constructor ‘dbbc::FileBuffer::FileBuffer(const dbbc::FileBuffer&)’:
      /home/linuxjedi/Programming/Git/mariadb-columnstore-server/mariadb-columnstore-engine/primitives/blockcache/filebuffer.cpp:41:2: warning: nonnull argument ‘this’ compared to NULL [-Wnonnull-compare]
        if (this==NULL || this==&rhs)
        ^~
       
      /home/linuxjedi/Programming/Git/mariadb-columnstore-server/mariadb-columnstore-engine/dbcon/mysql/is_columnstore_files.cpp: In function ‘bool get_file_sizes(int, const char*, off_t*, off_t*)’:
      /home/linuxjedi/Programming/Git/mariadb-columnstore-server/mariadb-columnstore-engine/dbcon/mysql/is_columnstore_files.cpp:70:16: warning: ‘msgQueueClient’ may be used uninitialized in this function [-Wmaybe-uninitialized]
               delete msgQueueClient;
                      ^~~~~~~~~~~~~~
       
      /home/linuxjedi/Programming/Git/mariadb-columnstore-server/mariadb-columnstore-engine/dbcon/mysql/ha_calpont_impl.cpp: In function ‘int ha_calpont_impl_rnd_init(TABLE*)’:
      /home/linuxjedi/Programming/Git/mariadb-columnstore-server/mariadb-columnstore-engine/dbcon/mysql/ha_calpont_impl.cpp:2432:24: warning: comparison of constant ‘0’ with boolean expression is always false [-Wbool-compare]
        if (bSystemQueryReady < 0)
            ~~~~~~~~~~~~~~~~~~^~~
       
      /home/linuxjedi/Programming/Git/mariadb-columnstore-server/mariadb-columnstore-engine/oamapps/postConfigure/postConfigure.cpp: In function ‘int main(int, char**)’:
      /home/linuxjedi/Programming/Git/mariadb-columnstore-server/mariadb-columnstore-engine/oamapps/postConfigure/postConfigure.cpp:2808:19: warning: comparison with string literal results in unspecified behavior [-Waddress]
           if ( pass1 == "exit")
                         ^~~~~~
      

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              pleblanc Patrick LeBlanc (Inactive)
              Reporter:
              LinuxJedi Andrew Hutchings (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Git Integration