Build verified: 1.5.3-1 (drone build #287)

Reproduced the issue in 1.5.2-1

MariaDB [mytest]> create table t1 (c1 int, c2 char(20)) engine=columnstore;
Query OK, 0 rows affected (0.175 sec)

MariaDB [mytest]> insert into t1 values (50, 'Hawaii');
Query OK, 1 row affected (0.285 sec)

MariaDB [mytest]> select * from t1;
------------+

------------+

------------+
1 row in set (0.100 sec)

MariaDB [mytest]> select c1, insert(c2,1,5,'aloha') from t1;
----------------------------+

----------------------------+

----------------------------+
1 row in set (0.020 sec)

Verified fix in 1.5.3-1

MariaDB [mytest]> create table t1 (c1 int, c2 char(20)) engine=columnstore;
Query OK, 0 rows affected (0.230 sec)

MariaDB [mytest]> insert into t1 values (50, 'Hawaii');
Query OK, 1 row affected (0.375 sec)

MariaDB [mytest]> select c1, insert(c2,1,5,'aloha') from t1;
----------------------------+

----------------------------+

----------------------------+
1 row in set (0.097 sec)

MariaDB [mytest]> select c1, insert(c2,1,3,'aloha') from t1;
----------------------------+

----------------------------+

----------------------------+
1 row in set (0.022 sec)

MariaDB [mytest]> select c1, insert(c2,2,3,'aloha') from t1;
----------------------------+

----------------------------+

----------------------------+
1 row in set (0.018 sec)

Restested in 1.5.3-1 (drone #280)

It is also fixed in build #280

David.Hall Is there a test case that dleeyh can use for testing, that demonstrates the fix applied by the PR for this issue?

Build verified: 1.5.4-1 (Drone #496)

Additional tests:

MariaDB [mytest]> select c1, insert(c2,-1,3,'aloha') from t1;
-----------------------------+

-----------------------------+

-----------------------------+
1 row in set (0.050 sec)

MariaDB [mytest]> select c1, insert(c2,0,3,'aloha') from t1;
----------------------------+

----------------------------+

----------------------------+
1 row in set (0.019 sec)

MariaDB [mytest]> select c1, insert(c2,6,3,'aloha') from t1;
----------------------------+

----------------------------+

----------------------------+
1 row in set (0.021 sec)

MariaDB [mytest]> select c1, insert(c2,7,3,'aloha') from t1;
----------------------------+

----------------------------+

----------------------------+
1 row in set (0.017 sec)

For 1.5.4, test for the last char in the field and last +1.

select insert(c2,6,5,'aloha') from t1;
------------------------

------------------------

------------------------
1 row in set (0.028 sec)

select insert(c2,7,5,'aloha') from t1;
------------------------

------------------------

------------------------