Uploaded image for project: 'MariaDB ColumnStore'
  1. MariaDB ColumnStore
  2. MCOL-3360

Make the CS-side and SM-side safe vs connection failures

Details

    • Task
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Done
    • None
    • 1.4.0
    • ?
    • None

    Description

      When starting/stopping SM (but not CS), I've noticed that the CS side stops instead of reconnecting. We need to make sure it keeps trying to reconnect after a connection failure, and likewise that SM can handle connection failures as well. We'll have to also spell out exactly what should happen when each side gets a connection error at each point of processing. Common sense decides what should happen, just need to codify it.

      Attachments

        Activity

          Made the CS side reconnect for up to 10s when it notices the connection went down. It's now possible for CS to resume as if nothing happened if SM goes away. I suspect there's more to do for this ticket.

          pleblanc Patrick LeBlanc (Inactive) added a comment - Made the CS side reconnect for up to 10s when it notices the connection went down. It's now possible for CS to resume as if nothing happened if SM goes away. I suspect there's more to do for this ticket.

          Noticed a potentially significant optimization opportunity. Writetask (and appendtask I assume) are breaking the data to write into max 1MB chunks before calling IOC::write/append(). That made sense when IOC was a passthru for syscalls (M1), but doesn't make sense now.

          Going to make a ticket for that and investigate.

          pleblanc Patrick LeBlanc (Inactive) added a comment - Noticed a potentially significant optimization opportunity. Writetask (and appendtask I assume) are breaking the data to write into max 1MB chunks before calling IOC::write/append(). That made sense when IOC was a passthru for syscalls (M1), but doesn't make sense now. Going to make a ticket for that and investigate.

          Found an issue when writing unit_tests that SM would "read" more data from the buffer than was actually sent over the socket. adding more tests and fixing.

          ben.thompson Ben Thompson (Inactive) added a comment - Found an issue when writing unit_tests that SM would "read" more data from the buffer than was actually sent over the socket. adding more tests and fixing.

          People

            ben.thompson Ben Thompson (Inactive)
            pleblanc Patrick LeBlanc (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.