Uploaded image for project: 'MariaDB ColumnStore'
  1. MariaDB ColumnStore
  2. MCOL-2018

Dictionary null comparison check can crash

    XMLWordPrintable

Details

    • Bug
    • Status: Closed (View Workflow)
    • Blocker
    • Resolution: Fixed
    • None
    • 1.1.7, 1.2.3
    • None
    • None
    • 2018-21, 2019-01

    Description

      StringStore::isNullValue does the following check:

      return (*((uint64_t*) &mc->data[offset] + 4) == *((uint64_t*) joblist::CPNULLSTRMARK.c_str()));
      

      This jumps by 4x 8 bytes instead of 4 bytes. It should instead be:

      return (*((uint64_t*) &mc->data[offset + 4]) == *((uint64_t*) joblist::CPNULLSTRMARK.c_str()));
      

      Attachments

        Activity

          People

            dleeyh Daniel Lee (Inactive)
            LinuxJedi Andrew Hutchings (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.