Uploaded image for project: 'MariaDB ColumnStore'
  1. MariaDB ColumnStore
  2. MCOL-1637

MCOL-1052 causes regression

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.2
    • Fix Version/s: 1.2.3
    • Component/s: ExeMgr
    • Labels:
      None
    • Sprint:
      2018-16, 2018-17, 2018-18, 2018-19, 2018-20, 2018-21, 2019-01, 2019-02

      Description

      Changes for MCOL-1052

      in joblistfactory.cpp:1625

      void makeVtableModeSteps(CalpontSelectExecutionPlan* csep, JobInfo& jobInfo,
      JobStepVector& querySteps, JobStepVector& projectSteps, DeliveredTableMap& deliverySteps)
      {
      // @bug4848, enhance and unify limit handling.
      // if (csep->limitNum() != (uint64_t) - 1) // change: commented out
      {

      and in jlf_subquery.cpp:754

      void addOrderByAndLimit(CalpontSelectExecutionPlan* csep, JobInfo& jobInfo)
      {
      // make sure there is a LIMIT
      // if (csep->orderByCols().size() > 0 && csep->limitNum() == (uint64_t) -1) // Change: commented out
      // return;

      This causes a regression in working_tpch1/windowFunctions/q0044.sql:

      SELECT four, ten/4 as two,
      sum(ten/4) over (partition by four order by ten/4 range between unbounded preceding and current row) x,
      last_value(ten/4) over (partition by four order by ten/4 range between unbounded preceding and current row) y
      FROM (select distinct ten, four from tenk1 order by 1,2) ss order by 1,2,3;

      It appears that a limit(1) is inserted by this change into this query.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              dleeyh Daniel Lee
              Reporter:
              David.Hall David Hall
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.