Details
-
Bug
-
Status: Closed (View Workflow)
-
Minor
-
Resolution: Fixed
-
None
-
None
-
None
-
2018-14, 2018-15
Description
This won't affect us now, but will affect us in future:
/home/fedora/Git/mariadb-columnstore-server/mariadb-columnstore-engine/utils/joiner/../common/simpleallocator.h: In member function ‘utils::SimplePool* utils::SimpleAllocator<T>::getPool()’:
|
/home/fedora/Git/mariadb-columnstore-server/mariadb-columnstore-engine/utils/joiner/../common/simpleallocator.h:122:33: error: cannot convert ‘boost::shared_ptr<utils::SimplePool>’ to ‘utils::SimplePool*’ in return
|
SimplePool* getPool() { return fPool; }
|
We need to check whether or not this should return the shared_ptr instead. If not then use .get() on the end of fPool.
There are also quite a few warnings that could help with optimization in that release.