Uploaded image for project: 'MariaDB ColumnStore'
  1. MariaDB ColumnStore
  2. MCOL-1545

Compiler error in GCC 8.1

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.1.6
    • Component/s: None
    • Labels:
      None
    • Sprint:
      2018-14, 2018-15

      Description

      This won't affect us now, but will affect us in future:

      /home/fedora/Git/mariadb-columnstore-server/mariadb-columnstore-engine/utils/joiner/../common/simpleallocator.h: In member function ‘utils::SimplePool* utils::SimpleAllocator<T>::getPool()’:
      /home/fedora/Git/mariadb-columnstore-server/mariadb-columnstore-engine/utils/joiner/../common/simpleallocator.h:122:33: error: cannot convert ‘boost::shared_ptr<utils::SimplePool>’ to ‘utils::SimplePool*’ in return
        SimplePool* getPool() { return fPool; }
      

      We need to check whether or not this should return the shared_ptr instead. If not then use .get() on the end of fPool.

      There are also quite a few warnings that could help with optimization in that release.

        Attachments

          Activity

            People

            Assignee:
            dleeyh Daniel Lee
            Reporter:
            LinuxJedi Andrew Hutchings (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.