[MCOL-1505] ExeMgr can crash in cleanTmpDir() - Jira

Details

Type: Bug
Status: Closed (View Workflow)
Priority: Major
Resolution: Fixed
Affects Version/s: None
Fix Version/s: 1.1.7
Component/s: ExeMgr
Labels:
None

Sprint:
2018-17, 2018-18, 2018-19, 2018-20, 2018-21

Description

remove_all() can thrown an exception (I'm guessing when a path doesn't exist?) which is not caught

Attachments

Activity

Ascending order - Click to sort in descending order

Andrew Hutchings (Inactive) added a comment - 2018-09-07 10:52 - edited

Patched in the same patch as ~~MCOL-1694~~.

Please do not merge until 1.1.6 is released.

For QA: As ~~MCOL-1694~~, this just adds better error handling. You might be able to add some kind of non-removable file in the disk join temp dir. But I suspect best just checking for regressions.

Andrew Hutchings (Inactive) added a comment - 2018-09-07 10:52 - edited Patched in the same patch as MCOL-1694 . Please do not merge until 1.1.6 is released. For QA: As MCOL-1694 , this just adds better error handling. You might be able to add some kind of non-removable file in the disk join temp dir. But I suspect best just checking for regressions.

Daniel Lee (Inactive) added a comment - 2019-01-02 21:15

Build verified: 1.1.7-1

Git Commits
server=8220579
engine=88da1b6
Regression passed. Currently there are two regression cases failed, but they are not related to this.

Daniel Lee (Inactive) added a comment - 2019-01-02 21:15 Build verified: 1.1.7-1 Git Commits server=8220579 engine=88da1b6 Regression passed. Currently there are two regression cases failed, but they are not related to this.

People

Assignee:: Daniel Lee (Inactive)

Reporter:: Andrew Hutchings (Inactive)

Votes:: 1 Vote for this issue

Watchers:: 3 Start watching this issue

Dates

Created:: 2018-06-26 07:41

Updated:: 2019-01-02 21:15

Resolved:: 2019-01-02 21:15

Git Integration

Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.

MariaDB ColumnStore