Uploaded image for project: 'MariaDB ColumnStore'
  1. MariaDB ColumnStore
  2. MCOL-1001

WES client code will not work if a middle PM is removed

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Open (View Workflow)
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 1.1.0
    • Fix Version/s: Icebox
    • Component/s: writeengine
    • Labels:
      None

      Description

      In debugging for another BUG, ran across this code. It will be a problem if as an example PM2 is removed from the configuration on a PM1 - PM3 system.

      Code just gets the number of configured PMs, then tried to communicate to them in a loop that starts at 1 and goes to number-of-pms.

      void WEClients::Setup()
      {
      makeBusy(true);
      joblist::ResourceManager *rm = joblist::ResourceManager::instance();
      oam::Oam oam;
      string ipAddress;
      ModuleTypeConfig moduletypeconfig;
      try

      { oam.getSystemConfig("pm", moduletypeconfig); }

      catch (...)

      { writeToLog(__FILE__, __LINE__, "oam.getSystemConfig error, unknown exception", LOG_TYPE_ERROR); throw runtime_error("Setup failed"); }

      uint32_t pmCountConfig = moduletypeconfig.ModuleCount;
      pmCount = 0;
      int moduleID = 1;

      char buff[32];
      ByteStream bs, bsRead;
      if (fPrgmID == DDLPROC)

      { bs << (ByteStream::byte) WE_SVR_DDL_KEEPALIVE; bs << (ByteStream::octbyte) moduleID; }

      else if (fPrgmID == DMLPROC)

      { bs << (ByteStream::byte) WE_SVR_DML_KEEPALIVE; bs << (ByteStream::octbyte) moduleID; }

      else if (fPrgmID == SPLITTER)

      { bs << (ByteStream::byte) WE_CLT_SRV_KEEPALIVE; }

      else if (fPrgmID == BATCHINSERTPROC)

      { bs << (ByteStream::byte) WE_SVR_BATCH_KEEPALIVE; bs << (ByteStream::octbyte) moduleID; }

      for (unsigned i = 0; i < pmCountConfig; i++) {

        Attachments

          Activity

            People

            Assignee:
            Unassigned Unassigned
            Reporter:
            hill David Hill (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:

                Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.