Details

    • Bug
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • 3.0.3
    • 3.0.4
    • Other
    • None

    Description

      I was trying to use the latest driver version 3.0.3 in an OSGi environment but found that it is no more an OSGi bundle (missing OSGi metadata).

      Attachments

        Activity

          rakeshk15 Rakesh Kumar added a comment -
          rakeshk15 Rakesh Kumar added a comment - provided a fix in this PR - https://github.com/mariadb-corporation/mariadb-connector-j/pull/177 Please review.
          diego dupin Diego Dupin added a comment -

          commited in 3.0.4-SNAPSHOT, avoiding to have another dependency for no reason.
          could you confirm correction ?
          (available using :

          <repositories>
              <repository>
                  <id>sonatype-nexus-snapshots</id>
                  <name>Sonatype Nexus Snapshots</name>
                  <url>https://oss.sonatype.org/content/repositories/snapshots</url>
              </repository>
          </repositories>
           
          <dependencies>
              <dependency>
                  <groupId>org.mariadb.jdbc</groupId>
                  <artifactId>mariadb-java-client</artifactId>
                  <version>3.0.4-SNAPSHOT</version>
              </dependency>
          </dependencies>
          
          

          )

          diego dupin Diego Dupin added a comment - commited in 3.0.4-SNAPSHOT, avoiding to have another dependency for no reason. could you confirm correction ? (available using : <repositories> <repository> <id>sonatype-nexus-snapshots</id> <name>Sonatype Nexus Snapshots</name> <url>https: //oss.sonatype.org/content/repositories/snapshots</url> </repository> </repositories>   <dependencies> <dependency> <groupId>org.mariadb.jdbc</groupId> <artifactId>mariadb-java-client</artifactId> <version> 3.0 . 4 -SNAPSHOT</version> </dependency> </dependencies> )
          rakeshk15 Rakesh Kumar added a comment -

          Hi Diego,

          Sorry, I could not test it earlier.

          I just tried to use 3.0.4-SNAPSHOT but it is still not an OSGi bundle.

          Here is the screenshot of MANIFEST.MF file from decompiled jar

          Regarding using the bnd-maven-plugin, its just a maven build plugin and not needed at runtime so no extra baggage at runtime, its a special tool to generate OSGi metadata correctly and most accurately.

          I think it is better to use the bnd-maven-plugin rather than writing the OSGi metadata by hand, rest is your decision.

          Thanks,
          Rakesh

          rakeshk15 Rakesh Kumar added a comment - Hi Diego, Sorry, I could not test it earlier. I just tried to use 3.0.4-SNAPSHOT but it is still not an OSGi bundle. Here is the screenshot of MANIFEST.MF file from decompiled jar Regarding using the bnd-maven-plugin, its just a maven build plugin and not needed at runtime so no extra baggage at runtime, its a special tool to generate OSGi metadata correctly and most accurately. I think it is better to use the bnd-maven-plugin rather than writing the OSGi metadata by hand, rest is your decision. Thanks, Rakesh
          diego dupin Diego Dupin added a comment -

          The 3.0.4-SNAPSHOT wasn't updated to latest version, the OSGI correction wasn't there.
          Finally after testing the result in MANIFEST.MF of the plugin, i agree that it is better.
          PR is merged.

          diego dupin Diego Dupin added a comment - The 3.0.4-SNAPSHOT wasn't updated to latest version, the OSGI correction wasn't there. Finally after testing the result in MANIFEST.MF of the plugin, i agree that it is better. PR is merged.

          Fixed! Thank you!

          brentl99 Brent Levinson added a comment - Fixed! Thank you!

          People

            diego dupin Diego Dupin
            rakeshk15 Rakesh Kumar
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.