[CONJ-525] Batched Queries failing to be validated by Hibernate - Jira

Details

Type: Bug
Status: Closed (View Workflow)
Priority: Major
Resolution: Fixed
Affects Version/s: 2.1.0, 2.1.1
Fix Version/s: 1.6.5, 2.1.2
Component/s: batch
Labels:
None

Description

PreparedStatement st = connection.prepareStatement("delete from temp_t where col1 = ?");
st.setInt(1, 0);
st.addBatch();
st.setInt(1, 1);
st.addBatch();
int[] ints = st.executeBatch();

When I run Batched Queries in 1.6.4 or 2.0.3 I got two results, exactly what I expect;
ints =

{1, 1}

When the same code ran in 2.1.0 or 2.1.1
I got unexpected first value -3, so that my array looks like this:
ints = {-3, 1, 1}

In case if newer driver used with Hibernate, we face fail, since it traverse through whole array and throw Exception on negative values - it's in this class

org.hibernate.engine.jdbc.batch.internal.BatchingBatch.checkRowCounts()

Attachments

Activity

Ascending order - Click to sort in descending order

Oleksandr Ierenkov created issue - 2017-09-12 14:30

Oleksandr Ierenkov added a comment - 2017-09-12 14:37

I believe "return;" after this line
https://github.com/MariaDB/mariadb-connector-j/blob/master/src/main/java/org/mariadb/jdbc/internal/com/read/dao/Results.java#L222

Could solve the issue, but is it safe - I don't know

Oleksandr Ierenkov added a comment - 2017-09-12 14:37 I believe "return;" after this line https://github.com/MariaDB/mariadb-connector-j/blob/master/src/main/java/org/mariadb/jdbc/internal/com/read/dao/Results.java#L222 Could solve the issue, but is it safe - I don't know

Oleksandr Ierenkov made changes - 2017-09-12 14:38

Field	Original Value	New Value
Description	PreparedStatement st = connection.prepareStatement("delete from temp_t where col1 = ?"); st.setInt(1, 0); st.addBatch(); st.setInt(1, 1); st.addBatch(); int[] ints = st.executeBatch(); When I run Batched Queries in 1.6.4 or 2.0.3 I got two results, exactly what I expect; ints = {1, 1} When the same code ran in 2.1.0 or 2.1.1 I got unexpected first value -3, so that my array looks like this: ints = {-3, 1, 1} In case if newer driver used with Hibernate, we face fail, since it traverse trough whole array and throw Exception on negative values - it's in this class org.hibernate.engine.jdbc.batch.internal.BatchingBatch.checkRowCounts()	PreparedStatement st = connection.prepareStatement("delete from temp_t where col1 = ?"); st.setInt(1, 0); st.addBatch(); st.setInt(1, 1); st.addBatch(); int[] ints = st.executeBatch(); When I run Batched Queries in 1.6.4 or 2.0.3 I got two results, exactly what I expect; ints = {1, 1} When the same code ran in 2.1.0 or 2.1.1 I got unexpected first value -3, so that my array looks like this: ints = {-3, 1, 1} In case if newer driver used with Hibernate, we face fail, since it traverse through whole array and throw Exception on negative values - it's in this class org.hibernate.engine.jdbc.batch.internal.BatchingBatch.checkRowCounts()

Diego Dupin made changes - 2017-09-20 08:39

Fix Version/s		1.6.5 [ 22628 ]
Fix Version/s		2.1.2 [ 22629 ]

Diego Dupin added a comment - 2017-09-20 12:47 - edited

you PR will correct that (https://github.com/MariaDB/mariadb-connector-j/pull/112).

At the same time, I'll create an issue server side, there is no reason for delete to be not possible.
The BULK protocol must normally throw exception only for SELECT queries in batch ( like JDBC require), not DELETE commands.

Diego Dupin added a comment - 2017-09-20 12:47 - edited you PR will correct that ( https://github.com/MariaDB/mariadb-connector-j/pull/112 ). At the same time, I'll create an issue server side, there is no reason for delete to be not possible. The BULK protocol must normally throw exception only for SELECT queries in batch ( like JDBC require), not DELETE commands.

Diego Dupin added a comment - 2017-09-21 13:01

Merge done, available through SNAPSHOT's :

<repositories>

    <repository>

        <id>sonatype-nexus-snapshots</id>

        <name>Sonatype Nexus Snapshots</name>

        <url>https://oss.sonatype.org/content/repositories/snapshots</url>

    </repository>

</repositories>

<dependencies>

    <dependency>

        <groupId>org.mariadb.jdbc</groupId>

        <artifactId>mariadb-java-client</artifactId>

        <version>2.1.2-SNAPSHOT</version>

    </dependency>

</dependencies>

release in a few days.

Diego Dupin added a comment - 2017-09-21 13:01 Merge done, available through SNAPSHOT's : <repositories> <repository> <id>sonatype-nexus-snapshots</id> <name>Sonatype Nexus Snapshots</name> <url>https: //oss.sonatype.org/content/repositories/snapshots</url> </repository> </repositories> <dependencies> <dependency> <groupId>org.mariadb.jdbc</groupId> <artifactId>mariadb-java-client</artifactId> <version> 2.1 . 2 -SNAPSHOT</version> </dependency> </dependencies> release in a few days.

Diego Dupin made changes - 2017-09-21 13:01

Component/s		batch [ 14105 ]
Resolution		Fixed [ 1 ]
Status	Open [ 1 ]	Closed [ 6 ]

Sergei Golubchik made changes - 2021-12-06 21:27

Workflow

MariaDB v3 [ 82543 ]

MariaDB v4 [ 135017 ]

People

Assignee:: Diego Dupin

Reporter:: Oleksandr Ierenkov

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Dates

Created:: 2017-09-12 14:30

Updated:: 2017-09-21 13:01

Resolved:: 2017-09-21 13:01

Git Integration

Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.

MariaDB Connector/J