Type:
Task
Priority:
Minor
Resolution:
Fixed
Affects Version/s:
1.2.0
(report from github https://github.com/MariaDB/mariadb-connector-j/issues/35 from ocafebabe)
Some database connection pool like the one I use (Oracle UCP) will set default values for the serverName and port properties (in this case: null and 0) in org.mariadb.jdbc.MySQLDataSource.
So even though the URL I set is valid, the connection will fail because the two properties were overridden and the generated URL by the datasource implementation is then invalid: jdbc:mysql://address=(host=null)(port=0)(type=master)
PoolDataSource pds = oracle.ucp.jdbc.PoolDataSourceFactory.getPoolDataSource();
pds.setConnectionFactoryClassName( "org.mariadb.jdbc.MySQLDataSource" );
pds.setURL( "jdbc:mysql://localhost:3306/testdb" );
pds.setUser( "test" );
pds.setPassword( "test" );
Connection c = pds.getConnection();
java.sql.SQLException: Exception occurred while getting connection: oracle.ucp.UniversalConnectionPoolException: Cannot get Connection from Datasource: java.lang.IllegalArgumentException: hostname can't be null
Would it be possible to add two validation checks in org.mariadb.jdbc.MySQLDataSource as follow:
public void setServerName(String serverName) {
if (serverName != null && !serverName.isEmpty()) {
jdbcUrl.getHostAddresses().get( 0 ).host = serverName;
}
}
public void setPort( int p) {
if (p > 0 ) {
jdbcUrl.getHostAddresses().get( 0 ).port = p;
}
}
These validation checks are pretty generic and I don't think it would be harmful under other circumstances!
Transition
Time In Source Status
Execution Times
Open
In Progress
10m 6s
1
In Progress
Closed
1d 21h 49m
1
{"report":{"fcp":1532.3999999761581,"ttfb":514.2999999523163,"pageVisibility":"visible","entityId":52903,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":0.5,"journeyId":"3511b40a-4752-4c1e-a766-938696e1064a","navigationType":0,"readyForUser":1609.7999999523163,"redirectCount":0,"resourceLoadedEnd":1893.3999999761581,"resourceLoadedStart":520.8999999761581,"resourceTiming":[{"duration":469.60000002384186,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":520.8999999761581,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":520.8999999761581,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":990.5,"responseStart":0,"secureConnectionStart":0},{"duration":469.60000002384186,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":521.1999999284744,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":521.1999999284744,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":990.7999999523163,"responseStart":0,"secureConnectionStart":0},{"duration":497.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/fbf975c0cce4b1abf04784eeae9ba1f4-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":521.2999999523163,"connectEnd":521.2999999523163,"connectStart":521.2999999523163,"domainLookupEnd":521.2999999523163,"domainLookupStart":521.2999999523163,"fetchStart":521.2999999523163,"redirectEnd":0,"redirectStart":0,"requestStart":521.2999999523163,"responseEnd":1018.7999999523163,"responseStart":1018.7999999523163,"secureConnectionStart":521.2999999523163},{"duration":637.2999999523163,"initiatorType":"script","name":"https://jira.mariadb.org/s/099b33461394b8015fc36c0a4b96e19f-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":521.5,"connectEnd":521.5,"connectStart":521.5,"domainLookupEnd":521.5,"domainLookupStart":521.5,"fetchStart":521.5,"redirectEnd":0,"redirectStart":0,"requestStart":521.5,"responseEnd":1158.7999999523163,"responseStart":1158.7999999523163,"secureConnectionStart":521.5},{"duration":642,"initiatorType":"script","name":"https://jira.mariadb.org/s/94c15bff32baef80f4096a08aceae8bc-CDN/lu2bu7/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":521.6999999284744,"connectEnd":521.6999999284744,"connectStart":521.6999999284744,"domainLookupEnd":521.6999999284744,"domainLookupStart":521.6999999284744,"fetchStart":521.6999999284744,"redirectEnd":0,"redirectStart":0,"requestStart":521.6999999284744,"responseEnd":1163.6999999284744,"responseStart":1163.6999999284744,"secureConnectionStart":521.6999999284744},{"duration":655.3999999761581,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":521.8999999761581,"connectEnd":521.8999999761581,"connectStart":521.8999999761581,"domainLookupEnd":521.8999999761581,"domainLookupStart":521.8999999761581,"fetchStart":521.8999999761581,"redirectEnd":0,"redirectStart":0,"requestStart":521.8999999761581,"responseEnd":1177.2999999523163,"responseStart":1177.2999999523163,"secureConnectionStart":521.8999999761581},{"duration":656.3000000715256,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":522.0999999046326,"connectEnd":522.0999999046326,"connectStart":522.0999999046326,"domainLookupEnd":522.0999999046326,"domainLookupStart":522.0999999046326,"fetchStart":522.0999999046326,"redirectEnd":0,"redirectStart":0,"requestStart":522.0999999046326,"responseEnd":1178.3999999761581,"responseStart":1178.3999999761581,"secureConnectionStart":522.0999999046326},{"duration":665.8999999761581,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2bu7/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":522.2999999523163,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":522.2999999523163,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1188.1999999284744,"responseStart":0,"secureConnectionStart":0},{"duration":660.7999999523163,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":522.5,"connectEnd":522.5,"connectStart":522.5,"domainLookupEnd":522.5,"domainLookupStart":522.5,"fetchStart":522.5,"redirectEnd":0,"redirectStart":0,"requestStart":522.5,"responseEnd":1183.2999999523163,"responseStart":1183.2999999523163,"secureConnectionStart":522.5},{"duration":665.8000000715256,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":522.5999999046326,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":522.5999999046326,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1188.3999999761581,"responseStart":0,"secureConnectionStart":0},{"duration":663.8999999761581,"initiatorType":"script","name":"https://jira.mariadb.org/s/3339d87fa2538a859872f2df449bf8d0-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":522.7999999523163,"connectEnd":522.7999999523163,"connectStart":522.7999999523163,"domainLookupEnd":522.7999999523163,"domainLookupStart":522.7999999523163,"fetchStart":522.7999999523163,"redirectEnd":0,"redirectStart":0,"requestStart":522.7999999523163,"responseEnd":1186.6999999284744,"responseStart":1186.6999999284744,"secureConnectionStart":522.7999999523163},{"duration":1256.3999999761581,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":523.5,"connectEnd":523.5,"connectStart":523.5,"domainLookupEnd":523.5,"domainLookupStart":523.5,"fetchStart":523.5,"redirectEnd":0,"redirectStart":0,"requestStart":523.5,"responseEnd":1779.8999999761581,"responseStart":1779.8999999761581,"secureConnectionStart":523.5},{"duration":1369.7000000476837,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":523.6999999284744,"connectEnd":523.6999999284744,"connectStart":523.6999999284744,"domainLookupEnd":523.6999999284744,"domainLookupStart":523.6999999284744,"fetchStart":523.6999999284744,"redirectEnd":0,"redirectStart":0,"requestStart":523.6999999284744,"responseEnd":1893.3999999761581,"responseStart":1893.3999999761581,"secureConnectionStart":523.6999999284744},{"duration":553.6999999284744,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":1200.3999999761581,"connectEnd":1200.3999999761581,"connectStart":1200.3999999761581,"domainLookupEnd":1200.3999999761581,"domainLookupStart":1200.3999999761581,"fetchStart":1200.3999999761581,"redirectEnd":0,"redirectStart":0,"requestStart":1200.3999999761581,"responseEnd":1754.0999999046326,"responseStart":1754.0999999046326,"secureConnectionStart":1200.3999999761581},{"duration":434.60000002384186,"initiatorType":"script","name":"https://www.google-analytics.com/analytics.js","startTime":1523.1999999284744,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":1523.1999999284744,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1957.7999999523163,"responseStart":0,"secureConnectionStart":0}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":344,"responseStart":514,"responseEnd":519,"domLoading":518,"domInteractive":1915,"domContentLoadedEventStart":1915,"domContentLoadedEventEnd":1958,"domComplete":2560,"loadEventStart":2560,"loadEventEnd":2561,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":1895.0999999046326},{"name":"bigPipe.sidebar-id.end","time":1896.0999999046326},{"name":"bigPipe.activity-panel-pipe-id.start","time":1896.3999999761581},{"name":"bigPipe.activity-panel-pipe-id.end","time":1897.2999999523163},{"name":"activityTabFullyLoaded","time":1969.8999999761581}],"measures":[],"correlationId":"ab22f249cc523d","effectiveType":"4g","downlink":10,"rtt":0,"serverDuration":109,"dbReadsTimeInMs":18,"dbConnsTimeInMs":27,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}