Uploaded image for project: 'MariaDB Connector/J'
  1. MariaDB Connector/J
  2. CONJ-178

Change Apache DBCP scope to test in pom

    XMLWordPrintable

Details

    • Bug
    • Status: Closed (View Workflow)
    • Minor
    • Resolution: Fixed
    • 1.2.0
    • 1.2.2
    • Other
    • None
    • Sprint connector/j 1.3.0

    Description

      from contributor "Sehrope Sarkuni":

      The first commit changes the scope of the DBCP dependency to "test" as it's only used in the tests. The second removes an out of date comment regarding adding the DBCP dependency to the pom to run the tests.

      This isn't a breaking change from a functionality perspective as the driver itself hasn't changed at all. It may break downstream apps that are relying on the transitive dependency for DBCP. That's wrong on their part though so I don't think it's a real issue. Anybody who runs into that will see the error at compile time and will need to update their pom to explicitly include DBCP themselves.

      Might want to add a line like that to the release notes for the next release of the driver.

      Attachments

        Activity

          People

            diego dupin Diego Dupin
            diego dupin Diego Dupin
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.