Uploaded image for project: 'MariaDB Connector/C++'
  1. MariaDB Connector/C++
  2. CONCPP-22

Change in the Public API field size related parameter/return value types from int32_t to uint32_t

    XMLWordPrintable

Details

    • Bug
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • None
    • 0.9.3
    • General
    • None

    Description

      Maximal size of the field in MariaDB is (max unsigned int) value. Thus, int32_t is not enough, and methods like
      virtual int32_t getMaxFieldSize()=0;
      virtual void setMaxFieldSize(int32_t max)=0;
      have to be changed to
      virtual uint32_t getMaxFieldSize()=0;
      virtual void setMaxFieldSize(uint32_t max)=0;

      This probably can be extended with some naturally unsigned methods, like set of database metadata methods returning version numbers.
      uint32_t getDatabaseMajorVersion();
      uint32_t getDatabaseMinorVersion();
      uint32_t getDatabasePatchVersion();
      uint32_t getJDBCMajorVersion();
      uint32_t getJDBCMinorVersion();
      uint32_t getCDBCMajorVersion();
      uint32_t getCDBCMinorVersion();

      Then it probably doesn't make sense to leave getMajorVersion() and getMinorVersion() methods in the Driver signed.

      Attachments

        Activity

          People

            Unassigned Unassigned
            Lawrin Lawrin Novitsky
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.