Uploaded image for project: 'MariaDB Connector/C++'
  1. MariaDB Connector/C++
  2. CONCPP-18

Minor issues found when enabling more warnings

    XMLWordPrintable

Details

    • Bug
    • Status: Closed (View Workflow)
    • Minor
    • Resolution: Fixed
    • None
    • 1.0.3, 1.1.3
    • General
    • None

    Description

      A list of things found when more warnings enabled (-DCMAKE_CXX_FLAGS="-Wall -Wunused -Wwrite-strings -Wextra -Wundef -Wpacked"):

      1. Some classes are initialised in the wrong order
      2. Many methods using 'const' qualifiers where it is meaningless (mostly Value.h)
      3. Many methods have unused parameters that haven't been declared as unused
      4. Visual Studio warning suppressions in-use for all platforms (mostly in Consts.h)
      5. VNONE not handled by switches in Value.cpp and Options.cpp
      6. Utils.cpp:925 has just '1;' as a statement
      7. DefaultOptions.cpp:930 and 969 needs parentheses
      8. encryptPassword in Utils.cpp is an unused function
      9. SelectResultSetCapi.cpp:788 first part of statement is always true
      10. SelectResultSetCapi:810 if statement always true
      11. DateParameter.cpp:35 bad initialisations (variables initialised with self)
      12. Various signed difference during compares
      13. BinRowProcotocolCapi.cpp lots of switch cases missing
      14. BinRowProcotocolCapi.cpp:622 fall through should be explicitly marked
      15. test_common.cpp:52 should have an ifdef, it is undefined in GCC
      16. test_common.cpp has a bunch of unused functions

      Attachments

        Activity

          People

            Unassigned Unassigned
            LinuxJedi Andrew Hutchings (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.