Type:
Bug
Priority:
Minor
Resolution:
Fixed
Affects Version/s:
None
A list of things found when more warnings enabled (-DCMAKE_CXX_FLAGS="-Wall -Wunused -Wwrite-strings -Wextra -Wundef -Wpacked"):
1. Some classes are initialised in the wrong order
2. Many methods using 'const' qualifiers where it is meaningless (mostly Value.h)
3. Many methods have unused parameters that haven't been declared as unused
4. Visual Studio warning suppressions in-use for all platforms (mostly in Consts.h)
5. VNONE not handled by switches in Value.cpp and Options.cpp
6. Utils.cpp:925 has just '1;' as a statement
7. DefaultOptions.cpp:930 and 969 needs parentheses
8. encryptPassword in Utils.cpp is an unused function
9. SelectResultSetCapi.cpp:788 first part of statement is always true
10. SelectResultSetCapi:810 if statement always true
11. DateParameter.cpp:35 bad initialisations (variables initialised with self)
12. Various signed difference during compares
13. BinRowProcotocolCapi.cpp lots of switch cases missing
14. BinRowProcotocolCapi.cpp:622 fall through should be explicitly marked
15. test_common.cpp:52 should have an ifdef, it is undefined in GCC
16. test_common.cpp has a bunch of unused functions
{"report":{"fcp":1084.5,"ttfb":318.2000000476837,"pageVisibility":"visible","entityId":88907,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":0.5,"journeyId":"51a74416-39cd-4203-b480-e1a01355f39c","navigationType":0,"readyForUser":1150.7999999523163,"redirectCount":0,"resourceLoadedEnd":1182.7999999523163,"resourceLoadedStart":327.2000000476837,"resourceTiming":[{"duration":157.09999990463257,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":327.2000000476837,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":327.2000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":484.2999999523163,"responseStart":0,"secureConnectionStart":0},{"duration":156.89999997615814,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":327.5,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":327.5,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":484.39999997615814,"responseStart":0,"secureConnectionStart":0},{"duration":307.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/fbf975c0cce4b1abf04784eeae9ba1f4-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":327.60000002384186,"connectEnd":327.60000002384186,"connectStart":327.60000002384186,"domainLookupEnd":327.60000002384186,"domainLookupStart":327.60000002384186,"fetchStart":327.60000002384186,"redirectEnd":0,"redirectStart":0,"requestStart":490.7999999523163,"responseEnd":635.1000000238419,"responseStart":509.2000000476837,"secureConnectionStart":327.60000002384186},{"duration":425.1999999284744,"initiatorType":"script","name":"https://jira.mariadb.org/s/099b33461394b8015fc36c0a4b96e19f-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":327.60000002384186,"connectEnd":327.60000002384186,"connectStart":327.60000002384186,"domainLookupEnd":327.60000002384186,"domainLookupStart":327.60000002384186,"fetchStart":327.60000002384186,"redirectEnd":0,"redirectStart":0,"requestStart":491.2000000476837,"responseEnd":752.7999999523163,"responseStart":511.60000002384186,"secureConnectionStart":327.60000002384186},{"duration":189,"initiatorType":"script","name":"https://jira.mariadb.org/s/94c15bff32baef80f4096a08aceae8bc-CDN/lu2bu7/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":327.7000000476837,"connectEnd":327.7000000476837,"connectStart":327.7000000476837,"domainLookupEnd":327.7000000476837,"domainLookupStart":327.7000000476837,"fetchStart":327.7000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":491.7000000476837,"responseEnd":516.7000000476837,"responseStart":514.5,"secureConnectionStart":327.7000000476837},{"duration":188.80000007152557,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":327.7999999523163,"connectEnd":327.7999999523163,"connectStart":327.7999999523163,"domainLookupEnd":327.7999999523163,"domainLookupStart":327.7999999523163,"fetchStart":327.7999999523163,"redirectEnd":0,"redirectStart":0,"requestStart":491.89999997615814,"responseEnd":516.6000000238419,"responseStart":513.8999999761581,"secureConnectionStart":327.7999999523163},{"duration":192.60000002384186,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":328,"connectEnd":328,"connectStart":328,"domainLookupEnd":328,"domainLookupStart":328,"fetchStart":328,"redirectEnd":0,"redirectStart":0,"requestStart":493.2999999523163,"responseEnd":520.6000000238419,"responseStart":518,"secureConnectionStart":328},{"duration":163.5,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2bu7/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":328.10000002384186,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":328.10000002384186,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":491.60000002384186,"responseStart":0,"secureConnectionStart":0},{"duration":192.19999992847443,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":328.2000000476837,"connectEnd":328.2000000476837,"connectStart":328.2000000476837,"domainLookupEnd":328.2000000476837,"domainLookupStart":328.2000000476837,"fetchStart":328.2000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":494.89999997615814,"responseEnd":520.3999999761581,"responseStart":517.6000000238419,"secureConnectionStart":328.2000000476837},{"duration":165.70000004768372,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":328.2999999523163,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":328.2999999523163,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":494,"responseStart":0,"secureConnectionStart":0},{"duration":194.70000004768372,"initiatorType":"script","name":"https://jira.mariadb.org/s/3339d87fa2538a859872f2df449bf8d0-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":328.39999997615814,"connectEnd":328.39999997615814,"connectStart":328.39999997615814,"domainLookupEnd":328.39999997615814,"domainLookupStart":328.39999997615814,"fetchStart":328.39999997615814,"redirectEnd":0,"redirectStart":0,"requestStart":497.60000002384186,"responseEnd":523.1000000238419,"responseStart":521.6000000238419,"secureConnectionStart":328.39999997615814},{"duration":850.6000000238419,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":331.39999997615814,"connectEnd":331.39999997615814,"connectStart":331.39999997615814,"domainLookupEnd":331.39999997615814,"domainLookupStart":331.39999997615814,"fetchStart":331.39999997615814,"redirectEnd":0,"redirectStart":0,"requestStart":1163.6000000238419,"responseEnd":1182,"responseStart":1179.3999999761581,"secureConnectionStart":331.39999997615814},{"duration":851.2999999523163,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":331.5,"connectEnd":331.5,"connectStart":331.5,"domainLookupEnd":331.5,"domainLookupStart":331.5,"fetchStart":331.5,"redirectEnd":0,"redirectStart":0,"requestStart":1164.1000000238419,"responseEnd":1182.7999999523163,"responseStart":1180.8999999761581,"secureConnectionStart":331.5},{"duration":204.90000009536743,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":769.7999999523163,"connectEnd":769.7999999523163,"connectStart":769.7999999523163,"domainLookupEnd":769.7999999523163,"domainLookupStart":769.7999999523163,"fetchStart":769.7999999523163,"redirectEnd":0,"redirectStart":0,"requestStart":939.5,"responseEnd":974.7000000476837,"responseStart":974,"secureConnectionStart":769.7999999523163}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":164,"responseStart":318,"responseEnd":329,"domLoading":322,"domInteractive":1206,"domContentLoadedEventStart":1206,"domContentLoadedEventEnd":1251,"domComplete":1814,"loadEventStart":1814,"loadEventEnd":1815,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":1188.5},{"name":"bigPipe.sidebar-id.end","time":1189.3999999761581},{"name":"bigPipe.activity-panel-pipe-id.start","time":1189.6000000238419},{"name":"bigPipe.activity-panel-pipe-id.end","time":1190.5},{"name":"activityTabFullyLoaded","time":1267.2000000476837}],"measures":[],"correlationId":"4c72bd50ea5604","effectiveType":"4g","downlink":10,"rtt":0,"serverDuration":107,"dbReadsTimeInMs":16,"dbConnsTimeInMs":36,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}
Fixed all warning except for unknown(aka VS) pragmas, which, I think, are ok to live with.