Uploaded image for project: 'MariaDB Connector/ODBC'
  1. MariaDB Connector/ODBC
  2. ODBC-257

Double-check CPack for a copy-paste error

Details

    • Bug
    • Status: Closed (View Workflow)
    • Minor
    • Resolution: Fixed
    • 3.1.1
    • 3.1.2
    • General
    • None
    • Released tarball; source code

    Description

      Please double check this piece of code I went by, that it is intentional and not a copy-paste error:

      mariadb-connector-odbc-3.1.1-ga-src/CMakeLists.txt

      384 # Packaging
      		 
      385 SET(CPACK_PACKAGE_VERSION_MAJOR "${MARIADB_ODBC_VERSION_MAJOR}")
      		 
      386 SET(CPACK_PACKAGE_VERSION_MINOR "${MARIADB_ODBC_VERSION_MINOR}")
      		 
      387 SET(CPACK_PACKAGE_VERSION_MINOR "${MARIADB_ODBC_VERSION_PATCH}")

      Shouldn't be the line 387 say "..._VERSION_PATCH" instead of "...MINOR" ?

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          mschorm Michal Schorm added a comment -

          Also, on line 202, there's

          202 SET(CPACK_PACKAGE_VERSION ${MARIADB_ODBC_VERSION_MAJOR}.${MARIADB_ODBC_VERSION_MINOR}.${MARIADB_ODBC_VERSION_PATCH})

          unlinke in CONC/C, where the macro is created from the CPACK_PACKAGE_VERSION_* macros:

           37 SET(CPACK_PACKAGE_VERSION_MAJOR 3)
          		 
           38 SET(CPACK_PACKAGE_VERSION_MINOR 0)
          		 
           39 SET(CPACK_PACKAGE_VERSION_PATCH 10)
          		 
           40 SET(CPACK_PACKAGE_VERSION "${CPACK_PACKAGE_VERSION_MAJOR}.${CPACK_PACKAGE_VERSION_MINOR}.${CPACK_PACKAGE_VERSION_PATCH}")

          However I don't understand the cmake / cpack that good to decide, if that makes the lines 385-387 irrelevant, as they are IMHO not used anywhere.

          mschorm Michal Schorm added a comment - Also, on line 202, there's 202 SET(CPACK_PACKAGE_VERSION ${MARIADB_ODBC_VERSION_MAJOR}.${MARIADB_ODBC_VERSION_MINOR}.${MARIADB_ODBC_VERSION_PATCH}) unlinke in CONC/C, where the macro is created from the CPACK_PACKAGE_VERSION_* macros: 37 SET(CPACK_PACKAGE_VERSION_MAJOR 3) 38 SET(CPACK_PACKAGE_VERSION_MINOR 0) 39 SET(CPACK_PACKAGE_VERSION_PATCH 10) 40 SET(CPACK_PACKAGE_VERSION "${CPACK_PACKAGE_VERSION_MAJOR}.${CPACK_PACKAGE_VERSION_MINOR}.${CPACK_PACKAGE_VERSION_PATCH}") However I don't understand the cmake / cpack that good to decide, if that makes the lines 385-387 irrelevant, as they are IMHO not used anywhere.
          Lawrin Lawrin Novitsky added a comment - - edited

          That is apparently some copy/paste error. But also that is true, that it's not used anywhere, and thus was harmless. Looks like that part was copied from C/C, where they(those variables) are used. Removed them so far.

          Lawrin Lawrin Novitsky added a comment - - edited That is apparently some copy/paste error. But also that is true, that it's not used anywhere, and thus was harmless. Looks like that part was copied from C/C, where they(those variables) are used. Removed them so far.

          People

            Lawrin Lawrin Novitsky
            mschorm Michal Schorm
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.