Lawrin Novitsky added a comment - 2018-07-19 22:18 I've created ODBC-164 . I guess that should work for you. I don't want to have any search for libmariadb, and/or checks if version is correct, though. I'll only add -lmariadb to the linking command, if libmariadb folder is not present

Michal Schorm added a comment - 2018-08-02 14:14 I tried with today's GitHub master branches for CONC/C & CONC/ODBC. CONC/C built fine; CONC/ODBC dies on following error: [ 31%] Linking C executable odbc_multistatement cd /home/faramos/work/ISSUES/NEW/mariadb-connector-odbc/mariadb-connector-odbc-3.0.6-ga-src/test && /usr/bin/cmake -E cmake_link_script CMakeFiles/odbc_multistatement.dir/link.txt --verbose=1 /usr/bin/cc -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -O2 -g -DNDEBUG -Wl,-z,relro -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -rdynamic CMakeFiles/odbc_multistatement.dir/multistatement.c.o -o odbc_multistatement -lodbc -lmariadbclient -lm -lpthread -ldl /usr/bin/ld: cannot find -lmariadbclient collect2: error: ld returned 1 exit status — Second issue is a patch I need to apply beforehand. Otherwise it searches the /usr/include directly? not sure why. Maybe I created the tarball some weird way. Can you please show me how do you create release tarballs? --- mariadb-connector-odbc-3.0.5-ga-src/test/tap.h 2018-07-31 13:39:02.000000000 +0200 +++ mariadb-connector-odbc-3.0.5-ga-src/test/tap.h_patched 2018-08-01 16:00:45.992610338 +0200 @@ -109,7 +109,7 @@ int strcpy_s(char *dest, size_t buffer_s #include <time.h> #include <assert.h> /* We need mysql for MARIADB_CHARSET_INFO type and conversion routine */ -#include <mysql.h> +#include <mysql/mysql.h> static SQLCHAR *my_dsn= (SQLCHAR *)"test"; static SQLCHAR *my_uid= (SQLCHAR *)"root"; --- mariadb-connector-odbc-3.0.5-ga-src/ma_odbc.h 2018-07-31 13:39:02.000000000 +0200 +++ mariadb-connector-odbc-3.0.5-ga-src/ma_odbc.h_patched 2018-08-01 16:10:09.962798000 +0200 @@ -29,7 +29,7 @@ #include <stdlib.h> -#include <mysql.h> +#include <mysql/mysql.h> #include <ma_legacy_helpers.h> @@ -37,7 +37,7 @@ #include <sqlext.h> #include <odbcinst.h> -#include <errmsg.h> +#include <mysql/errmsg.h> #include <string.h> #include <stdio.h> #include <math.h>

Michal Schorm added a comment - 2018-08-03 13:55 I tried the freshly released tarball for CONC/ODBC 3.0.6 and it builds fine with the following patch: --- mariadb-connector-odbc-3.0.6-ga-src/ma_odbc.h 2018-07-31 13:39:02.000000000 +0200 +++ mariadb-connector-odbc-3.0.6-ga-src/ma_odbc.h_patched 2018-08-01 16:10:09.962798000 +0200 @@ -29,7 +29,7 @@ #include <stdlib.h> -#include <mysql.h> +#include <mysql/mysql.h> #include <ma_legacy_helpers.h> @@ -37,7 +37,7 @@ #include <sqlext.h> #include <odbcinst.h> -#include <errmsg.h> +#include <mysql/errmsg.h> #include <string.h> #include <stdio.h> #include <math.h> That means all of the issues has been resolved, but the patch I need now. (but that does not seem to be related to the previous issues)

Lawrin Novitsky added a comment - 2018-08-03 18:22 I build source package making "package_source" target, which deploys cpack in its turn. We don't include test folder into source package. Thus the build error. As for you headers problem. I am not sure what to do here. I think we install C/C headers into 'mariadb' subdirectory, you have them in 'mysql'. I am quite happy to have C/C as a subproject, and not having to look for headers anywhere at all. And that is what c/odbc cmake config does now - it does not look neither for headers nor for libraries. And I'd prefer to keep it this way. Would something like 'cmake -DCMAKE_C_FLAGS_RELWITHDEBINFO="-I/usr/local/include/mysql"...' be acceptable for you? You could build this way, but I suspect you won't like this. Another thing I could think of is to introduce new cmake parameter something like "HEADERS_LOCATION_PREFIX", that will be empty string by defauld, and will be used in C/C headers inclusion directives, if set. I guess that is something you may like. And I think we do need new JIRA issue for that. btw, 3.0.6 has been published yesterday

Lawrin Novitsky added a comment - 2020-06-08 17:31 I've made small change related to the discussion here. mariadb dir in /usr(/local)/include is added to include directories if connector is built without libmariadb submodule in the source tree.