Uploaded image for project: 'MariaDB MaxScale'
  1. MariaDB MaxScale
  2. MXS-330

Insufficient error handling in httpd.c

    XMLWordPrintable

Details

    • New Feature
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • 1.2.0
    • 1.4.1
    • httpd
    • None
    • All

    Description

      Function httpd_accept in httpd.c does not write any error logs if things fail. In branch MXS-329 I have altered line 363 to:

      if (NULL == client->session || poll_add_dcb(client) == -1)

      which adds a check to handle failure of the session_alloc call.

      However, it would appear that the DCB that was created on line 348 is still hanging around to no purpose and probably needs to be sent to dcb_close().

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              martin brampton martin brampton (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.