Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-9588

Mariadb client-only build creates a useless mysqld_safe file

Details

    • Bug
    • Status: Closed (View Workflow)
    • Trivial
    • Resolution: Fixed
    • 10.1.11, 5.5(EOL), 10.0(EOL)
    • 10.1.16
    • Compiling
    • None
    • CentOS, Ubuntu, Debian

    Description

      Building client only:

      cmake . -DWITHOUT_SERVER=ON

      creates a file named INTALLL_PREFIX/bin/mysqld_safe, which is server-related. So it should be removed from client installed files list., indeed this is error-prone and could lead user to think server is also installed.

      Attachments

        Activity

          I don't see any big danger in user thinking that server is installed – any attempt to run mysqld_safe will clear it out. There are other things that also depend on server being there – scripts/mysql_install_db, for one. While I can't right away think of a situation why they would be needed, I bet there are users that somehow rely on it, and will complain about breaking compatibility if we remove it. However, I don't have a particularly strong opinion on the subject, I'll keep it open for further decision.

          elenst Elena Stepanova added a comment - I don't see any big danger in user thinking that server is installed – any attempt to run mysqld_safe will clear it out. There are other things that also depend on server being there – scripts/mysql_install_db, for one. While I can't right away think of a situation why they would be needed, I bet there are users that somehow rely on it, and will complain about breaking compatibility if we remove it. However, I don't have a particularly strong opinion on the subject, I'll keep it open for further decision.
          fjammes Fabrice Jammes added a comment - - edited

          On our side, having these files in client install directory screwed up our MySQL server detection script, which is part of our install script.
          Please note that these file where not installed when building Oracle/MySQL client, that's why install scripts of our product where broken during MySQL->MariaDB migration. This could also happen to other users which migrate.

          Furthermore if one build different version of MariaDB client and server, this could lead to inconsistency (i.e., depending on the way $PATH is set, use client mysqld_safe to launch mysqld whereas there are not compatible).

          Regards,

          fjammes Fabrice Jammes added a comment - - edited On our side, having these files in client install directory screwed up our MySQL server detection script, which is part of our install script. Please note that these file where not installed when building Oracle/MySQL client, that's why install scripts of our product where broken during MySQL->MariaDB migration. This could also happen to other users which migrate. Furthermore if one build different version of MariaDB client and server, this could lead to inconsistency (i.e., depending on the way $PATH is set, use client mysqld_safe to launch mysqld whereas there are not compatible). Regards,

          People

            serg Sergei Golubchik
            fjammes Fabrice Jammes
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.