[MDEV-9588] Mariadb client-only build creates a useless mysqld_safe file Created: 2016-02-19  Updated: 2016-07-13  Resolved: 2016-07-13

Status: Closed
Project: MariaDB Server
Component/s: Compiling
Affects Version/s: 10.1.11, 5.5, 10.0
Fix Version/s: 10.1.16

Type: Bug Priority: Trivial
Reporter: Fabrice Jammes Assignee: Sergei Golubchik
Resolution: Fixed Votes: 0
Labels: None
Environment:

CentOS, Ubuntu, Debian



 Description   

Building client only:

cmake . -DWITHOUT_SERVER=ON

creates a file named INTALLL_PREFIX/bin/mysqld_safe, which is server-related. So it should be removed from client installed files list., indeed this is error-prone and could lead user to think server is also installed.



 Comments   
Comment by Elena Stepanova [ 2016-02-19 ]

I don't see any big danger in user thinking that server is installed – any attempt to run mysqld_safe will clear it out. There are other things that also depend on server being there – scripts/mysql_install_db, for one. While I can't right away think of a situation why they would be needed, I bet there are users that somehow rely on it, and will complain about breaking compatibility if we remove it. However, I don't have a particularly strong opinion on the subject, I'll keep it open for further decision.

Comment by Fabrice Jammes [ 2016-02-19 ]

On our side, having these files in client install directory screwed up our MySQL server detection script, which is part of our install script.
Please note that these file where not installed when building Oracle/MySQL client, that's why install scripts of our product where broken during MySQL->MariaDB migration. This could also happen to other users which migrate.

Furthermore if one build different version of MariaDB client and server, this could lead to inconsistency (i.e., depending on the way $PATH is set, use client mysqld_safe to launch mysqld whereas there are not compatible).

Regards,

Generated at Thu Feb 08 07:35:49 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.