Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-9519

Start Slave on a Galera should error if master binlog_format=statement and wsrep_auto_increment_control=1

Details

    Description

      Data corruption will happen as soon as the galera cluster size change

      Let's take a table t made of single auto increment and the following binlog 

      # at 770118590
      		 
      #160203 21:31:19 server id 10  end_log_pos 770118618    Intvar
      		 
      SET INSERT_ID=134024921/*!*/;
      		 
      # at 770118618
      		 
      #160203 21:31:19 server id 10  end_log_pos 770121328    Query   thread_id=961224213     exec_time=0     error_code=0
      		 
      SET TIMESTAMP=1454531479/*!*/;
      		 
      INSERT INTO t values  (NULL),(NULL ),(NULL ),(NULL ),(NULL ),(NULL ),(NULL ),(NULL ),(NULL ),(NULL ),(NULL ),(NULL )
      		 
        /*!*/;
      		 
      # at 770121328
      		 
      #160203 21:31:19 server id 10  end_log_pos 770121355    Xid = 701968214
      		 
      COMMIT/*!*/;
      		 
      # at 770121355
      		 
      #160203 21:31:19 server id 10  end_log_pos 770121414    Query   thread_id=961224213     exec_time=0     error_code=0
      		 
      SET TIMESTAMP=1454531479/*!*/;
      		 
      BEGIN
      		 
      /*!*/;
      		 
      # at 770121414
      		 
      #160203 21:31:19 server id 10  end_log_pos 770121442    Intvar
      		 
      SET INSERT_ID=134024933/*!*/;
      		 
      # at 770121442
      		 
      #160203 21:31:19 server id 10  end_log_pos 770124812    Query   thread_id=961224213     exec_time=0     error_code=0
      		 
      SET TIMESTAMP=1454531479/*!*/;
      		 
      INSERT INTO t values  (NULL),(NULL ),(NULL ),(NULL ),(NULL ),(NULL ),(NULL ),(NULL ),(NULL ),(NULL ),(NULL ),(NULL )

      Replication will break because the step of auto increment will change as soon the cluster size change. In statement base the master did not change the step and auto increment overlay will happen and corrupt the data ? 

      Last_SQL_Error: Error 'Duplicate entry '134024933
      		 
       
      MariaDB [db_calameo_v2]> SELECT  ID FROM t WHERE id >= 134024921;
      		 
      +-----------+
      		 
      | LinkID    |
      		 
      +-----------+
      		 
      | 134024921 |
      		 
      | 134024923 |
      		 
      | 134024925 |
      		 
      | 134024927 |
      		 
      | 134024929 |
      		 
      | 134024931 |
      		 
      | 134024933 |
      		 
      | 134024935 |
      		 
      | 134024937 |
      		 
      | 134024939 |
      		 
      | 134024941 |
      		 
      | 134024943 |
      		 
      +-----------+

      So this proposal is to introduce verbose error message at replication start to either change wsrep_auto_increment_control=1 or to use ROW based .

      Attachments

        Issue Links

          causes

          Bug - A problem which impairs or prevents the functions of the product. MDEV-17016 Assertion `!auto_increment_lock && !auto_increment_safe_stmt_log_lock' failed in ha_partition::external_lock

          • Major - Major loss of function.
          • Closed
          is blocked by

          Task - A task that needs to be done. MDEV-6445 UUID column type addition for distributed systems

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            View 5 older comments
            sysprg Julius Goryavsky added a comment -

            Version for 10.1 branch: https://github.com/MariaDB/server/pull/827

            sysprg Julius Goryavsky added a comment - Version for 10.1 branch: https://github.com/MariaDB/server/pull/827
            jplindst Jan Lindström (Inactive) added a comment -

            See git for comments.

            jplindst Jan Lindström (Inactive) added a comment - See git for comments.
            sysprg Julius Goryavsky added a comment -

            I corrected all the regressions found and fixed another error that interfered with auto-increment inserts/updates in STATEMENT mode (with WSREP enabled)

            sysprg Julius Goryavsky added a comment - I corrected all the regressions found and fixed another error that interfered with auto-increment inserts/updates in STATEMENT mode (with WSREP enabled)
            marko Marko Mäkelä added a comment -

            I reverted this for now due to regressions, which might have been fixed by MDEV-17016, which in turn has been waiting for review for a long time.

            marko Marko Mäkelä added a comment - I reverted this for now due to regressions, which might have been fixed by MDEV-17016 , which in turn has been waiting for review for a long time.
            sysprg Julius Goryavsky added a comment -

            Regressions are closed using MDEV-17016, but since then the server code has changed significantly, so I re-posted this fix as a new pull request for branch 10.3, after which it can be ported to 10.1 / 10.2. I made the change for 10.3, since the code in version 10.3 is the most complex and generates many conflicts with automatic merge. New pull request here: https://github.com/MariaDB/server/pull/1187

            sysprg Julius Goryavsky added a comment - Regressions are closed using MDEV-17016 , but since then the server code has changed significantly, so I re-posted this fix as a new pull request for branch 10.3, after which it can be ported to 10.1 / 10.2. I made the change for 10.3, since the code in version 10.3 is the most complex and generates many conflicts with automatic merge. New pull request here: https://github.com/MariaDB/server/pull/1187

            People

              jplindst Jan Lindström (Inactive)
              stephane@skysql.com VAROQUI Stephane
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.