Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-9479

oqgraph fails to build with boost 1.60

Details

    • 10.2.1-4, 10.2.1-5, 10.0.26

    Description

      https://kojipkgs.fedoraproject.org//work/tasks/526/12700526/build.log

      In file included from /builddir/build/BUILD/mariadb-10.1.10/storage/oqgraph/graphcore-graph.h:28:0,
                       from /builddir/build/BUILD/mariadb-10.1.10/storage/oqgraph/graphcore-graph.cc:26:
      /builddir/build/BUILD/mariadb-10.1.10/storage/oqgraph/oqgraph_shim.h:261:13: error: 'no_graph_bundle' does not name a type
           typedef no_graph_bundle type;
                   ^
      /builddir/build/BUILD/mariadb-10.1.10/storage/oqgraph/oqgraph_shim.h:267:13: error: 'no_vertex_bundle' does not name a type
           typedef no_vertex_bundle type;
                   ^
      [ 33%] Building C object storage/myisam/CMakeFiles/myisam.dir/mi_static.c.o
      /builddir/build/BUILD/mariadb-10.1.10/storage/oqgraph/oqgraph_shim.h:273:13: error: 'no_edge_bundle' does not name a type
           typedef no_edge_bundle type;
                   ^
      

      Attachments

        Issue Links

          Activity

            jdornak Jakub Dorňák created issue -
            serg Sergei Golubchik made changes -
            Field Original Value New Value
            Description https://kojipkgs.fedoraproject.org//work/tasks/526/12700526/build.log

            In file included from /builddir/build/BUILD/mariadb-10.1.10/storage/oqgraph/graphcore-graph.h:28:0,
                             from /builddir/build/BUILD/mariadb-10.1.10/storage/oqgraph/graphcore-graph.cc:26:
            /builddir/build/BUILD/mariadb-10.1.10/storage/oqgraph/oqgraph_shim.h:261:13: error: 'no_graph_bundle' does not name a type
                 typedef no_graph_bundle type;
                         ^
            /builddir/build/BUILD/mariadb-10.1.10/storage/oqgraph/oqgraph_shim.h:267:13: error: 'no_vertex_bundle' does not name a type
                 typedef no_vertex_bundle type;
                         ^
            [ 33%] Building C object storage/myisam/CMakeFiles/myisam.dir/mi_static.c.o
            /builddir/build/BUILD/mariadb-10.1.10/storage/oqgraph/oqgraph_shim.h:273:13: error: 'no_edge_bundle' does not name a type
                 typedef no_edge_bundle type;
                         ^
            https://kojipkgs.fedoraproject.org//work/tasks/526/12700526/build.log
            {noformat}
            In file included from /builddir/build/BUILD/mariadb-10.1.10/storage/oqgraph/graphcore-graph.h:28:0,
                             from /builddir/build/BUILD/mariadb-10.1.10/storage/oqgraph/graphcore-graph.cc:26:
            /builddir/build/BUILD/mariadb-10.1.10/storage/oqgraph/oqgraph_shim.h:261:13: error: 'no_graph_bundle' does not name a type
                 typedef no_graph_bundle type;
                         ^
            /builddir/build/BUILD/mariadb-10.1.10/storage/oqgraph/oqgraph_shim.h:267:13: error: 'no_vertex_bundle' does not name a type
                 typedef no_vertex_bundle type;
                         ^
            [ 33%] Building C object storage/myisam/CMakeFiles/myisam.dir/mi_static.c.o
            /builddir/build/BUILD/mariadb-10.1.10/storage/oqgraph/oqgraph_shim.h:273:13: error: 'no_edge_bundle' does not name a type
                 typedef no_edge_bundle type;
                         ^
            {noformat}

            It is actually documented here: https://mariadb.com/kb/en/mariadb/compiling-oqgraph/

            To compile OQGraph v2 you need to have the boost library with the versions not earlier than 1.40 and not later than 1.55

            but lets ask andymc73 if it's still supposed to be the case.

            elenst Elena Stepanova added a comment - It is actually documented here: https://mariadb.com/kb/en/mariadb/compiling-oqgraph/ To compile OQGraph v2 you need to have the boost library with the versions not earlier than 1.40 and not later than 1.55 but lets ask andymc73 if it's still supposed to be the case.
            elenst Elena Stepanova made changes -
            Component/s Storage Engine - OQGRAPH [ 10130 ]
            Assignee Andrew McDonnell [ andymc73 ]
            jdornak Jakub Dorňák added a comment - - edited

            I have built it with 1.58 in Fedora 23.

            jdornak Jakub Dorňák added a comment - - edited I have built it with 1.58 in Fedora 23.
            jdornak Jakub Dorňák made changes -
            Affects Version/s 10.1.11 [ 21202 ]
            grknight Brian Evans added a comment -

            @elenst

            It is actually documented here: https://mariadb.com/kb/en/mariadb/compiling-oqgraph/

            To compile OQGraph v2 you need to have the boost library with the versions not earlier than 1.40 and not later than 1.55

            but lets ask Andrew McDonnell if it's still supposed to be the case.

            I believe MariaDB 10 and above use OQGraph v3. So it is a valid bug

            grknight Brian Evans added a comment - @elenst It is actually documented here: https://mariadb.com/kb/en/mariadb/compiling-oqgraph/ To compile OQGraph v2 you need to have the boost library with the versions not earlier than 1.40 and not later than 1.55 but lets ask Andrew McDonnell if it's still supposed to be the case. I believe MariaDB 10 and above use OQGraph v3. So it is a valid bug
            andymc73 Andrew McDonnell added a comment - - edited

            There is no "v3" - ha_ograph.cc reports "3.0" but this would seem to be a very long standing typo. As things stand, the wiki is correct, until someone submits a patch to make it work with newer systems

            v1 was the original prototype by Antony which TTBOMK used a heavy reliance on the internals of the then MySQL 5.1
            v2 was a rewrite using boost graph and a more correct storage engine implementation and virtual, which is what currently exists. Again TTBOMK, this was all first built before I got everything working for MariaDB 10.0

            andymc73 Andrew McDonnell added a comment - - edited There is no "v3" - ha_ograph.cc reports "3.0" but this would seem to be a very long standing typo. As things stand, the wiki is correct, until someone submits a patch to make it work with newer systems v1 was the original prototype by Antony which TTBOMK used a heavy reliance on the internals of the then MySQL 5.1 v2 was a rewrite using boost graph and a more correct storage engine implementation and virtual, which is what currently exists. Again TTBOMK, this was all first built before I got everything working for MariaDB 10.0

            But wiki also states:

            > MariaDB starting with 10.0.7
            > OQGraph v3 compiles fine with the newer boost libraries, but it additionally needs Judy library installed.

            And, for example, I do have judy installed, and had mariadb-10.1.12 built fine against boost-1.58. But now mariadb-10.1.13 refuses to build against boost-1.60 with the error, mentioned by bug reporter. So, I'd say it is some specific boost-1.60 incompatibility, or bulding against 1.58 with judy installed was a coincedence...

            mva Vadim A. Misbakh-Soloviov added a comment - But wiki also states: > MariaDB starting with 10.0.7 > OQGraph v3 compiles fine with the newer boost libraries, but it additionally needs Judy library installed. And, for example, I do have judy installed, and had mariadb-10.1.12 built fine against boost-1.58. But now mariadb-10.1.13 refuses to build against boost-1.60 with the error, mentioned by bug reporter. So, I'd say it is some specific boost-1.60 incompatibility, or bulding against 1.58 with judy installed was a coincedence...
            serg Sergei Golubchik made changes -
            Fix Version/s 10.1 [ 16100 ]
            xnox Dimitri John Ledkov added a comment - Is https://github.com/boostorg/graph/commit/e77cd87de11263b60cebf6996efc7d1b3cb4d0b5#diff-3d8548656a5db728e028023e3f803acdL385 of any help?

            For reference, this comment and the follow-up comment on an older bug are probably relevant. In summary, yes there is a v3, and it has different boost requirements than v2.

            FWIW, I have mariadb 10.0.24 here compiled against boost 1.59.0 and all is good. So it's most likely something introduced in 1.60.0.

            pprkut Heinz Wiesinger added a comment - For reference, this comment and the follow-up comment on an older bug are probably relevant. In summary, yes there is a v3, and it has different boost requirements than v2. FWIW, I have mariadb 10.0.24 here compiled against boost 1.59.0 and all is good. So it's most likely something introduced in 1.60.0.
            xnox Dimitri John Ledkov made changes -
            Attachment fix-ftbfs-boost1.60.patch [ 42048 ]

            This affects latest Debian/Ubuntu too, as it has upgraded to Boost 1.6.

            otto Otto Kekäläinen added a comment - This affects latest Debian/Ubuntu too, as it has upgraded to Boost 1.6.
            otto Otto Kekäläinen made changes -
            Component/s Packaging [ 10700 ]
            Component/s Platform Debian [ 10136 ]
            Component/s Platform RedHat [ 11302 ]
            Fix Version/s 10.0 [ 16000 ]
            Affects Version/s 10.0.25 [ 21701 ]
            Labels foundation

            Looked into this and it appears the typedef's are gone in Boost 1.6. There might be an easy fix for this, which I'm attempting now.

            cvicentiu Vicențiu Ciorbaru added a comment - Looked into this and it appears the typedef's are gone in Boost 1.6. There might be an easy fix for this, which I'm attempting now.
            cvicentiu Vicențiu Ciorbaru made changes -
            Assignee Andrew McDonnell [ andymc73 ] Vicentiu Ciorbaru [ cvicentiu ]
            cvicentiu Vicențiu Ciorbaru made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            cvicentiu Vicențiu Ciorbaru made changes -
            Sprint 10.2.1-4 [ 66 ]

            Hi Sergei,

            Can you please review the patch for this bug?

            https://lists.launchpad.net/maria-developers/msg09673.html

            cvicentiu Vicențiu Ciorbaru added a comment - Hi Sergei, Can you please review the patch for this bug? https://lists.launchpad.net/maria-developers/msg09673.html
            cvicentiu Vicențiu Ciorbaru made changes -
            Assignee Vicentiu Ciorbaru [ cvicentiu ] Sergei Golubchik [ serg ]
            Status In Progress [ 3 ] In Review [ 10002 ]
            serg Sergei Golubchik made changes -
            Assignee Sergei Golubchik [ serg ] Vicentiu Ciorbaru [ cvicentiu ]
            Status In Review [ 10002 ] Stalled [ 10000 ]
            ratzpo Rasmus Johansson (Inactive) made changes -
            Sprint 10.2.1-4 [ 66 ] 10.2.1-4, 10.2.1-5 [ 66, 68 ]
            danblack Daniel Black added a comment - https://lists.launchpad.net/maria-developers/msg09677.html has permission to push.

            I just noticed that an Ubuntu dev patched the 10.0.24-7 package in Yaketty (without consulting upstream) to support Boost 1.6. His patch is visible here: https://patches.ubuntu.com/m/mariadb-10.0/mariadb-10.0_10.0.24-7ubuntu1.patch

            cvicentiu Please review that patch and apply something from there is its good.

            otto Otto Kekäläinen added a comment - I just noticed that an Ubuntu dev patched the 10.0.24-7 package in Yaketty (without consulting upstream) to support Boost 1.6. His patch is visible here: https://patches.ubuntu.com/m/mariadb-10.0/mariadb-10.0_10.0.24-7ubuntu1.patch cvicentiu Please review that patch and apply something from there is its good.

            @Otto

            An Ubuntu dev is I, who commented on here https://jira.mariadb.org/browse/MDEV-9479?focusedCommentId=83042&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-83042 and also attached the patch to the same effect to this ticket on 10th of May. I'm not sure if that got missed, or I did something wrong in jira.

            It is functionally equivalent to what was posted on the mailing list, and it's irrelevant which patch is taken =) or something else is done.

            Regards,

            Dimitri.

            xnox Dimitri John Ledkov added a comment - @Otto An Ubuntu dev is I, who commented on here https://jira.mariadb.org/browse/MDEV-9479?focusedCommentId=83042&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-83042 and also attached the patch to the same effect to this ticket on 10th of May. I'm not sure if that got missed, or I did something wrong in jira. It is functionally equivalent to what was posted on the mailing list, and it's irrelevant which patch is taken =) or something else is done. Regards, Dimitri.
            cvicentiu Vicențiu Ciorbaru made changes -
            Sprint 10.2.1-4, 10.2.1-5 [ 66, 68 ] 10.2.1-4, 10.2.1-5, 10.0.26 [ 66, 68, 73 ]

            This also affects MariaDB v10.1.14, when compiled against Boost v1.6.1.0 (On Void Linux, with both MariaDB and Boost compiled from source).
            Can confirm Dimitri's patch works (thanks).

            antonio-malcolm Antonio Malcolm added a comment - This also affects MariaDB v10.1.14, when compiled against Boost v1.6.1.0 (On Void Linux, with both MariaDB and Boost compiled from source). Can confirm Dimitri's patch works (thanks).
            danblack Daniel Black made changes -
            danblack Daniel Black made changes -
            Labels foundation contribution foundation
            svoj Sergey Vojtovich made changes -
            Priority Major [ 3 ] Critical [ 2 ]

            Fixed with:
            26bf066

            cvicentiu Vicențiu Ciorbaru added a comment - Fixed with: 26bf066
            cvicentiu Vicențiu Ciorbaru made changes -
            Fix Version/s 10.0.26 [ 22016 ]
            Fix Version/s 10.0 [ 16000 ]
            Fix Version/s 10.1 [ 16100 ]
            Resolution Fixed [ 1 ]
            Status Stalled [ 10000 ] Closed [ 6 ]
            serg Sergei Golubchik made changes -
            Fix Version/s 10.1.15 [ 22018 ]
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 73824 ] MariaDB v4 [ 150047 ]

            People

              cvicentiu Vicențiu Ciorbaru
              jdornak Jakub Dorňák
              Votes:
              1 Vote for this issue
              Watchers:
              12 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.