Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-9443

Roles aren't supported in prepared statements

Details

    • 10.1.13

    Description

      It's not possible to use CREATE/DROP ROLE in prepared statements. Example:

      MariaDB [(none)]> SET @createRole = 'CREATE ROLE developers';
      		 
      Query OK, 0 rows affected (0.00 sec)
      		 
      MariaDB [(none)]> PREPARE stmtCreateRole FROM @createRole;
      		 
      ERROR 1295 (HY000): This command is not supported in the prepared statement protocol yet

      Attachments

        Issue Links

          is part of

          Task - A task that needs to be done. MDEV-5522 Make CREATE/DROP/SET ROLE usable in stored programs

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open

          Activity

            Ascending order - Click to sort in descending order
            ratzpo Rasmus Johansson (Inactive) created issue -
            ratzpo Rasmus Johansson (Inactive) made changes -
            Field Original Value New Value
            ratzpo Rasmus Johansson (Inactive) made changes -
            elenst Elena Stepanova made changes -
            Status Open [ 1 ] Confirmed [ 10101 ]
            elenst Elena Stepanova made changes -
            Comment [ We have this one already, MDEV-5522. ]
            elenst Elena Stepanova added a comment -

            Same for REVOKE, see MDEV-9691.

            elenst Elena Stepanova added a comment - Same for REVOKE , see MDEV-9691 .
            cvicentiu Vicențiu Ciorbaru made changes -
            Assignee Vicentiu Ciorbaru [ cvicentiu ]
            ratzpo Rasmus Johansson (Inactive) made changes -
            Sprint 10.1.13 [ 42 ]
            ratzpo Rasmus Johansson (Inactive) made changes -
            Rank Ranked lower
            cvicentiu Vicențiu Ciorbaru made changes -
            Status Confirmed [ 10101 ] In Progress [ 3 ]
            cvicentiu Vicențiu Ciorbaru added a comment -

            Hi Sergei,

            Can you please review the following 2 patches for this MDEV?

            http://lists.askmonty.org/pipermail/commits/2016-March/009151.html
            http://lists.askmonty.org/pipermail/commits/2016-March/009158.html

            Thanks!

            cvicentiu Vicențiu Ciorbaru added a comment - Hi Sergei, Can you please review the following 2 patches for this MDEV? http://lists.askmonty.org/pipermail/commits/2016-March/009151.html http://lists.askmonty.org/pipermail/commits/2016-March/009158.html Thanks!
            cvicentiu Vicențiu Ciorbaru made changes -
            Assignee Vicentiu Ciorbaru [ cvicentiu ] Sergei Golubchik [ serg ]
            Status In Progress [ 3 ] In Review [ 10002 ]
            serg Sergei Golubchik added a comment -

            You've simply enabled these commands. Is that enough? So far looks like it is.

            Please add few tests with reexecution. Like:

            PREPARE @stm1 "...";
            		 
            EXECUTE @stmt1;
            		 
            EXECUTE @stmt1;

            Then ok to push.

            serg Sergei Golubchik added a comment - You've simply enabled these commands. Is that enough? So far looks like it is. Please add few tests with reexecution. Like: PREPARE @stm1 "..." ; EXECUTE @stmt1; EXECUTE @stmt1; Then ok to push.
            serg Sergei Golubchik made changes -
            Assignee Sergei Golubchik [ serg ] Vicentiu Ciorbaru [ cvicentiu ]
            Status In Review [ 10002 ] Stalled [ 10000 ]
            cvicentiu Vicențiu Ciorbaru added a comment -

            Fixed with:
            https://github.com/MariaDB/server/commit/c4bef7ad3c1528e902e88aa8b2446f29ffc1b0e6
            https://github.com/MariaDB/server/commit/287f2d2947c15d1e7ff35ba123b37291147e1c85
            https://github.com/MariaDB/server/commit/29753fb9f285afa0550c54409a985970460b9172

            cvicentiu Vicențiu Ciorbaru added a comment - Fixed with: https://github.com/MariaDB/server/commit/c4bef7ad3c1528e902e88aa8b2446f29ffc1b0e6 https://github.com/MariaDB/server/commit/287f2d2947c15d1e7ff35ba123b37291147e1c85 https://github.com/MariaDB/server/commit/29753fb9f285afa0550c54409a985970460b9172
            cvicentiu Vicențiu Ciorbaru made changes -
            issue.field.resolutiondate 2016-03-22 20:25:45.0 2016-03-22 20:25:45.856
            cvicentiu Vicențiu Ciorbaru made changes -
            Component/s Admin statements [ 11400 ]
            Component/s Prepared Statements [ 10804 ]
            Fix Version/s 10.1.13 [ 21803 ]
            Fix Version/s 10.1 [ 16100 ]
            Resolution Fixed [ 1 ]
            Status Stalled [ 10000 ] Closed [ 6 ]
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 73719 ] MariaDB v4 [ 150023 ]

            People

              cvicentiu Vicențiu Ciorbaru
              ratzpo Rasmus Johansson (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.