Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-9397

Split field.cc:calc_pack_length() into virtual methods in Type_handler

Details

    Description

      The relevant piece of the code in the original type handler patch:

      @@ -9565,6 +9670,9 @@ enum_field_types get_blob_type_from_leng
      		 
       
       uint32 calc_pack_length(enum_field_types type,uint32 length)
      		 
       {
      		 
      +  if (const Type_handler *handler= Type_handlers.handler(type))
      		 
      +    return handler->calc_pack_length(length);
      		 
      +
      		 
         switch (type) {
      		 
         case MYSQL_TYPE_VAR_STRING:
      		 
         case MYSQL_TYPE_STRING:
      		 
       

      Attachments

        Issue Links

          blocks

          Epic - Created by Jira Software - do not edit or delete. Issue type for a big user story that needs to be broken down. MDEV-4912 Data type plugin API version 1

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          relates to

          Task - A task that needs to be done. MDEV-12833 Split Column_definition::create_length_to_internal_length() to virtual methods in Type_handler

          • Major - Major loss of function.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            bar Alexander Barkov created issue -
            bar Alexander Barkov made changes -
            Field Original Value New Value
            Labels refactoring
            bar Alexander Barkov made changes -
            serg Sergei Golubchik made changes -
            Fix Version/s 10.2 [ 14601 ]
            bar Alexander Barkov made changes -
            Component/s OTHER [ 10125 ]
            bar Alexander Barkov made changes -
            Status Open [ 1 ] Confirmed [ 10101 ]
            bar Alexander Barkov made changes -
            issue.field.resolutiondate 2017-05-17 08:22:28.0 2017-05-17 08:22:28.997
            bar Alexander Barkov made changes -
            Fix Version/s 10.3.1 [ 22532 ]
            Resolution Fixed [ 1 ]
            Status Confirmed [ 10101 ] Closed [ 6 ]
            bar Alexander Barkov made changes -
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 73613 ] MariaDB v4 [ 132768 ]

            People

              bar Alexander Barkov
              bar Alexander Barkov
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.