Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-9169

BINLOG_SYM in keywords_sp causes shift/reduce conflicts

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 10.1, 10.2
    • Fix Version/s: 10.2.0
    • Component/s: Parser
    • Labels:
      None
    • Sprint:
      10.2.0-1

      Description

      Currently BINLOG_SYM is specified in the "keywords_sp" rule. It should be moved to the "keywords" rule instead. This removes around 20 shift/reduce conflicts.

      We do want "binlog" to be an identifier, like this:

      CREATE TABLE t1 (binlog INT);

      but it should not be allowed as a label in a stored routine, to avoid shift/reduce conflicts with "BINLOG" as a beginning of a verb clause.

        Attachments

          Activity

            People

            • Assignee:
              bar Alexander Barkov
              Reporter:
              bar Alexander Barkov
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: