[MDEV-9004] libgroonga is built even when the mroonga plugin is disabled - Jira

Details

Type: Bug
Status: Closed (View Workflow)
Priority: Major
Resolution: Duplicate
Affects Version/s: 10.1.8
Fix Version/s: N/A
Component/s: Compiling, Storage Engine - Mroonga
Labels:
None
Environment:
Linux

Sprint:
10.1.9-3

Description

When building mariadb with -DPLUGIN_MROONGA=NO, libgroonga is still built:

[ 84%] Built target innobase

make[4]: Entering directory `/home/build/p4/zimbra/main/ThirdParty/mariadb/tmp/UBUNTU14_64/zimbra-mariadb'

Scanning dependencies of target libgroonga

make[4]: Leaving directory `/home/build/p4/zimbra/main/ThirdParty/mariadb/tmp/UBUNTU14_64/zimbra-mariadb'

make[4]: Entering directory `/home/build/p4/zimbra/main/ThirdParty/mariadb/tmp/UBUNTU14_64/zimbra-mariadb'

[ 84%] Building C object storage/mroonga/vendor/groonga/lib/CMakeFiles/libgroonga.dir/com.c.o

[ 84%] Building C object storage/mroonga/vendor/groonga/lib/CMakeFiles/libgroonga.dir/command.c.o

(etc)

This is incorrect, since MROONGA is not enabled.

Attachments

Issue Links

is duplicated by

MDEV-8969 groonga is compiled even with -DPLUGIN_MROONGA=NO

Closed

Activity

Ascending order - Click to sort in descending order

Quanah Gibson-Mount (Inactive) created issue - 2015-10-23 23:03

Quanah Gibson-Mount (Inactive) added a comment - 2015-10-23 23:17 - edited

build@c790:~/p4/zimbra/main/ThirdParty/mariadb/tmp/RHEL7_64/zimbra-mariadb/rpm/BUILD/mariadb-10.1.8$ grep PLUGIN_MROONGA CMakeCache.txt

PLUGIN_MROONGA:STRING=NO

Clearly disabled. Yet:

build@c790:~/p4/zimbra/main/ThirdParty/mariadb/tmp/RHEL7_64/zimbra-mariadb/rpm/BUILD/mariadb-10.1.8$ grep -i groonga CMakeCache.txt

//Groonga's default DB key management algorithm

//groonga default document root

GRN_DEFAULT_DOCUMENT_ROOT:PATH=/opt/zimbra/common/share/groonga/html/admin

//groonga default document root base path

//Groonga's default encoding

//groonga default match escalation threshold

//groonga default relative document root

GRN_DEFAULT_RELATIVE_DOCUMENT_ROOT:PATH=share/groonga/html/admin

GRN_LOG_PATH:FILEPATH=/opt/zimbra/common/var/log/groonga/groonga.log

//DANGER!!! groonga stack size. Normarlly, you should not change

GROONGA_NORMALIZER_MYSQL_EMBED:BOOL=ON

//Embed libgroonga

MRN_GROONGA_EMBED:BOOL=ON

//Embed groonga-normalizer-mysql Groonga plugin

MRN_GROONGA_NORMALIZER_MYSQL_EMBED:BOOL=ON

groonga-normalizer-mysql_BINARY_DIR:STATIC=/home/build/p4/zimbra/main/ThirdParty/mariadb/tmp/RHEL7_64/zimbra-mariadb/rpm/BUILD/mariadb-10.1.8/storage/mroonga/vendor/groonga/vendor/plugins/groonga-normalizer-mysql

groonga-normalizer-mysql_SOURCE_DIR:STATIC=/home/build/p4/zimbra/main/ThirdParty/mariadb/tmp/RHEL7_64/zimbra-mariadb/rpm/BUILD/mariadb-10.1.8/storage/mroonga/vendor/groonga/vendor/plugins/groonga-normalizer-mysql

groonga_BINARY_DIR:STATIC=/home/build/p4/zimbra/main/ThirdParty/mariadb/tmp/RHEL7_64/zimbra-mariadb/rpm/BUILD/mariadb-10.1.8/storage/mroonga/vendor/groonga

groonga_SOURCE_DIR:STATIC=/home/build/p4/zimbra/main/ThirdParty/mariadb/tmp/RHEL7_64/zimbra-mariadb/rpm/BUILD/mariadb-10.1.8/storage/mroonga/vendor/groonga

libgroonga_LIB_DEPENDS:STATIC=general;-lpthread;general;rt;general;pthread;general;z;general;dl;general;m;general;stdc++;

mysql_normalizer_LIB_DEPENDS:STATIC=general;-lpthread;general;libgroonga;

stop_word_token_filter_LIB_DEPENDS:STATIC=general;-lpthread;general;libgroonga;

suggest_LIB_DEPENDS:STATIC=general;-lpthread;general;libgroonga;

tsv_query_expander_LIB_DEPENDS:STATIC=general;-lpthread;general;libgroonga;

vector_functions_LIB_DEPENDS:STATIC=general;-lpthread;general;libgroonga;

Quanah Gibson-Mount (Inactive) added a comment - 2015-10-23 23:17 - edited build@c790:~/p4/zimbra/main/ThirdParty/mariadb/tmp/RHEL7_64/zimbra-mariadb/rpm/BUILD/mariadb-10.1.8$ grep PLUGIN_MROONGA CMakeCache.txt PLUGIN_MROONGA:STRING=NO Clearly disabled. Yet: build@c790:~/p4/zimbra/main/ThirdParty/mariadb/tmp/RHEL7_64/zimbra-mariadb/rpm/BUILD/mariadb-10.1.8$ grep -i groonga CMakeCache.txt //Groonga's default DB key management algorithm //groonga default document root GRN_DEFAULT_DOCUMENT_ROOT:PATH=/opt/zimbra/common/share/groonga/html/admin //groonga default document root base path //Groonga's default encoding //groonga default match escalation threshold //groonga default relative document root GRN_DEFAULT_RELATIVE_DOCUMENT_ROOT:PATH=share/groonga/html/admin GRN_LOG_PATH:FILEPATH=/opt/zimbra/common/var/log/groonga/groonga.log //DANGER!!! groonga stack size. Normarlly, you should not change GROONGA_NORMALIZER_MYSQL_EMBED:BOOL=ON //Embed libgroonga MRN_GROONGA_EMBED:BOOL=ON //Embed groonga-normalizer-mysql Groonga plugin MRN_GROONGA_NORMALIZER_MYSQL_EMBED:BOOL=ON groonga-normalizer-mysql_BINARY_DIR:STATIC=/home/build/p4/zimbra/main/ThirdParty/mariadb/tmp/RHEL7_64/zimbra-mariadb/rpm/BUILD/mariadb-10.1.8/storage/mroonga/vendor/groonga/vendor/plugins/groonga-normalizer-mysql groonga-normalizer-mysql_SOURCE_DIR:STATIC=/home/build/p4/zimbra/main/ThirdParty/mariadb/tmp/RHEL7_64/zimbra-mariadb/rpm/BUILD/mariadb-10.1.8/storage/mroonga/vendor/groonga/vendor/plugins/groonga-normalizer-mysql groonga_BINARY_DIR:STATIC=/home/build/p4/zimbra/main/ThirdParty/mariadb/tmp/RHEL7_64/zimbra-mariadb/rpm/BUILD/mariadb-10.1.8/storage/mroonga/vendor/groonga groonga_SOURCE_DIR:STATIC=/home/build/p4/zimbra/main/ThirdParty/mariadb/tmp/RHEL7_64/zimbra-mariadb/rpm/BUILD/mariadb-10.1.8/storage/mroonga/vendor/groonga libgroonga_LIB_DEPENDS:STATIC=general;-lpthread;general;rt;general;pthread;general;z;general;dl;general;m;general;stdc++; mysql_normalizer_LIB_DEPENDS:STATIC=general;-lpthread;general;libgroonga; stop_word_token_filter_LIB_DEPENDS:STATIC=general;-lpthread;general;libgroonga; suggest_LIB_DEPENDS:STATIC=general;-lpthread;general;libgroonga; tsv_query_expander_LIB_DEPENDS:STATIC=general;-lpthread;general;libgroonga; vector_functions_LIB_DEPENDS:STATIC=general;-lpthread;general;libgroonga;

Quanah Gibson-Mount (Inactive) added a comment - 2015-10-23 23:18 - edited

Also present in generated Makefile:

build@c790:~/p4/zimbra/main/ThirdParty/mariadb/tmp/RHEL7_64/zimbra-mariadb/rpm/BUILD/mariadb-10.1.8$ grep groonga Makefile

        $(MAKE) -f storage/mroonga/vendor/groonga/plugins/suggest/CMakeFiles/suggest.dir/build.make storage/mroonga/vendor/groonga/plugins/suggest/CMakeFiles/suggest.dir/build

        $(MAKE) -f storage/mroonga/vendor/groonga/plugins/query_expanders/CMakeFiles/tsv_query_expander.dir/build.make storage/mroonga/vendor/groonga/plugins/query_expanders/CMakeFiles/tsv_query_expander.dir/build

        $(MAKE) -f storage/mroonga/vendor/groonga/plugins/token_filters/CMakeFiles/stop_word_token_filter.dir/build.make storage/mroonga/vendor/groonga/plugins/token_filters/CMakeFiles/stop_word_token_filter.dir/build

        $(MAKE) -f storage/mroonga/vendor/groonga/plugins/functions/CMakeFiles/vector_functions.dir/build.make storage/mroonga/vendor/groonga/plugins/functions/CMakeFiles/vector_functions.dir/build

# Target rules for targets named libgroonga

libgroonga: cmake_check_build_system

        $(MAKE) -f CMakeFiles/Makefile2 libgroonga

.PHONY : libgroonga

libgroonga/fast:

        $(MAKE) -f storage/mroonga/vendor/groonga/lib/CMakeFiles/libgroonga.dir/build.make storage/mroonga/vendor/groonga/lib/CMakeFiles/libgroonga.dir/build

.PHONY : libgroonga/fast

        $(MAKE) -f storage/mroonga/vendor/groonga/vendor/plugins/groonga-normalizer-mysql/normalizers/CMakeFiles/mysql_normalizer.dir/build.make storage/mroonga/vendor/groonga/vendor/plugins/groonga-normalizer-mysql/normalizers/CMakeFiles/mysql_normalizer.dir/build

        @echo "... libgroonga"

Quanah Gibson-Mount (Inactive) added a comment - 2015-10-23 23:18 - edited Also present in generated Makefile: build@c790:~/p4/zimbra/main/ThirdParty/mariadb/tmp/RHEL7_64/zimbra-mariadb/rpm/BUILD/mariadb-10.1.8$ grep groonga Makefile $(MAKE) -f storage/mroonga/vendor/groonga/plugins/suggest/CMakeFiles/suggest.dir/build.make storage/mroonga/vendor/groonga/plugins/suggest/CMakeFiles/suggest.dir/build $(MAKE) -f storage/mroonga/vendor/groonga/plugins/query_expanders/CMakeFiles/tsv_query_expander.dir/build.make storage/mroonga/vendor/groonga/plugins/query_expanders/CMakeFiles/tsv_query_expander.dir/build $(MAKE) -f storage/mroonga/vendor/groonga/plugins/token_filters/CMakeFiles/stop_word_token_filter.dir/build.make storage/mroonga/vendor/groonga/plugins/token_filters/CMakeFiles/stop_word_token_filter.dir/build $(MAKE) -f storage/mroonga/vendor/groonga/plugins/functions/CMakeFiles/vector_functions.dir/build.make storage/mroonga/vendor/groonga/plugins/functions/CMakeFiles/vector_functions.dir/build # Target rules for targets named libgroonga libgroonga: cmake_check_build_system $(MAKE) -f CMakeFiles/Makefile2 libgroonga .PHONY : libgroonga libgroonga/fast: $(MAKE) -f storage/mroonga/vendor/groonga/lib/CMakeFiles/libgroonga.dir/build.make storage/mroonga/vendor/groonga/lib/CMakeFiles/libgroonga.dir/build .PHONY : libgroonga/fast $(MAKE) -f storage/mroonga/vendor/groonga/vendor/plugins/groonga-normalizer-mysql/normalizers/CMakeFiles/mysql_normalizer.dir/build.make storage/mroonga/vendor/groonga/vendor/plugins/groonga-normalizer-mysql/normalizers/CMakeFiles/mysql_normalizer.dir/build @echo "... libgroonga"

Elena Stepanova added a comment - 2015-10-24 02:47

quanah, thanks for the report.
As a workaround, you can use -DWITHOUT_MROONGA_STORAGE_ENGINE=YES.

Elena Stepanova added a comment - 2015-10-24 02:47 quanah , thanks for the report. As a workaround, you can use -DWITHOUT_MROONGA_STORAGE_ENGINE=YES .

Elena Stepanova made changes - 2015-10-24 02:47

Field	Original Value	New Value
Fix Version/s		10.1 [ 16100 ]
Assignee		Sergei Golubchik [ serg ]

Elena Stepanova made changes - 2015-10-24 02:47

Description

When building mariadb with -DPLUGIN_MROONGA=NO, libgroonga is still built:

[ 84%] Built target innobase
make[4]: Entering directory `/home/build/p4/zimbra/main/ThirdParty/mariadb/tmp/UBUNTU14_64/zimbra-mariadb'
Scanning dependencies of target libgroonga
make[4]: Leaving directory `/home/build/p4/zimbra/main/ThirdParty/mariadb/tmp/UBUNTU14_64/zimbra-mariadb'
make[4]: Entering directory `/home/build/p4/zimbra/main/ThirdParty/mariadb/tmp/UBUNTU14_64/zimbra-mariadb'
[ 84%] Building C object storage/mroonga/vendor/groonga/lib/CMakeFiles/libgroonga.dir/com.c.o
[ 84%] Building C object storage/mroonga/vendor/groonga/lib/CMakeFiles/libgroonga.dir/command.c.o
(etc)

This is incorrect, since MROONGA is not enabled.

When building mariadb with -DPLUGIN_MROONGA=NO, libgroonga is still built:

{noformat}
[ 84%] Built target innobase
make[4]: Entering directory `/home/build/p4/zimbra/main/ThirdParty/mariadb/tmp/UBUNTU14_64/zimbra-mariadb'
Scanning dependencies of target libgroonga
make[4]: Leaving directory `/home/build/p4/zimbra/main/ThirdParty/mariadb/tmp/UBUNTU14_64/zimbra-mariadb'
make[4]: Entering directory `/home/build/p4/zimbra/main/ThirdParty/mariadb/tmp/UBUNTU14_64/zimbra-mariadb'
[ 84%] Building C object storage/mroonga/vendor/groonga/lib/CMakeFiles/libgroonga.dir/com.c.o
[ 84%] Building C object storage/mroonga/vendor/groonga/lib/CMakeFiles/libgroonga.dir/command.c.o
{noformat}
(etc)

This is incorrect, since MROONGA is not enabled.

Quanah Gibson-Mount (Inactive) added a comment - 2015-10-24 02:56

@elenst Thanks, I will try that.

Quanah Gibson-Mount (Inactive) added a comment - 2015-10-24 02:56 @elenst Thanks, I will try that.

Sergei Golubchik made changes - 2015-11-10 16:57

Sprint

10.1.9-3 [ 20 ]

Sergei Golubchik made changes - 2015-11-10 19:51

Link

This issue is duplicated by ~~MDEV-8969~~ [ ~~MDEV-8969~~ ]

Sergei Golubchik added a comment - 2015-11-10 19:51

A duplicate of ~~MDEV-8969~~

Sergei Golubchik added a comment - 2015-11-10 19:51 A duplicate of MDEV-8969

Sergei Golubchik made changes - 2015-11-10 19:51

Fix Version/s		N/A [ 14700 ]
Fix Version/s	10.1 [ 16100 ]
Resolution		Duplicate [ 3 ]
Status	Open [ 1 ]	Closed [ 6 ]

Sergei Golubchik made changes - 2021-12-06 21:42

Workflow

MariaDB v3 [ 72256 ]

MariaDB v4 [ 149753 ]

People

Assignee:: Sergei Golubchik

Reporter:: Quanah Gibson-Mount (Inactive)

Votes:: 0 Vote for this issue

Watchers:: 3 Start watching this issue

Dates

Created:: 2015-10-23 23:03

Updated:: 2015-11-10 19:51

Resolved:: 2015-11-10 19:51

Git Integration

Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.

MariaDB Server

Details

Description

Attachments

Issue Links

Activity

People

Dates

Git Integration