[MDEV-9004] libgroonga is built even when the mroonga plugin is disabled Created: 2015-10-23  Updated: 2015-11-10  Resolved: 2015-11-10

Status: Closed
Project: MariaDB Server
Component/s: Compiling, Storage Engine - Mroonga
Affects Version/s: 10.1.8
Fix Version/s: N/A

Type: Bug Priority: Major
Reporter: Quanah Gibson-Mount (Inactive) Assignee: Sergei Golubchik
Resolution: Duplicate Votes: 0
Labels: None
Environment:

Linux

Issue Links:
Duplicate
is duplicated by MDEV-8969 groonga is compiled even with -DPLUGI... Closed
Sprint: 10.1.9-3

 Description   

When building mariadb with -DPLUGIN_MROONGA=NO, libgroonga is still built:

[ 84%] Built target innobase
 
make[4]: Entering directory `/home/build/p4/zimbra/main/ThirdParty/mariadb/tmp/UBUNTU14_64/zimbra-mariadb'
 
Scanning dependencies of target libgroonga
 
make[4]: Leaving directory `/home/build/p4/zimbra/main/ThirdParty/mariadb/tmp/UBUNTU14_64/zimbra-mariadb'
 
make[4]: Entering directory `/home/build/p4/zimbra/main/ThirdParty/mariadb/tmp/UBUNTU14_64/zimbra-mariadb'
 
[ 84%] Building C object storage/mroonga/vendor/groonga/lib/CMakeFiles/libgroonga.dir/com.c.o
 
[ 84%] Building C object storage/mroonga/vendor/groonga/lib/CMakeFiles/libgroonga.dir/command.c.o

(etc)

This is incorrect, since MROONGA is not enabled.

 Comments   
Comment by Quanah Gibson-Mount (Inactive) [ 2015-10-23 ] 

build@c790:~/p4/zimbra/main/ThirdParty/mariadb/tmp/RHEL7_64/zimbra-mariadb/rpm/BUILD/mariadb-10.1.8$ grep PLUGIN_MROONGA CMakeCache.txt
 
PLUGIN_MROONGA:STRING=NO

Clearly disabled. Yet:

build@c790:~/p4/zimbra/main/ThirdParty/mariadb/tmp/RHEL7_64/zimbra-mariadb/rpm/BUILD/mariadb-10.1.8$ grep -i groonga CMakeCache.txt
 
//Groonga's default DB key management algorithm
 
//groonga default document root
 
GRN_DEFAULT_DOCUMENT_ROOT:PATH=/opt/zimbra/common/share/groonga/html/admin
 
//groonga default document root base path
 
//Groonga's default encoding
 
//groonga default match escalation threshold
 
//groonga default relative document root
 
GRN_DEFAULT_RELATIVE_DOCUMENT_ROOT:PATH=share/groonga/html/admin
 
GRN_LOG_PATH:FILEPATH=/opt/zimbra/common/var/log/groonga/groonga.log
 
//DANGER!!! groonga stack size. Normarlly, you should not change
 
GROONGA_NORMALIZER_MYSQL_EMBED:BOOL=ON
 
//Embed libgroonga
 
MRN_GROONGA_EMBED:BOOL=ON
 
//Embed groonga-normalizer-mysql Groonga plugin
 
MRN_GROONGA_NORMALIZER_MYSQL_EMBED:BOOL=ON
 
groonga-normalizer-mysql_BINARY_DIR:STATIC=/home/build/p4/zimbra/main/ThirdParty/mariadb/tmp/RHEL7_64/zimbra-mariadb/rpm/BUILD/mariadb-10.1.8/storage/mroonga/vendor/groonga/vendor/plugins/groonga-normalizer-mysql
 
groonga-normalizer-mysql_SOURCE_DIR:STATIC=/home/build/p4/zimbra/main/ThirdParty/mariadb/tmp/RHEL7_64/zimbra-mariadb/rpm/BUILD/mariadb-10.1.8/storage/mroonga/vendor/groonga/vendor/plugins/groonga-normalizer-mysql
 
groonga_BINARY_DIR:STATIC=/home/build/p4/zimbra/main/ThirdParty/mariadb/tmp/RHEL7_64/zimbra-mariadb/rpm/BUILD/mariadb-10.1.8/storage/mroonga/vendor/groonga
 
groonga_SOURCE_DIR:STATIC=/home/build/p4/zimbra/main/ThirdParty/mariadb/tmp/RHEL7_64/zimbra-mariadb/rpm/BUILD/mariadb-10.1.8/storage/mroonga/vendor/groonga
 
libgroonga_LIB_DEPENDS:STATIC=general;-lpthread;general;rt;general;pthread;general;z;general;dl;general;m;general;stdc++;
 
mysql_normalizer_LIB_DEPENDS:STATIC=general;-lpthread;general;libgroonga;
 
stop_word_token_filter_LIB_DEPENDS:STATIC=general;-lpthread;general;libgroonga;
 
suggest_LIB_DEPENDS:STATIC=general;-lpthread;general;libgroonga;
 
tsv_query_expander_LIB_DEPENDS:STATIC=general;-lpthread;general;libgroonga;
 
vector_functions_LIB_DEPENDS:STATIC=general;-lpthread;general;libgroonga;

Comment by Quanah Gibson-Mount (Inactive) [ 2015-10-23 ]

Also present in generated Makefile:

build@c790:~/p4/zimbra/main/ThirdParty/mariadb/tmp/RHEL7_64/zimbra-mariadb/rpm/BUILD/mariadb-10.1.8$ grep groonga Makefile
 
        $(MAKE) -f storage/mroonga/vendor/groonga/plugins/suggest/CMakeFiles/suggest.dir/build.make storage/mroonga/vendor/groonga/plugins/suggest/CMakeFiles/suggest.dir/build
 
        $(MAKE) -f storage/mroonga/vendor/groonga/plugins/query_expanders/CMakeFiles/tsv_query_expander.dir/build.make storage/mroonga/vendor/groonga/plugins/query_expanders/CMakeFiles/tsv_query_expander.dir/build
 
        $(MAKE) -f storage/mroonga/vendor/groonga/plugins/token_filters/CMakeFiles/stop_word_token_filter.dir/build.make storage/mroonga/vendor/groonga/plugins/token_filters/CMakeFiles/stop_word_token_filter.dir/build
 
        $(MAKE) -f storage/mroonga/vendor/groonga/plugins/functions/CMakeFiles/vector_functions.dir/build.make storage/mroonga/vendor/groonga/plugins/functions/CMakeFiles/vector_functions.dir/build
 
# Target rules for targets named libgroonga
 
libgroonga: cmake_check_build_system
 
        $(MAKE) -f CMakeFiles/Makefile2 libgroonga
 
.PHONY : libgroonga
 
libgroonga/fast:
 
        $(MAKE) -f storage/mroonga/vendor/groonga/lib/CMakeFiles/libgroonga.dir/build.make storage/mroonga/vendor/groonga/lib/CMakeFiles/libgroonga.dir/build
 
.PHONY : libgroonga/fast
 
        $(MAKE) -f storage/mroonga/vendor/groonga/vendor/plugins/groonga-normalizer-mysql/normalizers/CMakeFiles/mysql_normalizer.dir/build.make storage/mroonga/vendor/groonga/vendor/plugins/groonga-normalizer-mysql/normalizers/CMakeFiles/mysql_normalizer.dir/build
 
        @echo "... libgroonga"

Comment by Elena Stepanova [ 2015-10-24 ]

quanah, thanks for the report.
As a workaround, you can use -DWITHOUT_MROONGA_STORAGE_ENGINE=YES.

Comment by Quanah Gibson-Mount (Inactive) [ 2015-10-24 ]

@elenst Thanks, I will try that.

Comment by Sergei Golubchik [ 2015-11-10 ]

A duplicate of MDEV-8969

Generated at Thu Feb 08 07:31:25 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.