Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-8713

Add continuous binary log backup to mysqlbinlog

Details

    • 10.2.0-1, 10.2.0-5, 10.2.0-6

    Description

      This is a request to add continuous binary log backup to mysqlbinlog, such as exists in the MySQL mysqlbinlog as of 5.6.

      "As of MySQL 5.6, mysqlbinlog can read binary log files and write new files containing the same content—that is, in binary format rather than text format. This capability enables you to easily back up a binary log in its original format. mysqlbinlog can make a static backup, backing up a set of log files and stopping when the end of the last file is reached. It can also make a continuous (“live”) backup, staying connected to the server when it reaches the end of the last log file and continuing to copy new events as they are generated. In continuous-backup operation, mysqlbinlog runs until the connection ends (for example, when the server exits) or mysqlbinlog is forcibly terminated. When the connection ends, mysqlbinlog does not wait and retry the connection, unlike a slave replication server. To continue a live backup after the server has been restarted, you must also restart mysqlbinlog."

      https://dev.mysql.com/doc/refman/5.6/en/mysqlbinlog-backup.html

      This also requires the addition of 2 new mysqlbinlog options:

      --stop-never
      --stop-never-slave-server-id=id

      https://dev.mysql.com/doc/refman/5.6/en/mysqlbinlog.html#option_mysqlbinlog_stop-never
      https://dev.mysql.com/doc/refman/5.6/en/mysqlbinlog.html#option_mysqlbinlog_stop-never-slave-server-id

      Attachments

        Issue Links

          Activity

            ccalender Chris Calender (Inactive) created issue -
            ccalender Chris Calender (Inactive) made changes -
            Field Original Value New Value
            Priority Major [ 3 ] Minor [ 4 ]
            ccalender Chris Calender (Inactive) made changes -
            Priority Minor [ 4 ] Major [ 3 ]
            elenst Elena Stepanova made changes -
            elenst Elena Stepanova made changes -
            elenst Elena Stepanova made changes -

            We already have a similar request, MDEV-8473. But that entry describes two separate issues – a feature request for new options from 5.6, and an upstream bug https://bugs.mysql.com/bug.php?id=65812. So, I am going to convert this one, MDEV-8713, to a feature request, while MDEV-8473 will remain a bug report.

            elenst Elena Stepanova added a comment - We already have a similar request, MDEV-8473 . But that entry describes two separate issues – a feature request for new options from 5.6, and an upstream bug https://bugs.mysql.com/bug.php?id=65812 . So, I am going to convert this one, MDEV-8713 , to a feature request, while MDEV-8473 will remain a bug report.

            Please note that MDEV-8473 also requested --raw option.

            elenst Elena Stepanova added a comment - Please note that MDEV-8473 also requested --raw option.
            elenst Elena Stepanova made changes -
            Issue Type Bug [ 1 ] Task [ 3 ]
            elenst Elena Stepanova made changes -
            Fix Version/s 10.2 [ 14601 ]
            elenst Elena Stepanova made changes -
            Fix Version/s 10.1 [ 16100 ]

            I've added 10.1 to the list of 'Fix version(s)' just in case it can somehow be added there, although I highly doubt that, please don't see it as a promise.

            elenst Elena Stepanova added a comment - I've added 10.1 to the list of 'Fix version(s)' just in case it can somehow be added there, although I highly doubt that, please don't see it as a promise.
            elenst Elena Stepanova made changes -
            Component/s Scripts & Clients [ 11002 ]

            Yes, thank you, the --raw option should also be included with this.

            --raw

            "By default, mysqlbinlog reads binary log files and writes events in text format. The --raw option tells mysqlbinlog to write them in their original binary format. Its use requires that --read-from-remote-server also be used because the files are requested from a server. mysqlbinlog writes one output file for each file read from the server. The --raw option can be used to make a backup of a server's binary log. With the --stop-never option, the backup is “live” because mysqlbinlog stays connected to the server. By default, output files are written in the current directory with the same names as the original log files. Output file names can be modified using the --result-file option. For more information, see Section 4.6.8.3, 'Using mysqlbinlog to Back Up Binary Log Files'. This option was added in MySQL 5.6.0."

            https://dev.mysql.com/doc/refman/5.6/en/mysqlbinlog.html#option_mysqlbinlog_raw

            ccalender Chris Calender (Inactive) added a comment - Yes, thank you, the --raw option should also be included with this. --raw "By default, mysqlbinlog reads binary log files and writes events in text format. The --raw option tells mysqlbinlog to write them in their original binary format. Its use requires that --read-from-remote-server also be used because the files are requested from a server. mysqlbinlog writes one output file for each file read from the server. The --raw option can be used to make a backup of a server's binary log. With the --stop-never option, the backup is “live” because mysqlbinlog stays connected to the server. By default, output files are written in the current directory with the same names as the original log files. Output file names can be modified using the --result-file option. For more information, see Section 4.6.8.3, 'Using mysqlbinlog to Back Up Binary Log Files'. This option was added in MySQL 5.6.0." https://dev.mysql.com/doc/refman/5.6/en/mysqlbinlog.html#option_mysqlbinlog_raw
            serg Sergei Golubchik made changes -
            Priority Major [ 3 ] Critical [ 2 ]
            elenst Elena Stepanova made changes -
            serg Sergei Golubchik made changes -
            Fix Version/s 10.2 [ 14601 ]
            Fix Version/s 10.1 [ 16100 ]
            serg Sergei Golubchik made changes -
            Fix Version/s 10.2 [ 14601 ]
            ratzpo Rasmus Johansson (Inactive) made changes -
            Sprint 10.2.0-1 [ 21 ]
            ratzpo Rasmus Johansson (Inactive) made changes -
            Rank Ranked lower
            ratzpo Rasmus Johansson (Inactive) made changes -
            Assignee Alexey Botchkov [ holyfoot ]
            holyfoot Alexey Botchkov made changes -
            Status Open [ 1 ] In Progress [ 3 ]

            Please note that semi sync was added to this feature in WebScaleSQL

            stephane@skysql.com VAROQUI Stephane added a comment - Please note that semi sync was added to this feature in WebScaleSQL
            holyfoot Alexey Botchkov added a comment - Patch proposal: http://lists.askmonty.org/pipermail/commits/2015-November/008692.html
            holyfoot Alexey Botchkov made changes -
            Assignee Alexey Botchkov [ holyfoot ] Sergei Golubchik [ serg ]
            Status In Progress [ 3 ] In Review [ 10002 ]
            ratzpo Rasmus Johansson (Inactive) made changes -
            Sprint 10.2.0-1 [ 21 ] 10.2.0-1, 5.5.47-1 [ 21, 22 ]
            ratzpo Rasmus Johansson (Inactive) made changes -
            Rank Ranked higher
            ratzpo Rasmus Johansson (Inactive) made changes -
            Sprint 10.2.0-1, 5.5.47-1 [ 21, 22 ] 10.2.0-1 [ 21 ]
            ratzpo Rasmus Johansson (Inactive) made changes -
            Rank Ranked lower
            ratzpo Rasmus Johansson (Inactive) made changes -
            Sprint 10.2.0-1 [ 21 ] 10.2.0-1, 10.2.0-5 [ 21, 32 ]
            ratzpo Rasmus Johansson (Inactive) made changes -
            Rank Ranked higher
            serg Sergei Golubchik made changes -
            Assignee Sergei Golubchik [ serg ] Alexey Botchkov [ holyfoot ]
            Status In Review [ 10002 ] Stalled [ 10000 ]
            holyfoot Alexey Botchkov made changes -
            Sprint 10.2.0-1, 10.2.0-5 [ 21, 32 ] 10.2.0-1, 10.2.0-5, 10.2.0-6 [ 21, 32, 37 ]
            holyfoot Alexey Botchkov added a comment - Patch proposal v2: http://lists.askmonty.org/pipermail/commits/2016-February/009051.html
            holyfoot Alexey Botchkov made changes -
            Assignee Alexey Botchkov [ holyfoot ] Sergei Golubchik [ serg ]
            Status Stalled [ 10000 ] In Review [ 10002 ]

            ok to push

            serg Sergei Golubchik added a comment - ok to push
            serg Sergei Golubchik made changes -
            Assignee Sergei Golubchik [ serg ] Alexey Botchkov [ holyfoot ]
            Status In Review [ 10002 ] Stalled [ 10000 ]
            holyfoot Alexey Botchkov made changes -
            Fix Version/s 10.2.0 [ 20700 ]
            Fix Version/s 10.2 [ 14601 ]
            Resolution Fixed [ 1 ]
            Status Stalled [ 10000 ] Closed [ 6 ]

            Are the only real changes here to mysqlbinlong.cc?

            If so, can this be backported to a GA version, say 10.1, and/or even 10.0?

            ccalender Chris Calender (Inactive) added a comment - Are the only real changes here to mysqlbinlong.cc? If so, can this be backported to a GA version, say 10.1, and/or even 10.0?

            Many thanks for adding this, btw!

            ccalender Chris Calender (Inactive) added a comment - Many thanks for adding this, btw!

            Chris,
            from the technical point of view yes, it can be backported to 10.0.

            holyfoot Alexey Botchkov added a comment - Chris, from the technical point of view yes, it can be backported to 10.0.
            serg Sergei Golubchik made changes -
            serg Sergei Golubchik made changes -
            Component/s Replication [ 10100 ]
            ratzpo Rasmus Johansson (Inactive) made changes -
            elenst Elena Stepanova made changes -
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 71312 ] MariaDB v4 [ 132676 ]

            People

              holyfoot Alexey Botchkov
              ccalender Chris Calender (Inactive)
              Votes:
              6 Vote for this issue
              Watchers:
              11 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.