Hello All,
In reviewing code in MariaDB 10.0.2x, I found an instance where
a memory request via strndup() is made, but no check for a return
value of NULL, indicating failure is made. The directory in this
case is 'mariadb-10.0.20/plugin/auth_pam/' and the filename is
'auth_pam.c'. The patch file below should address this issue:
--- auth_pam.c.orig 2015-08-23 16:16:25.075000000 -0700
|
+++ auth_pam.c 2015-08-23 16:18:17.594000000 -0700
|
@@ -99,6 +99,9 @@
|
return PAM_CONV_ERR;
|
/* allocate and copy the reply to the response array */
|
(*resp)[i].resp = strndup((char*)pkt, pkt_len);
|
+ if ( (*resp)[i].resp == NULL) {
|
+ return PAM_CONV_ERR;
|
+ }
|
param->ptr = param->buf + 1;
|
}
|
}
|
Questions, Comments, Suggestions?
I am attaching the patch file(s) to this bug report.
Bill Parker (wp02855 at gmail dot com)
{"report":{"fcp":904,"ttfb":170.30000001192093,"pageVisibility":"visible","entityId":52804,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":1,"journeyId":"47375474-1a89-4f78-bfe2-22b4143d89d0","navigationType":0,"readyForUser":985.4000000059605,"redirectCount":0,"resourceLoadedEnd":822.8000000119209,"resourceLoadedStart":175.40000000596046,"resourceTiming":[{"duration":206.09999999403954,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2bv2/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":175.40000000596046,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":175.40000000596046,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":381.5,"responseStart":0,"secureConnectionStart":0},{"duration":206.09999999403954,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2bv2/820016/12ta74/2380add21a9a1006587582385952de73/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":175.7000000178814,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":175.7000000178814,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":381.80000001192093,"responseStart":0,"secureConnectionStart":0},{"duration":231.2999999821186,"initiatorType":"script","name":"https://jira.mariadb.org/s/e9b27a47da5fb0f74a35acd57e9847fb-CDN/lu2bv2/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":175.80000001192093,"connectEnd":175.80000001192093,"connectStart":175.80000001192093,"domainLookupEnd":175.80000001192093,"domainLookupStart":175.80000001192093,"fetchStart":175.80000001192093,"redirectEnd":0,"redirectStart":0,"requestStart":175.80000001192093,"responseEnd":407.09999999403954,"responseStart":407.09999999403954,"secureConnectionStart":175.80000001192093},{"duration":263.90000000596046,"initiatorType":"script","name":"https://jira.mariadb.org/s/c32eb0da7ad9831253f8397e6cc26afd-CDN/lu2bv2/820016/12ta74/2380add21a9a1006587582385952de73/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":176,"connectEnd":176,"connectStart":176,"domainLookupEnd":176,"domainLookupStart":176,"fetchStart":176,"redirectEnd":0,"redirectStart":0,"requestStart":176,"responseEnd":439.90000000596046,"responseStart":439.90000000596046,"secureConnectionStart":176},{"duration":267.40000000596046,"initiatorType":"script","name":"https://jira.mariadb.org/s/bc0bcb146314416123c992714ee00ff7-CDN/lu2bv2/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":176.30000001192093,"connectEnd":176.30000001192093,"connectStart":176.30000001192093,"domainLookupEnd":176.30000001192093,"domainLookupStart":176.30000001192093,"fetchStart":176.30000001192093,"redirectEnd":0,"redirectStart":0,"requestStart":176.30000001192093,"responseEnd":443.7000000178814,"responseStart":443.7000000178814,"secureConnectionStart":176.30000001192093},{"duration":267.80000001192093,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":176.40000000596046,"connectEnd":176.40000000596046,"connectStart":176.40000000596046,"domainLookupEnd":176.40000000596046,"domainLookupStart":176.40000000596046,"fetchStart":176.40000000596046,"redirectEnd":0,"redirectStart":0,"requestStart":176.40000000596046,"responseEnd":444.2000000178814,"responseStart":444.2000000178814,"secureConnectionStart":176.40000000596046},{"duration":267.90000000596046,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":176.59999999403954,"connectEnd":176.59999999403954,"connectStart":176.59999999403954,"domainLookupEnd":176.59999999403954,"domainLookupStart":176.59999999403954,"fetchStart":176.59999999403954,"redirectEnd":0,"redirectStart":0,"requestStart":176.59999999403954,"responseEnd":444.5,"responseStart":444.5,"secureConnectionStart":176.59999999403954},{"duration":379,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2bv2/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":176.80000001192093,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":176.80000001192093,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":555.8000000119209,"responseStart":0,"secureConnectionStart":0},{"duration":267.90000000596046,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":177,"connectEnd":177,"connectStart":177,"domainLookupEnd":177,"domainLookupStart":177,"fetchStart":177,"redirectEnd":0,"redirectStart":0,"requestStart":177,"responseEnd":444.90000000596046,"responseStart":444.90000000596046,"secureConnectionStart":177},{"duration":378.69999998807907,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2bv2/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":177.2000000178814,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":177.2000000178814,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":555.9000000059605,"responseStart":0,"secureConnectionStart":0},{"duration":268.2999999821186,"initiatorType":"script","name":"https://jira.mariadb.org/s/719848dd97ebe0663199f49a3936487a-CDN/lu2bv2/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":177.30000001192093,"connectEnd":177.30000001192093,"connectStart":177.30000001192093,"domainLookupEnd":177.30000001192093,"domainLookupStart":177.30000001192093,"fetchStart":177.30000001192093,"redirectEnd":0,"redirectStart":0,"requestStart":177.30000001192093,"responseEnd":445.59999999403954,"responseStart":445.59999999403954,"secureConnectionStart":177.30000001192093},{"duration":431.7000000178814,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":182.5,"connectEnd":182.5,"connectStart":182.5,"domainLookupEnd":182.5,"domainLookupStart":182.5,"fetchStart":182.5,"redirectEnd":0,"redirectStart":0,"requestStart":182.5,"responseEnd":614.2000000178814,"responseStart":614.2000000178814,"secureConnectionStart":182.5},{"duration":434.7999999821186,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":182.7000000178814,"connectEnd":182.7000000178814,"connectStart":182.7000000178814,"domainLookupEnd":182.7000000178814,"domainLookupStart":182.7000000178814,"fetchStart":182.7000000178814,"redirectEnd":0,"redirectStart":0,"requestStart":182.7000000178814,"responseEnd":617.5,"responseStart":617.4000000059605,"secureConnectionStart":182.7000000178814},{"duration":29.600000023841858,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":584.0999999940395,"connectEnd":584.0999999940395,"connectStart":584.0999999940395,"domainLookupEnd":584.0999999940395,"domainLookupStart":584.0999999940395,"fetchStart":584.0999999940395,"redirectEnd":0,"redirectStart":0,"requestStart":584.0999999940395,"responseEnd":613.7000000178814,"responseStart":613.7000000178814,"secureConnectionStart":584.0999999940395},{"duration":205.59999999403954,"initiatorType":"link","name":"https://jira.mariadb.org/s/d5715adaadd168a9002b108b2b039b50-CDN/lu2bv2/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/css/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":617.2000000178814,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":617.2000000178814,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":822.8000000119209,"responseStart":0,"secureConnectionStart":0}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":12,"responseStart":170,"responseEnd":177,"domLoading":174,"domInteractive":1039,"domContentLoadedEventStart":1039,"domContentLoadedEventEnd":1086,"domComplete":1255,"loadEventStart":1255,"loadEventEnd":1256,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":1020.2000000178814},{"name":"bigPipe.sidebar-id.end","time":1021},{"name":"bigPipe.activity-panel-pipe-id.start","time":1021.2000000178814},{"name":"bigPipe.activity-panel-pipe-id.end","time":1022.3000000119209},{"name":"activityTabFullyLoaded","time":1106.7000000178814}],"measures":[],"correlationId":"49058b291ea447","effectiveType":"4g","downlink":10,"rtt":0,"serverDuration":99,"dbReadsTimeInMs":11,"dbConnsTimeInMs":20,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}
Thanks for your contribution. Patch applied to 10.1 branch. Github revision link attached.