Type:
Task
Priority:
Major
Resolution:
Unresolved
Fix Version/s:
None
Sprint:
10.1.7-2, 10.1.8-1
Under terms of MDEV-7649 we disabled using indexes when comparing a field to a broken character string when processing non-equality operations <, >, <=, =>, <> , for example:
SET NAMES 'utf8';
DROP TABLE IF EXISTS t1;
CREATE TABLE t1 (
id INT NOT NULL AUTO_INCREMENT PRIMARY KEY,
a varchar(60) COLLATE utf8_general_ci NOT NULL DEFAULT '',
KEY(a)
) ENGINE=MyISAM CHARSET=utf8 COLLATE=utf8_general_ci;
INSERT INTO t1 (a) VALUES ('admin');
INSERT INTO t1 (a) VALUES ('admin;');
INSERT INTO t1 (a) VALUES ('adminx');
EXPLAIN SELECT * FROM t1 WHERE a < 'admin��';
returns
+------+-------------+-------+------+---------------+------+---------+------+------+-------------+
| id | select_type | table | type | possible_keys | key | key_len | ref | rows | Extra |
+------+-------------+-------+------+---------------+------+---------+------+------+-------------+
| 1 | SIMPLE | t1 | ALL | a | NULL | NULL | NULL | 3 | Using where |
+------+-------------+-------+------+---------------+------+---------+------+------+-------------+
Notice, '��' is a broken utf8 character (it's a valid utf8mb4 character).
Using indexes was disabled to have consistent result set with and without index.
Now with MDEV-8036 done we can enable using indexes again.
get_mm_leaf() calls Field::store() to put the value to search into the Field buffer.
This task will need changes in Fields, which should be able to store broken byte sequences somehow for index search purposes, as the normal behavior of Field::store() to replace bad bytes to question marks won't work for search optimization purposes.
Possible solutions:
Add a new parameter to Field::store()
Add a new method, say Field::store_for_search()
Add a new flag into Field::flags and make Field::store() check this flag to decide whether to replace bad bytes to question marks (on INSERT/UPDATE), or to handle bad bytes differently (on search).
Add new classes Field_string_key, Field_varstring_key, Field_blob_key and overwrite their store() methods
As soon as we're able to store bad values into the Field buffer in a way suitable for search (instead of just replacing to '?'), the collation should be able to do index scan in exactly the same way with a non-indexed search.
{"report":{"fcp":739.7000000029802,"ttfb":177.70000000298023,"pageVisibility":"visible","entityId":52110,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":1,"journeyId":"fc9b7f62-ebd6-446b-8375-9c0ec7cc3769","navigationType":0,"readyForUser":794.5,"redirectCount":0,"resourceLoadedEnd":820.4000000059605,"resourceLoadedStart":198,"resourceTiming":[{"duration":10.800000011920929,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2bv2/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":198,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":198,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":208.80000001192093,"responseStart":0,"secureConnectionStart":0},{"duration":10.700000002980232,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2bv2/820016/12ta74/2380add21a9a1006587582385952de73/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":198.40000000596046,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":198.40000000596046,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":209.1000000089407,"responseStart":0,"secureConnectionStart":0},{"duration":83.29999999701977,"initiatorType":"script","name":"https://jira.mariadb.org/s/e9b27a47da5fb0f74a35acd57e9847fb-CDN/lu2bv2/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":198.6000000089407,"connectEnd":198.6000000089407,"connectStart":198.6000000089407,"domainLookupEnd":198.6000000089407,"domainLookupStart":198.6000000089407,"fetchStart":198.6000000089407,"redirectEnd":0,"redirectStart":0,"requestStart":198.6000000089407,"responseEnd":281.90000000596046,"responseStart":281.90000000596046,"secureConnectionStart":198.6000000089407},{"duration":107.40000000596046,"initiatorType":"script","name":"https://jira.mariadb.org/s/c32eb0da7ad9831253f8397e6cc26afd-CDN/lu2bv2/820016/12ta74/2380add21a9a1006587582385952de73/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":198.70000000298023,"connectEnd":198.70000000298023,"connectStart":198.70000000298023,"domainLookupEnd":198.70000000298023,"domainLookupStart":198.70000000298023,"fetchStart":198.70000000298023,"redirectEnd":0,"redirectStart":0,"requestStart":198.70000000298023,"responseEnd":306.1000000089407,"responseStart":306.1000000089407,"secureConnectionStart":198.70000000298023},{"duration":110.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/bc0bcb146314416123c992714ee00ff7-CDN/lu2bv2/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":199.1000000089407,"connectEnd":199.1000000089407,"connectStart":199.1000000089407,"domainLookupEnd":199.1000000089407,"domainLookupStart":199.1000000089407,"fetchStart":199.1000000089407,"redirectEnd":0,"redirectStart":0,"requestStart":199.1000000089407,"responseEnd":309.6000000089407,"responseStart":309.6000000089407,"secureConnectionStart":199.1000000089407},{"duration":110.79999999701977,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":199.30000001192093,"connectEnd":199.30000001192093,"connectStart":199.30000001192093,"domainLookupEnd":199.30000001192093,"domainLookupStart":199.30000001192093,"fetchStart":199.30000001192093,"redirectEnd":0,"redirectStart":0,"requestStart":199.30000001192093,"responseEnd":310.1000000089407,"responseStart":310.1000000089407,"secureConnectionStart":199.30000001192093},{"duration":110.8999999910593,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":199.6000000089407,"connectEnd":199.6000000089407,"connectStart":199.6000000089407,"domainLookupEnd":199.6000000089407,"domainLookupStart":199.6000000089407,"fetchStart":199.6000000089407,"redirectEnd":0,"redirectStart":0,"requestStart":199.6000000089407,"responseEnd":310.5,"responseStart":310.5,"secureConnectionStart":199.6000000089407},{"duration":115.90000000596046,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2bv2/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":199.70000000298023,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":199.70000000298023,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":315.6000000089407,"responseStart":0,"secureConnectionStart":0},{"duration":111.1000000089407,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":200,"connectEnd":200,"connectStart":200,"domainLookupEnd":200,"domainLookupStart":200,"fetchStart":200,"redirectEnd":0,"redirectStart":0,"requestStart":200,"responseEnd":311.1000000089407,"responseStart":311.1000000089407,"secureConnectionStart":200},{"duration":115.59999999403954,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2bv2/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":200.1000000089407,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":200.1000000089407,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":315.70000000298023,"responseStart":0,"secureConnectionStart":0},{"duration":111.40000000596046,"initiatorType":"script","name":"https://jira.mariadb.org/s/719848dd97ebe0663199f49a3936487a-CDN/lu2bv2/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":200.20000000298023,"connectEnd":200.20000000298023,"connectStart":200.20000000298023,"domainLookupEnd":200.20000000298023,"domainLookupStart":200.20000000298023,"fetchStart":200.20000000298023,"redirectEnd":0,"redirectStart":0,"requestStart":200.20000000298023,"responseEnd":311.6000000089407,"responseStart":311.6000000089407,"secureConnectionStart":200.20000000298023},{"duration":124.90000000596046,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":201.40000000596046,"connectEnd":201.40000000596046,"connectStart":201.40000000596046,"domainLookupEnd":201.40000000596046,"domainLookupStart":201.40000000596046,"fetchStart":201.40000000596046,"redirectEnd":0,"redirectStart":0,"requestStart":201.40000000596046,"responseEnd":326.30000001192093,"responseStart":326.30000001192093,"secureConnectionStart":201.40000000596046},{"duration":125.30000001192093,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":201.5,"connectEnd":201.5,"connectStart":201.5,"domainLookupEnd":201.5,"domainLookupStart":201.5,"fetchStart":201.5,"redirectEnd":0,"redirectStart":0,"requestStart":201.5,"responseEnd":326.80000001192093,"responseStart":326.80000001192093,"secureConnectionStart":201.5},{"duration":114.29999999701977,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":511.40000000596046,"connectEnd":511.40000000596046,"connectStart":511.40000000596046,"domainLookupEnd":511.40000000596046,"domainLookupStart":511.40000000596046,"fetchStart":511.40000000596046,"redirectEnd":0,"redirectStart":0,"requestStart":511.40000000596046,"responseEnd":625.7000000029802,"responseStart":625.6000000089407,"secureConnectionStart":511.40000000596046},{"duration":135.79999999701977,"initiatorType":"link","name":"https://jira.mariadb.org/s/d5715adaadd168a9002b108b2b039b50-CDN/lu2bv2/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/css/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":684.4000000059605,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":684.4000000059605,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":820.2000000029802,"responseStart":0,"secureConnectionStart":0},{"duration":135.5,"initiatorType":"link","name":"https://jira.mariadb.org/s/50bc9be5bfead1a25e72c1a9338c94f6-CDN/lu2bv2/820016/12ta74/e108c7645258ccb43280ed3404e3e949/_/download/contextbatch/css/com.atlassian.jira.plugins.jira-development-integration-plugin:0,-_super,-jira.view.issue,-jira.global,-jira.general,-jira.browse.project,-project.issue.navigator,-atl.general/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":684.9000000059605,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":684.9000000059605,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":820.4000000059605,"responseStart":0,"secureConnectionStart":0},{"duration":60.20000000298023,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/e65b778d185daf5aee24936755b43da6/_/download/contextbatch/js/browser-metrics-plugin.contrib,-_super,-project.issue.navigator,-jira.view.issue,-atl.general/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":685.7000000029802,"connectEnd":685.7000000029802,"connectStart":685.7000000029802,"domainLookupEnd":685.7000000029802,"domainLookupStart":685.7000000029802,"fetchStart":685.7000000029802,"redirectEnd":0,"redirectStart":0,"requestStart":685.7000000029802,"responseEnd":745.9000000059605,"responseStart":745.9000000059605,"secureConnectionStart":685.7000000029802},{"duration":67.1000000089407,"initiatorType":"script","name":"https://jira.mariadb.org/s/53a43b6764f587426c7bb9a150184c00-CDN/lu2bv2/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/js/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":686.2000000029802,"connectEnd":686.2000000029802,"connectStart":686.2000000029802,"domainLookupEnd":686.2000000029802,"domainLookupStart":686.2000000029802,"fetchStart":686.2000000029802,"redirectEnd":0,"redirectStart":0,"requestStart":686.2000000029802,"responseEnd":753.3000000119209,"responseStart":753.2000000029802,"secureConnectionStart":686.2000000029802},{"duration":68.20000000298023,"initiatorType":"script","name":"https://jira.mariadb.org/s/630dda803a823fdd5771c4338338e018-CDN/lu2bv2/820016/12ta74/e108c7645258ccb43280ed3404e3e949/_/download/contextbatch/js/com.atlassian.jira.plugins.jira-development-integration-plugin:0,-_super,-jira.view.issue,-jira.global,-jira.general,-jira.browse.project,-project.issue.navigator,-atl.general/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":686.6000000089407,"connectEnd":686.6000000089407,"connectStart":686.6000000089407,"domainLookupEnd":686.6000000089407,"domainLookupStart":686.6000000089407,"fetchStart":686.6000000089407,"redirectEnd":0,"redirectStart":0,"requestStart":686.6000000089407,"responseEnd":754.8000000119209,"responseStart":754.8000000119209,"secureConnectionStart":686.6000000089407},{"duration":109.70000000298023,"initiatorType":"script","name":"https://www.google-analytics.com/analytics.js","startTime":717.5,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":717.5,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":827.2000000029802,"responseStart":0,"secureConnectionStart":0},{"duration":25.299999997019768,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":841.6000000089407,"connectEnd":841.6000000089407,"connectStart":841.6000000089407,"domainLookupEnd":841.6000000089407,"domainLookupStart":841.6000000089407,"fetchStart":841.6000000089407,"redirectEnd":0,"redirectStart":0,"requestStart":841.6000000089407,"responseEnd":866.9000000059605,"responseStart":866.9000000059605,"secureConnectionStart":841.6000000089407}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":3,"responseStart":178,"responseEnd":180,"domLoading":195,"domInteractive":867,"domContentLoadedEventStart":867,"domContentLoadedEventEnd":902,"domComplete":1213,"loadEventStart":1213,"loadEventEnd":1214,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":828.9000000059605},{"name":"bigPipe.sidebar-id.end","time":829.6000000089407},{"name":"bigPipe.activity-panel-pipe-id.start","time":829.7000000029802},{"name":"bigPipe.activity-panel-pipe-id.end","time":832.1000000089407},{"name":"activityTabFullyLoaded","time":923.5}],"measures":[],"correlationId":"50fb58800c047","effectiveType":"4g","downlink":10,"rtt":0,"serverDuration":116,"dbReadsTimeInMs":22,"dbConnsTimeInMs":33,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}