Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-8429

Change binlog_checksum default to match MySQL 5.6.6+

Details

    • Bug
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • 5.5.44, 10.0.19
    • 10.2.1
    • Replication
    • None
    • 10.2.1-3

    Description

      MySQL changed the default for binlig_checksum from NONE to CRC32 between MySQL 5.6.5 and 5.6.6.

      MariaDB still has NONE as default though.

      This probably happened as the backport to MariaDB happened before MySQL 5.6.6 and the changed default went unnoticed so far?

      Attachments

        Issue Links

          is blocked by

          Bug - A problem which impairs or prevents the functions of the product. MDEV-8428 Mangled DML statements on 2nd level slave when enabling binlog checksums

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed
          is part of

          Task - A task that needs to be done. MDEV-7635 update defaults and simplify mysqld config parameters

          • Blocker - Blocks development and/or testing work, production could not run.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            hholzgra Hartmut Holzgraefe created issue -
            hholzgra Hartmut Holzgraefe made changes -
            Field Original Value New Value
            elenst Elena Stepanova added a comment -

            I don't think it was an overlook per se, 10.0 has never been claimed to include all 5.6 features, but rather a cherry-picked subset of them.
            For 10.1 the subset has been extended, although still not complete.
            Particularly for defaults, there is MDEV-6066 that is currently being worked on .

            I can't imagine such a change can be backported to 10.0 now, but once again the final decision will not be mine. For now, I'm assigning it to sanja who is working on MDEV-6066.

            elenst Elena Stepanova added a comment - I don't think it was an overlook per se, 10.0 has never been claimed to include all 5.6 features, but rather a cherry-picked subset of them. For 10.1 the subset has been extended, although still not complete. Particularly for defaults, there is MDEV-6066 that is currently being worked on . I can't imagine such a change can be backported to 10.0 now, but once again the final decision will not be mine. For now, I'm assigning it to sanja who is working on MDEV-6066 .
            elenst Elena Stepanova made changes -
            Fix Version/s 10.1 [ 16100 ]
            Assignee Oleksandr Byelkin [ sanja ]
            simon.mudd Simon J Mudd added a comment -

            Please do not make incompatible changes in 10.0. That's not good.

            However, consider adjusting the default behaviour to match MySQL 5.6+ in MariaDB 10.1, as 10.1 is not GA yet.
            This simplifies the situation for people who may switch between both systems and expect the configuration to be mostly the same.

            simon.mudd Simon J Mudd added a comment - Please do not make incompatible changes in 10.0. That's not good. However, consider adjusting the default behaviour to match MySQL 5.6+ in MariaDB 10.1, as 10.1 is not GA yet. This simplifies the situation for people who may switch between both systems and expect the configuration to be mostly the same.
            danblack Daniel Black made changes -
            danblack Daniel Black made changes -
            Fix Version/s 10.2 [ 14601 ]
            Fix Version/s 10.1 [ 16100 ]
            serg Sergei Golubchik made changes -
            Priority Minor [ 4 ] Major [ 3 ]
            serg Sergei Golubchik made changes -
            serg Sergei Golubchik made changes -
            sanja Oleksandr Byelkin made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            sanja Oleksandr Byelkin added a comment -

            As I can see MariaDB has no such parameter at all, am I right?

            sanja Oleksandr Byelkin added a comment - As I can see MariaDB has no such parameter at all, am I right?
            sanja Oleksandr Byelkin added a comment -

            We have slave_sql_verify_checksum and it set to ON by default which effectively equal to binlog_checksum CRC32.
            So do we need alias of the parameter or what?

            sanja Oleksandr Byelkin added a comment - We have slave_sql_verify_checksum and it set to ON by default which effectively equal to binlog_checksum CRC32. So do we need alias of the parameter or what?
            sanja Oleksandr Byelkin added a comment -

            OK, we have it as a plugin variable of binlog. I found it.

            sanja Oleksandr Byelkin added a comment - OK, we have it as a plugin variable of binlog. I found it.
            sanja Oleksandr Byelkin added a comment -

            revision-id: c8a8df7bc925a3991716da04868057eac20f82f1 (mariadb-10.2.0-29-gc8a8df7)
            parent(s): b79944950e5e5db40cf7ad49061edf5f105512c4
            committer: Oleksandr Byelkin
            timestamp: 2016-05-16 16:32:45 +0200
            message:

            MDEV-8429: Change binlog_checksum default to match MySQL 5.6.6+

            —

            sanja Oleksandr Byelkin added a comment - revision-id: c8a8df7bc925a3991716da04868057eac20f82f1 (mariadb-10.2.0-29-gc8a8df7) parent(s): b79944950e5e5db40cf7ad49061edf5f105512c4 committer: Oleksandr Byelkin timestamp: 2016-05-16 16:32:45 +0200 message: MDEV-8429 : Change binlog_checksum default to match MySQL 5.6.6+ —
            sanja Oleksandr Byelkin made changes -
            Assignee Oleksandr Byelkin [ sanja ] Sergei Golubchik [ serg ]
            Status In Progress [ 3 ] In Review [ 10002 ]
            ratzpo Rasmus Johansson (Inactive) made changes -
            Sprint 10.2.1-3 [ 65 ]
            ratzpo Rasmus Johansson (Inactive) made changes -
            Rank Ranked higher
            serg Sergei Golubchik made changes -
            Assignee Sergei Golubchik [ serg ] Oleksandr Byelkin [ sanja ]
            Status In Review [ 10002 ] Stalled [ 10000 ]
            serg Sergei Golubchik added a comment -

            ok to push

            serg Sergei Golubchik added a comment - ok to push
            sanja Oleksandr Byelkin made changes -
            Status Stalled [ 10000 ] In Progress [ 3 ]
            sanja Oleksandr Byelkin made changes -
            Fix Version/s 10.2.1 [ 22012 ]
            Fix Version/s 10.2 [ 14601 ]
            Resolution Fixed [ 1 ]
            Status In Progress [ 3 ] Closed [ 6 ]
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 70503 ] MariaDB v4 [ 149340 ]

            People

              sanja Oleksandr Byelkin
              hholzgra Hartmut Holzgraefe
              Votes:
              1 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.