Sprint:
10.1.6-2, 10.1.8-1
The patch for MDEV-7824 is going to add a few useful helper methods.
During review, Sergei suggested to use these new methods in the other code parts:
This is ok, but then, please, see what other places in the code you can
change to use your new helpers. In a separate commit, of course. I
suspect there's a lot of code that's doing, like
/* Get the value from default_values */
diff= (my_ptrdiff_t) (orig_field->table->s->default_values-
orig_field->table->record[0]);
orig_field->move_field_offset(diff); // Points now at default_values
if (orig_field->is_real_null())
field->set_null();
else
{
field->set_notnull();
memcpy(field->ptr, orig_field->ptr, field->pack_length());
}
orig_field->move_field_offset(-diff); // Back to record[0]
(this is from create_tmp_table() in sql_select.cc)
There are no comments yet on this issue.
{"report":{"fcp":812.6999998092651,"ttfb":216.09999990463257,"pageVisibility":"visible","entityId":51960,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":1,"journeyId":"1be27a18-76d8-4d59-9ab7-37546438798c","navigationType":0,"readyForUser":880.5,"redirectCount":0,"resourceLoadedEnd":581.5999999046326,"resourceLoadedStart":224.89999961853027,"resourceTiming":[{"duration":53.80000019073486,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":224.89999961853027,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":224.89999961853027,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":278.69999980926514,"responseStart":0,"secureConnectionStart":0},{"duration":54.19999980926514,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":225.19999980926514,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":225.19999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":279.3999996185303,"responseStart":0,"secureConnectionStart":0},{"duration":182.90000009536743,"initiatorType":"script","name":"https://jira.mariadb.org/s/fbf975c0cce4b1abf04784eeae9ba1f4-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":225.2999997138977,"connectEnd":225.2999997138977,"connectStart":225.2999997138977,"domainLookupEnd":225.2999997138977,"domainLookupStart":225.2999997138977,"fetchStart":225.2999997138977,"redirectEnd":0,"redirectStart":0,"requestStart":280.7999997138977,"responseEnd":408.19999980926514,"responseStart":333.5,"secureConnectionStart":225.2999997138977},{"duration":320.30000019073486,"initiatorType":"script","name":"https://jira.mariadb.org/s/099b33461394b8015fc36c0a4b96e19f-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":225.7999997138977,"connectEnd":225.7999997138977,"connectStart":225.7999997138977,"domainLookupEnd":225.7999997138977,"domainLookupStart":225.7999997138977,"fetchStart":225.7999997138977,"redirectEnd":0,"redirectStart":0,"requestStart":281.59999990463257,"responseEnd":546.0999999046326,"responseStart":314.2999997138977,"secureConnectionStart":225.7999997138977},{"duration":114.60000038146973,"initiatorType":"script","name":"https://jira.mariadb.org/s/94c15bff32baef80f4096a08aceae8bc-CDN/lu2bu7/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":225.89999961853027,"connectEnd":225.89999961853027,"connectStart":225.89999961853027,"domainLookupEnd":225.89999961853027,"domainLookupStart":225.89999961853027,"fetchStart":225.89999961853027,"redirectEnd":0,"redirectStart":0,"requestStart":284.8999996185303,"responseEnd":340.5,"responseStart":339.3999996185303,"secureConnectionStart":225.89999961853027},{"duration":85.69999980926514,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":226,"connectEnd":226,"connectStart":226,"domainLookupEnd":226,"domainLookupStart":226,"fetchStart":226,"redirectEnd":0,"redirectStart":0,"requestStart":286.3999996185303,"responseEnd":311.69999980926514,"responseStart":309.5,"secureConnectionStart":226},{"duration":85.7999997138977,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":226.09999990463257,"connectEnd":226.09999990463257,"connectStart":226.09999990463257,"domainLookupEnd":226.09999990463257,"domainLookupStart":226.09999990463257,"fetchStart":226.09999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":288.2999997138977,"responseEnd":311.8999996185303,"responseStart":310.2999997138977,"secureConnectionStart":226.09999990463257},{"duration":58.30000019073486,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2bu7/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":226.19999980926514,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":226.19999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":284.5,"responseStart":0,"secureConnectionStart":0},{"duration":106.30000019073486,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":226.2999997138977,"connectEnd":226.2999997138977,"connectStart":226.2999997138977,"domainLookupEnd":226.2999997138977,"domainLookupStart":226.2999997138977,"fetchStart":226.2999997138977,"redirectEnd":0,"redirectStart":0,"requestStart":288.7999997138977,"responseEnd":332.59999990463257,"responseStart":328.69999980926514,"secureConnectionStart":226.2999997138977},{"duration":59.90000009536743,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":226.39999961853027,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":226.39999961853027,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":286.2999997138977,"responseStart":0,"secureConnectionStart":0},{"duration":105.89999961853027,"initiatorType":"script","name":"https://jira.mariadb.org/s/3339d87fa2538a859872f2df449bf8d0-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":226.5,"connectEnd":226.5,"connectStart":226.5,"domainLookupEnd":226.5,"domainLookupStart":226.5,"fetchStart":226.5,"redirectEnd":0,"redirectStart":0,"requestStart":289.5,"responseEnd":332.3999996185303,"responseStart":328.19999980926514,"secureConnectionStart":226.5},{"duration":333,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":228,"connectEnd":228,"connectStart":228,"domainLookupEnd":228,"domainLookupStart":228,"fetchStart":228,"redirectEnd":0,"redirectStart":0,"requestStart":319.09999990463257,"responseEnd":561,"responseStart":548.0999999046326,"secureConnectionStart":228},{"duration":353.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":228.09999990463257,"connectEnd":228.09999990463257,"connectStart":228.09999990463257,"domainLookupEnd":228.09999990463257,"domainLookupStart":228.09999990463257,"fetchStart":228.09999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":570.1999998092651,"responseEnd":581.5999999046326,"responseStart":581,"secureConnectionStart":228.09999990463257},{"duration":197.40000009536743,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":536.2999997138977,"connectEnd":536.2999997138977,"connectStart":536.2999997138977,"domainLookupEnd":536.2999997138977,"domainLookupStart":536.2999997138977,"fetchStart":536.2999997138977,"redirectEnd":0,"redirectStart":0,"requestStart":705.0999999046326,"responseEnd":733.6999998092651,"responseStart":732.8999996185303,"secureConnectionStart":536.2999997138977},{"duration":251.80000019073486,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":769.7999997138977,"connectEnd":769.7999997138977,"connectStart":769.7999997138977,"domainLookupEnd":769.7999997138977,"domainLookupStart":769.7999997138977,"fetchStart":769.7999997138977,"redirectEnd":0,"redirectStart":0,"requestStart":991.2999997138977,"responseEnd":1021.5999999046326,"responseStart":1020.6999998092651,"secureConnectionStart":769.7999997138977}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":64,"responseStart":216,"responseEnd":225,"domLoading":219,"domInteractive":977,"domContentLoadedEventStart":977,"domContentLoadedEventEnd":1020,"domComplete":1345,"loadEventStart":1345,"loadEventEnd":1346,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":961.2999997138977},{"name":"bigPipe.sidebar-id.end","time":962.0999999046326},{"name":"bigPipe.activity-panel-pipe-id.start","time":962.1999998092651},{"name":"bigPipe.activity-panel-pipe-id.end","time":962.6999998092651},{"name":"activityTabFullyLoaded","time":1031.5}],"measures":[],"correlationId":"8e49da11a4231e","effectiveType":"4g","downlink":10,"rtt":0,"serverDuration":89,"dbReadsTimeInMs":11,"dbConnsTimeInMs":19,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}