Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-8053

[PATCH] move to c99 style for structure members

Details

    Description

      While getting travis-ci ready I'm testing with gcc and clang.

      clang is a lot more fussy and generates pages of warnings. There is an output limit in travis-ci that these warnings cause to exceed. These warnings overall contribute to about 1/2 the output.

      C99 isn't too much of a leap forward from C89

      patch: https://github.com/MariaDB/server/pull/52

      Attachments

        Issue Links

          relates to

          Task - A task that needs to be done. MDEV-6262 analyze the coverity report on mariadb

          • Major - Major loss of function.
          • Open

          Activity

            Ascending order - Click to sort in descending order
            View 4 older comments
            jplindst Jan Lindström (Inactive) added a comment -

            c99 style initializers require gcc 4.7

            e.g http://buildbot.askmonty.org/buildbot/builders/kvm-deb-jessie-amd64/builds/4/steps/compile/logs/stdio

            Need to use CHECK_C_SOURCE_COMPILES() in cmake and define some HAVE_xxx that can then be used as compiler preprocessor definition.

            jplindst Jan Lindström (Inactive) added a comment - c99 style initializers require gcc 4.7 e.g http://buildbot.askmonty.org/buildbot/builders/kvm-deb-jessie-amd64/builds/4/steps/compile/logs/stdio Need to use CHECK_C_SOURCE_COMPILES() in cmake and define some HAVE_xxx that can then be used as compiler preprocessor definition.
            jplindst Jan Lindström (Inactive) added a comment -

            Buildbot compiler problems.

            jplindst Jan Lindström (Inactive) added a comment - Buildbot compiler problems.
            danblack Daniel Black added a comment -

            I was going off https://mariadb.com/kb/en/mariadb/building-mariadb-release-on-ubuntu-1204-lts-precise-pangolin/ and assuming 4.7 was the minimum version.

            danblack Daniel Black added a comment - I was going off https://mariadb.com/kb/en/mariadb/building-mariadb-release-on-ubuntu-1204-lts-precise-pangolin/ and assuming 4.7 was the minimum version.
            danblack Daniel Black added a comment -

            nice fix on commits list. thanks.

            danblack Daniel Black added a comment - nice fix on commits list. thanks.
            jplindst Jan Lindström (Inactive) added a comment -

            commit 3832bda1ba9f31294d57b565030ea3f5d35e6a82
            Author: Jan Lindström <jan.lindstrom@mariadb.com>
            Date: Thu May 7 14:00:14 2015 +0300

            Fix compiler error if compiler does not support c99 style
            initializers.

            jplindst Jan Lindström (Inactive) added a comment - commit 3832bda1ba9f31294d57b565030ea3f5d35e6a82 Author: Jan Lindström <jan.lindstrom@mariadb.com> Date: Thu May 7 14:00:14 2015 +0300 Fix compiler error if compiler does not support c99 style initializers.

            People

              jplindst Jan Lindström (Inactive)
              danblack Daniel Black
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.