Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-8053

[PATCH] move to c99 style for structure members

Details

    Description

      While getting travis-ci ready I'm testing with gcc and clang.

      clang is a lot more fussy and generates pages of warnings. There is an output limit in travis-ci that these warnings cause to exceed. These warnings overall contribute to about 1/2 the output.

      C99 isn't too much of a leap forward from C89

      patch: https://github.com/MariaDB/server/pull/52

      Attachments

        Issue Links

          relates to

          Task - A task that needs to be done. MDEV-6262 analyze the coverity report on mariadb

          • Major - Major loss of function.
          • Open

          Activity

            Ascending order - Click to sort in descending order
            danblack Daniel Black created issue -
            danblack Daniel Black made changes -
            Field Original Value New Value
            danblack Daniel Black added a comment -

            mariadb-10.1 has those definitions in the include file so 10.1 patch here: https://github.com/MariaDB/server/pull/54

            danblack Daniel Black added a comment - mariadb-10.1 has those definitions in the include file so 10.1 patch here: https://github.com/MariaDB/server/pull/54
            danblack Daniel Black made changes -
            Summary move to c99 style for structure members [PATCH] move to c99 style for structure members
            elenst Elena Stepanova made changes -
            Component/s Storage Engine - InnoDB [ 10129 ]
            Component/s Storage Engine - XtraDB [ 10135 ]
            Fix Version/s 10.1 [ 16100 ]
            Assignee Jan Lindström [ jplindst ]
            Priority Minor [ 4 ] Major [ 3 ]
            jplindst Jan Lindström (Inactive) made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            jplindst Jan Lindström (Inactive) added a comment -

            Merged pull requests.

            jplindst Jan Lindström (Inactive) added a comment - Merged pull requests.
            jplindst Jan Lindström (Inactive) made changes -
            Fix Version/s 10.1.5 [ 18813 ]
            Fix Version/s 5.5.44 [ 19100 ]
            Fix Version/s 10.1 [ 16100 ]
            Resolution Fixed [ 1 ]
            Status In Progress [ 3 ] Closed [ 6 ]
            jplindst Jan Lindström (Inactive) added a comment -

            Daniel,

            Some of the compiler(s) do not like this: /home/buildbot/buildbot/build/mariadb-10.1.5/storage/xtradb/handler/i_s.cc:348:3: error: expected primary-expression before ‘.’ token

            jplindst Jan Lindström (Inactive) added a comment - Daniel, Some of the compiler(s) do not like this: /home/buildbot/buildbot/build/mariadb-10.1.5/storage/xtradb/handler/i_s.cc:348:3: error: expected primary-expression before ‘.’ token
            danblack Daniel Black added a comment -

            which ones/versions?

            Can a compiler preprocessor definition be used to push these compiles to the alternate #else initialisation?

            danblack Daniel Black added a comment - which ones/versions? Can a compiler preprocessor definition be used to push these compiles to the alternate #else initialisation?
            jplindst Jan Lindström (Inactive) added a comment -

            c99 style initializers require gcc 4.7

            e.g http://buildbot.askmonty.org/buildbot/builders/kvm-deb-jessie-amd64/builds/4/steps/compile/logs/stdio

            Need to use CHECK_C_SOURCE_COMPILES() in cmake and define some HAVE_xxx that can then be used as compiler preprocessor definition.

            jplindst Jan Lindström (Inactive) added a comment - c99 style initializers require gcc 4.7 e.g http://buildbot.askmonty.org/buildbot/builders/kvm-deb-jessie-amd64/builds/4/steps/compile/logs/stdio Need to use CHECK_C_SOURCE_COMPILES() in cmake and define some HAVE_xxx that can then be used as compiler preprocessor definition.
            jplindst Jan Lindström (Inactive) added a comment -

            Buildbot compiler problems.

            jplindst Jan Lindström (Inactive) added a comment - Buildbot compiler problems.
            jplindst Jan Lindström (Inactive) made changes -
            Resolution Fixed [ 1 ]
            Status Closed [ 6 ] Stalled [ 10000 ]
            danblack Daniel Black added a comment -

            I was going off https://mariadb.com/kb/en/mariadb/building-mariadb-release-on-ubuntu-1204-lts-precise-pangolin/ and assuming 4.7 was the minimum version.

            danblack Daniel Black added a comment - I was going off https://mariadb.com/kb/en/mariadb/building-mariadb-release-on-ubuntu-1204-lts-precise-pangolin/ and assuming 4.7 was the minimum version.
            danblack Daniel Black added a comment -

            nice fix on commits list. thanks.

            danblack Daniel Black added a comment - nice fix on commits list. thanks.
            jplindst Jan Lindström (Inactive) added a comment -

            commit 3832bda1ba9f31294d57b565030ea3f5d35e6a82
            Author: Jan Lindström <jan.lindstrom@mariadb.com>
            Date: Thu May 7 14:00:14 2015 +0300

            Fix compiler error if compiler does not support c99 style
            initializers.

            jplindst Jan Lindström (Inactive) added a comment - commit 3832bda1ba9f31294d57b565030ea3f5d35e6a82 Author: Jan Lindström <jan.lindstrom@mariadb.com> Date: Thu May 7 14:00:14 2015 +0300 Fix compiler error if compiler does not support c99 style initializers.
            jplindst Jan Lindström (Inactive) made changes -
            Resolution Fixed [ 1 ]
            Status Stalled [ 10000 ] Closed [ 6 ]
            ratzpo Rasmus Johansson (Inactive) made changes -
            Workflow MariaDB v2 [ 60670 ] MariaDB v3 [ 63960 ]
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 63960 ] MariaDB v4 [ 149093 ]

            People

              jplindst Jan Lindström (Inactive)
              danblack Daniel Black
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.