Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-7977

[PATCH] MYSQL_BIN_LOG::write_incident failing to release LOCK_log

Details

    Description

      sql/log.cc

      MYSQL_BIN_LOG::write_incident
      		 
       
      		 
        mysql_mutex_lock(&LOCK_log);
      		 
        if (likely(is_open()))
      		 
              ...
      		 
              mysql_mutex_unlock(&LOCK_log);
      		 
        }
      		 
        DBUG_RETURN(error);
      		 
       

      There is no mysql_mutex_unlock(LOCK_log) in the !likely(is_open()) if branch. It seems the caller of this function doesn't release it either.

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          danblack Daniel Black created issue -
          danblack Daniel Black made changes -
          Field Original Value New Value
          Description sql/log.cc
          {noformat}
          MYSQL_BIN_LOG::write_incident

            mysql_mutex_lock(&LOCK_log);
            if (likely(is_open()))
                  ...
                  mysql_mutex_unlock(&LOCK_log);
            }
            DBUG_RETURN(error);

          {noformat}

          There is no mutex_nounlock(LOCK_log) in the !likely(is_open()) if branch. It seems the caller of this function doesn't release it either.           		sql/log.cc
          {noformat}
          MYSQL_BIN_LOG::write_incident

            mysql_mutex_lock(&LOCK_log);
            if (likely(is_open()))
                  ...
                  mysql_mutex_unlock(&LOCK_log);
            }
            DBUG_RETURN(error);

          {noformat}

          There is no mysql_mutex_unlock(LOCK_log) in the !likely(is_open()) if branch. It seems the caller of this function doesn't release it either.
          elenst Elena Stepanova made changes -
          Fix Version/s 10.1 [ 16100 ]
          Fix Version/s 10.0 [ 16000 ]
          Fix Version/s 5.5 [ 15800 ]
          Assignee Kristian Nielsen [ knielsen ]
          Summary MYSQL_BIN_LOG::write_incident failing to release LOCK_log [PATCH] MYSQL_BIN_LOG::write_incident failing to release LOCK_log
          knielsen Kristian Nielsen made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          knielsen Kristian Nielsen made changes -
          Fix Version/s 5.5.43 [ 18601 ]
          Fix Version/s 5.5 [ 15800 ]
          Fix Version/s 10.0 [ 16000 ]
          Fix Version/s 10.1 [ 16100 ]
          Resolution Fixed [ 1 ]
          Status In Progress [ 3 ] Closed [ 6 ]
          ratzpo Rasmus Johansson (Inactive) made changes -
          Workflow MariaDB v2 [ 60437 ] MariaDB v3 [ 66306 ]
          serg Sergei Golubchik made changes -
          Workflow MariaDB v3 [ 66306 ] MariaDB v4 [ 149044 ]

          People

            knielsen Kristian Nielsen
            danblack Daniel Black
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.