[MDEV-7977] [PATCH] MYSQL_BIN_LOG::write_incident failing to release LOCK_log Created: 2015-04-11  Updated: 2015-04-24  Resolved: 2015-04-24

Status: Closed
Project: MariaDB Server
Component/s: Replication
Affects Version/s: 5.5.42, 10.0
Fix Version/s: 5.5.43

Type: Bug Priority: Major
Reporter: Daniel Black Assignee: Kristian Nielsen
Resolution: Fixed Votes: 0
Labels: binlog, replication


 Description   

sql/log.cc

MYSQL_BIN_LOG::write_incident
 
 
 
  mysql_mutex_lock(&LOCK_log);
 
  if (likely(is_open()))
 
        ...
 
        mysql_mutex_unlock(&LOCK_log);
 
  }
 
  DBUG_RETURN(error);
 
 

There is no mysql_mutex_unlock(LOCK_log) in the !likely(is_open()) if branch. It seems the caller of this function doesn't release it either.

 Comments   
Comment by Daniel Black [ 2015-04-11 ]

https://github.com/MariaDB/server/pull/39

Comment by Kristian Nielsen [ 2015-04-24 ]

Pulled, thanks Daniel!

Generated at Thu Feb 08 07:23:43 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.