Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-7937

Enforce SSL when --ssl client option is used

Details

    • Task
    • Status: Closed (View Workflow)
    • Critical
    • Resolution: Fixed
    • 5.5.44
    • SSL
    • 5.5.44

    Description

      Attachments

        Issue Links

          causes

          Bug - A problem which impairs or prevents the functions of the product. MDEV-10246 ssl-* have no effect without mysql_ssl_set()

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            serg Sergei Golubchik added a comment -

            as discussed in emails, let's keep --ssl as is and fix CLIENT_SSL_VERIFY_SERVER_CERT instead.

            serg Sergei Golubchik added a comment - as discussed in emails, let's keep --ssl as is and fix CLIENT_SSL_VERIFY_SERVER_CERT instead.
            serg Sergei Golubchik added a comment -

            Another option would be to make CLIENT_SSL_VERIFY_SERVER_CERT enabled by default and make --ssl to be required if CLIENT_SSL_VERIFY_SERVER_CERT is enabled and optional if it is disabled. This might be easier to use than the previous suggestion.

            Either way, the point is — without certificate checks the --ssl option doesn't guarantee anything, so requiring SSL that way does not make a lot of sense.

            serg Sergei Golubchik added a comment - Another option would be to make CLIENT_SSL_VERIFY_SERVER_CERT enabled by default and make --ssl to be required if CLIENT_SSL_VERIFY_SERVER_CERT is enabled and optional if it is disabled. This might be easier to use than the previous suggestion. Either way, the point is — without certificate checks the --ssl option doesn't guarantee anything, so requiring SSL that way does not make a lot of sense.
            serg Sergei Golubchik added a comment -

            ok to push with tests

            serg Sergei Golubchik added a comment - ok to push with tests
            cvicentiu Vicențiu Ciorbaru added a comment -

            Fixed with:
            https://github.com/MariaDB/server/compare/56e2d8318bf3...be5035b4f4e4

            cvicentiu Vicențiu Ciorbaru added a comment - Fixed with: https://github.com/MariaDB/server/compare/56e2d8318bf3...be5035b4f4e4

            People

              cvicentiu Vicențiu Ciorbaru
              nirbhay_c Nirbhay Choubey (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.