The test main.innodb_bug39438 adds a test-specific suppression via mtr.add_suppression. So far so good.
The test runner runs this test, and it passes (call mtr.check_warnings skips the expected warning).
Then, sub check_warnings_post_shutdown runs. This completely ignores any per-test warnings and finds the expected warning (that was supposed to be suppressed) in the warning log and fails:
Errors/warnings were found in logfiles during server shutdown after running the
following sequence(s) of tests:
main.innodb_bug39438
mysql-test-run: *** ERROR: There where errors/warnings in server logs after running test c
ases.
Note: mtr.add_suppression is doing its job correctly, but the _post_shutdown routine completely ignores such suppressions, only using the extract_warning_lines perl routine.
Re: check_warnings_post_shutdown ignores per-test suppressions
I agree that this is a problem. Checking for (and suppressing) warnings inside the mysqld being tested is broken design, as it does not work to test the server during shutdown.
One way to fix this is to change mtr.add_suppression() to write the added suppressions to a CSV type table. Then the underlying .csv file could be read by the mysql-test-run.pl script and all warning checks could take place there.
A possibly better option would be to change the mtr.add_suppression() into a native mysqltest command, which would be more robust and could write suppressions into a file for mysql-test-run.pl to inspect.
Until this is implemented, possible work-arounds include:
1. Delay test case end until expected warnings hit the log (eg. sync_slave_with_master at end of test script or similar).
2. If 1 is not possible, add a global suppression in mysql-test-run.pl, possibly changing table names etc. to be more unique (to avoid accidentally suppressing real warnings)
Kristian Nielsen
added a comment - Re: check_warnings_post_shutdown ignores per-test suppressions
I agree that this is a problem. Checking for (and suppressing) warnings inside the mysqld being tested is broken design, as it does not work to test the server during shutdown.
One way to fix this is to change mtr.add_suppression() to write the added suppressions to a CSV type table. Then the underlying .csv file could be read by the mysql-test-run.pl script and all warning checks could take place there.
A possibly better option would be to change the mtr.add_suppression() into a native mysqltest command, which would be more robust and could write suppressions into a file for mysql-test-run.pl to inspect.
Until this is implemented, possible work-arounds include:
1. Delay test case end until expected warnings hit the log (eg. sync_slave_with_master at end of test script or similar).
2. If 1 is not possible, add a global suppression in mysql-test-run.pl, possibly changing table names etc. to be more unique (to avoid accidentally suppressing real warnings)
It is not happening with the mentioned test anymore, but the general point is till valid – there is no good way to suppress warnings produced on server shutdown, or warnings that MTR considers being generated on server shutdown.
Elena Stepanova
added a comment - It is not happening with the mentioned test anymore, but the general point is till valid – there is no good way to suppress warnings produced on server shutdown, or warnings that MTR considers being generated on server shutdown.
People
Unassigned
Alex Budovski (Inactive)
Votes:
0Vote for this issue
Watchers:
3Start watching this issue
Dates
Created:
Updated:
Resolved:
Git Integration
Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.
{"report":{"fcp":791.9000000953674,"ttfb":225,"pageVisibility":"visible","entityId":20277,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":1,"journeyId":"8ee50ee0-cc6b-4928-8de6-3855df3c2811","navigationType":0,"readyForUser":858.1000001430511,"redirectCount":0,"resourceLoadedEnd":571.6000001430511,"resourceLoadedStart":231.30000019073486,"resourceTiming":[{"duration":63.299999952316284,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":231.30000019073486,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":231.30000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":294.60000014305115,"responseStart":0,"secureConnectionStart":0},{"duration":63.299999952316284,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":231.60000014305115,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":231.60000014305115,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":294.90000009536743,"responseStart":0,"secureConnectionStart":0},{"duration":116.79999995231628,"initiatorType":"script","name":"https://jira.mariadb.org/s/fbf975c0cce4b1abf04784eeae9ba1f4-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":231.70000004768372,"connectEnd":231.70000004768372,"connectStart":231.70000004768372,"domainLookupEnd":231.70000004768372,"domainLookupStart":231.70000004768372,"fetchStart":231.70000004768372,"redirectEnd":0,"redirectStart":0,"requestStart":297.90000009536743,"responseEnd":348.5,"responseStart":310.80000019073486,"secureConnectionStart":231.70000004768372},{"duration":128.89999985694885,"initiatorType":"script","name":"https://jira.mariadb.org/s/099b33461394b8015fc36c0a4b96e19f-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":231.80000019073486,"connectEnd":231.80000019073486,"connectStart":231.80000019073486,"domainLookupEnd":231.80000019073486,"domainLookupStart":231.80000019073486,"fetchStart":231.80000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":298.60000014305115,"responseEnd":360.7000000476837,"responseStart":311.30000019073486,"secureConnectionStart":231.80000019073486},{"duration":78.30000019073486,"initiatorType":"script","name":"https://jira.mariadb.org/s/94c15bff32baef80f4096a08aceae8bc-CDN/lu2bu7/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":232,"connectEnd":232,"connectStart":232,"domainLookupEnd":232,"domainLookupStart":232,"fetchStart":232,"redirectEnd":0,"redirectStart":0,"requestStart":299.60000014305115,"responseEnd":310.30000019073486,"responseStart":309.2000000476837,"secureConnectionStart":232},{"duration":84.79999995231628,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":232.10000014305115,"connectEnd":232.10000014305115,"connectStart":232.10000014305115,"domainLookupEnd":232.10000014305115,"domainLookupStart":232.10000014305115,"fetchStart":232.10000014305115,"redirectEnd":0,"redirectStart":0,"requestStart":300.7000000476837,"responseEnd":316.90000009536743,"responseStart":316,"secureConnectionStart":232.10000014305115},{"duration":68.79999995231628,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2bu7/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":232.20000004768372,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":232.20000004768372,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":301,"responseStart":0,"secureConnectionStart":0},{"duration":101,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":232.20000004768372,"connectEnd":232.20000004768372,"connectStart":232.20000004768372,"domainLookupEnd":232.20000004768372,"domainLookupStart":232.20000004768372,"fetchStart":232.20000004768372,"redirectEnd":0,"redirectStart":0,"requestStart":305,"responseEnd":333.2000000476837,"responseStart":332.7000000476837,"secureConnectionStart":232.20000004768372},{"duration":100.29999995231628,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":232.30000019073486,"connectEnd":232.30000019073486,"connectStart":232.30000019073486,"domainLookupEnd":232.30000019073486,"domainLookupStart":232.30000019073486,"fetchStart":232.30000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":305.7000000476837,"responseEnd":332.60000014305115,"responseStart":331.7000000476837,"secureConnectionStart":232.30000019073486},{"duration":74.40000009536743,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":232.5,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":232.5,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":306.90000009536743,"responseStart":0,"secureConnectionStart":0},{"duration":94.89999985694885,"initiatorType":"script","name":"https://jira.mariadb.org/s/3339d87fa2538a859872f2df449bf8d0-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":232.60000014305115,"connectEnd":313.80000019073486,"connectStart":313.80000019073486,"domainLookupEnd":313.80000019073486,"domainLookupStart":313.80000019073486,"fetchStart":232.60000014305115,"redirectEnd":0,"redirectStart":0,"requestStart":314,"responseEnd":327.5,"responseStart":324.7000000476837,"secureConnectionStart":313.80000019073486},{"duration":330.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":241.10000014305115,"connectEnd":241.10000014305115,"connectStart":241.10000014305115,"domainLookupEnd":241.10000014305115,"domainLookupStart":241.10000014305115,"fetchStart":241.10000014305115,"redirectEnd":0,"redirectStart":0,"requestStart":535.8000001907349,"responseEnd":571.6000001430511,"responseStart":567.9000000953674,"secureConnectionStart":241.10000014305115},{"duration":329.2000000476837,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":242.10000014305115,"connectEnd":242.10000014305115,"connectStart":242.10000014305115,"domainLookupEnd":242.10000014305115,"domainLookupStart":242.10000014305115,"fetchStart":242.10000014305115,"redirectEnd":0,"redirectStart":0,"requestStart":536.4000000953674,"responseEnd":571.3000001907349,"responseStart":566.6000001430511,"secureConnectionStart":242.10000014305115},{"duration":209.10000014305115,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":557.2000000476837,"connectEnd":557.2000000476837,"connectStart":557.2000000476837,"domainLookupEnd":557.2000000476837,"domainLookupStart":557.2000000476837,"fetchStart":557.2000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":733.3000001907349,"responseEnd":766.3000001907349,"responseStart":764.9000000953674,"secureConnectionStart":557.2000000476837},{"duration":98.5,"initiatorType":"script","name":"https://www.google-analytics.com/analytics.js","startTime":767.3000001907349,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":767.3000001907349,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":865.8000001907349,"responseStart":0,"secureConnectionStart":0},{"duration":130.70000004768372,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":790.5,"connectEnd":790.5,"connectStart":790.5,"domainLookupEnd":790.5,"domainLookupStart":790.5,"fetchStart":790.5,"redirectEnd":0,"redirectStart":0,"requestStart":891.1000001430511,"responseEnd":921.2000000476837,"responseStart":920.3000001907349,"secureConnectionStart":790.5}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":97,"responseStart":225,"responseEnd":242,"domLoading":229,"domInteractive":913,"domContentLoadedEventStart":913,"domContentLoadedEventEnd":947,"domComplete":1300,"loadEventStart":1300,"loadEventEnd":1300,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":894.8000001907349},{"name":"bigPipe.sidebar-id.end","time":895.7000000476837},{"name":"bigPipe.activity-panel-pipe-id.start","time":895.8000001907349},{"name":"bigPipe.activity-panel-pipe-id.end","time":897.1000001430511},{"name":"activityTabFullyLoaded","time":963.9000000953674}],"measures":[],"correlationId":"e89b4a1477f053","effectiveType":"4g","downlink":10,"rtt":0,"serverDuration":70,"dbReadsTimeInMs":10,"dbConnsTimeInMs":15,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}
Bug
Minor
Re: check_warnings_post_shutdown ignores per-test suppressions
I agree that this is a problem. Checking for (and suppressing) warnings inside the mysqld being tested is broken design, as it does not work to test the server during shutdown.
One way to fix this is to change mtr.add_suppression() to write the added suppressions to a CSV type table. Then the underlying .csv file could be read by the mysql-test-run.pl script and all warning checks could take place there.
A possibly better option would be to change the mtr.add_suppression() into a native mysqltest command, which would be more robust and could write suppressions into a file for mysql-test-run.pl to inspect.
Until this is implemented, possible work-arounds include:
1. Delay test case end until expected warnings hit the log (eg. sync_slave_with_master at end of test script or similar).
2. If 1 is not possible, add a global suppression in mysql-test-run.pl, possibly changing table names etc. to be more unique (to avoid accidentally suppressing real warnings)