Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-770

LP:695923 - Wrong recommendation for parameter log_slow_queries in warning during startup

    XMLWordPrintable

Details

    • Bug
    • Status: Closed (View Workflow)
    • Resolution: Fixed
    • None
    • None
    • None

    Description

      When I start the database with:

      log_slow_queries = 0

      I get the following warning:

      101231  8:15:47 [Warning] '--log_slow_queries' is deprecated and will be removed in a future release. Please use ''--slow_query_log'/'--log-slow-file'' instead.

      This is a wrong recommendation. log-slow-file is deprecated as well and slow_query_log should be used instead.

         6393   {"log-slow-queries", OPT_SLOW_QUERY_LOG,
         6394     "Log slow queries to a table or log file. Defaults logging to table "
         6395     "mysql.slow_log or hostname-slow.log if --log-output=file is used. "
         6396     "Must be enabled to activate other slow log options. "
         6397     "(deprecated option, use --slow_query_log/--slow_query_log_file instead)",
         6398    &opt_slow_logname, &opt_slow_logname, 0, GET_STR, OPT_ARG,
         6399    0, 0, 0, 0, 0, 0},
       
         8757   case (int) OPT_SLOW_QUERY_LOG:
         8758     WARN_DEPRECATED(NULL, "7.0", "--log_slow_queries", "'--slow_query_log'/'--log-slow-file'");
         8759     opt_slow_log= 1;
         8760     break;

      It also looks like we have redundant code here!

      Attachments

        1. LPexportBug695923.xml
          3 kB
          Rasmus Johansson
        2. LPexportBug695923_patch_2.diff
          0.5 kB
          Rasmus Johansson

        Activity

          People

            Unassigned Unassigned
            shinguz shinguz (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.